1
1
mirror of https://github.com/systemd/systemd-stable.git synced 2024-10-28 20:25:25 +03:00
Commit Graph

33363 Commits

Author SHA1 Message Date
Lennart Poettering
cb91deaf77 terminal-util: add a function that shows a pretty separator line
Follow-up for #8824
2018-05-11 08:15:33 +02:00
Lennart Poettering
e4915c2797
Merge pull request #8953 from yuwata/bus-macro
core: simplify dbus properties
2018-05-10 22:51:17 -07:00
Yu Watanabe
1c5873096e test-execute: remove state directories before running tests
Fixes #8679.
2018-05-10 22:50:51 -07:00
Yu Watanabe
46657f637c units: set RestrictNamespaces=yes to networkd and resolved
Closes #8949.
2018-05-10 22:50:31 -07:00
Joost Heitbrink
b6887d7ae4 test: add testcase for environment file variables with backslashes
systemd silently strips out backslashes in variables from environment
files. Add a testcase that explicitly tests for this behaviour.
2018-05-11 13:15:16 +09:00
Yu Watanabe
a9a2f9b0b1
Merge pull request #8964 from MikhailKasimov/patch-2
man: systemd-journal-upload: rsa 2048
2018-05-11 12:42:46 +09:00
Mikhail Kasimov
32f511ec2b
Update systemd-journal-upload.service.xml
Security note on 2048 bits is added.
2018-05-11 02:43:00 +03:00
Mikhail Kasimov
562b65ca38
man: systemd-journal-upload: rsa 2048
rsa:2048 is currently in use as minimal recommended key length on cert/key generating. Specifying rsa:1024 is not recommended for security reasons.
2018-05-11 02:17:27 +03:00
Lennart Poettering
81321f51cf
Merge pull request #8824 from keszybz/analyze-show-config
systemd-analyze show-config
2018-05-10 11:14:23 -07:00
Lennart Poettering
41b9d436b2 mtd: some basic code cleanups
While looking at our exit() invocations I noticed that the mtd_probe
stuff uses 'exit(-1)' at various places, which is not really a good
idea, as exit codes of processes on Linux are supposed to be in the
range of 0…255.

This patch cleans that up a bit, and fixes a number of other things:

1. Let's always let main() exit, nothing intermediary. We generally
   don't like code that invokes exit() on its own.

2. Close the file descriptors opened.

3. Some logging for errors is added, mostly on debug level.

Please review this with extra care. As I don't have the right hardware
to test this patch I only did superficial testing.
2018-05-10 11:02:33 -07:00
Susant Sahani
4319c181d4 Networkd tests: add bridge link properties to test
Test the "[Bridge]" section keys

```
[Bridge]
UnicastFlood=true
HairPin=true
UseBPDU=true
FastLeave=true
AllowPortToBeRoot=true
Cost=555
Priority=23
```

```
test_bridge_init (__main__.BridgeTest) ... ok
test_bridge_port_priority (__main__.BridgeTest) ... ok
test_bridge_port_priority_set_zero (__main__.BridgeTest)
It should be possible to set the bridge port priority to 0 ... ok
test_bridge_port_property (__main__.BridgeTest)
Test the "[Bridge]" section keys ... ok

```
2018-05-10 10:41:30 -07:00
Mikhail Kasimov
68f21002b4 man: journal-gatewayd.service: links on {rem,upl}
While set of systemd-journal-{gatewayd,remote,upload}.service services presents single subsystem on journald logs network transmission, systemd-journal-gatewayd.service description should also contain links to other parts of this subsystem: systemd-journal-remote.service and systemd-journal-upload.service.
2018-05-10 19:01:02 +02:00
Yu Watanabe
c5984fe177 string-util: rename strdash_if_empty() to empty_to_dash() 2018-05-11 01:55:46 +09:00
Yu Watanabe
945403e6ed path-util: introduce empty_to_root() and use it many places 2018-05-11 01:47:33 +09:00
Yu Watanabe
54138a8de1 core: merge duplicated functions 2018-05-11 01:41:06 +09:00
Yu Watanabe
79a603758d core: send NULL instead of empty string 2018-05-11 01:22:49 +09:00
Yu Watanabe
9d5527f26e core: use offsetof() for Syslog{Level,Facility} dbus properties 2018-05-11 00:39:52 +09:00
Zbigniew Jędrzejewski-Szmek
717fb9bc24
Merge pull request #8950 from dtardon/cleanup
use automatic cleanup more
2018-05-10 17:23:40 +02:00
Zbigniew Jędrzejewski-Szmek
99f0d70da9 github: use multiple issue templates
Github now has issue templates in the web interface, and allows
more than one to be specified. Let's split our single template
in two: bug report and RFE.
2018-05-10 07:58:38 -07:00
Yu Watanabe
3d924e7731
Merge pull request #8943 from keszybz/coverity-fixes
Coverity fixes
2018-05-10 23:22:38 +09:00
Yu Watanabe
0515650329 core: use bus_property_get_*() functions instead of NULL 2018-05-10 23:02:57 +09:00
David Tardon
2ab3a63549 sd-bus: use automatic cleanup more 2018-05-10 15:55:56 +02:00
Yu Watanabe
cf9d43a8e0 core: drop property_get_syscall_errno() 2018-05-10 22:36:13 +09:00
Yu Watanabe
c0159e2036 core: drop property_get_{capability_bounding_set,ambient_capabilities}() 2018-05-10 22:32:12 +09:00
Yu Watanabe
491eecb376 core: use BUS_DEFINE_PROPERTY_GET_ENUM() macro 2018-05-10 22:26:59 +09:00
Yu Watanabe
73b84e922e core: drop 'bus_' prefix from bus_property_get_protect_{home,system}() 2018-05-10 22:26:27 +09:00
Yu Watanabe
b3bc33e6c6 core: simplify property_get_cpu_affinity() 2018-05-10 22:25:00 +09:00
David Tardon
01111587b6 basic: use automatic cleanup more 2018-05-10 14:10:53 +02:00
David Tardon
7de91ea6c0 basic: use automatic cleanup more 2018-05-10 14:08:35 +02:00
David Tardon
921b598716 basic: use automatic cleanup more 2018-05-10 14:04:30 +02:00
David Tardon
17c9aff8ce journal: use automatic cleanup more 2018-05-10 13:42:36 +02:00
Mikhail Kasimov
7cfcb25236 man: systemd-networkd-wait-online: systemd.service (#8945)
* man: systemd-networkd-wait-online: systemd.service

While service type is mentioned (is a oneshot system service), link on systemd.service is added. 'See Also' section is also updated with link on systemd.service man-page.
2018-05-10 12:47:03 +09:00
Mikhail Kasimov
1a17bac57a man: systemd-escape: add missed short keys (#8944)
Added short keys -u and -m for --unescape and --mangle respectively. These short keys are present in systemd-escape --help output and are absent in man systemd-escape page.
2018-05-10 12:15:55 +09:00
Filipe Brandenburger
4f29e0db12 conf-parser: accept trailing backslash at the end of the file (#8941)
This makes it behave the same whether there is a blank line or not at
the end of the file.  This is also consistent with the behavior of the
shell on a shell script that ends on a trailing backslash at the last
line.

Added tests to test_config_parse(), which only pass if the corresponding
change to config_parse() is included.
2018-05-09 18:10:07 -07:00
Mikhail Kasimov
3eff246a17 add journal-upload.conf refentrytitle (#8942)
Add journal-upload.conf refentrytitle to have the same format to systemd-journal-remote.service description, which contains refentrytitle on journal-remote.conf in 'See Also' section.
2018-05-10 02:18:59 +02:00
Zbigniew Jędrzejewski-Szmek
f1470e424b core/mount-setup: remove part of check which is always true
k was set to join_controllers at this point and only incremented, so
it cannot be null at this point.

CID #1390949.
2018-05-10 02:03:23 +02:00
Zbigniew Jędrzejewski-Szmek
027cc9c92e basic/fs-util: remove logically dead code
We can jump to chase_one from two places. In the first 'todo' is set to
'buffer', which comes from path_make_absolute_cwd() and is nonnull In the
second 'todo' is set to 'joined' which is checked to be nonull a few lines
above the jump. So let's kill the code that deals with null todo there.

CID #1390941.
2018-05-10 01:57:37 +02:00
Zbigniew Jędrzejewski-Szmek
03d3a9d5be udevadm: fix null dererefence on allocation error
CID #1390936.
2018-05-10 01:49:01 +02:00
Zbigniew Jędrzejewski-Szmek
6a6e9c039f localed: fix memleak in error path
CID #1390929.
2018-05-10 01:45:20 +02:00
Zbigniew Jędrzejewski-Szmek
36591e1080 logind: fix borked r check
CID #1390947, #1390952.
2018-05-10 01:37:49 +02:00
Zbigniew Jędrzejewski-Szmek
f20f4a775e basic/format-table: add missing va_end()
CID #1390930, #1390940.
2018-05-10 01:36:50 +02:00
Zbigniew Jędrzejewski-Szmek
f201daec89 Introduce _cleanup_(strbuf_cleanupp) and use it to fix null deref on error
catalog_update() would call strbuf_cleanup(NULL) on allocation error.
CID #1390928.
2018-05-10 01:36:50 +02:00
Zbigniew Jędrzejewski-Szmek
db983479af shared/sleep-config: fix memleak of strv, add test
CID #1390921, #1390951.
2018-05-10 01:36:50 +02:00
Zbigniew Jędrzejewski-Szmek
f5ce2e764f
Merge pull request #8689 from davide125/static
meson: add support for building static libsystemd and libudev
2018-05-10 00:39:36 +02:00
Igor Gnatenko
64cd0029fd
Merge pull request #8939 from yuwata/fix-comment
several cleanups
2018-05-09 20:55:26 +02:00
Yu Watanabe
2c3def6214 timedate: use free_and_strdup() 2018-05-10 00:59:47 +09:00
Yu Watanabe
130d3d22e9 tree-wide: use strv_free_and_replace() macro 2018-05-10 00:57:34 +09:00
Yu Watanabe
947f9f01a1 time-util: fix indentation for comments 2018-05-09 22:50:07 +09:00
Zbigniew Jędrzejewski-Szmek
32e2e0ade9
Merge pull request #8923 from yuwata/resolvectl-drop-funcs
resolvectl: drop service_family_{from,to}_string()
2018-05-09 14:12:33 +02:00
Yu Watanabe
0f5bc6effd
Merge pull request #8938 from keszybz/sd-bus-automatic-cleanup
Use automatic cleanup more in sd-bus
2018-05-09 17:54:30 +09:00