1
1
mirror of https://github.com/systemd/systemd-stable.git synced 2025-03-13 12:58:20 +03:00

41608 Commits

Author SHA1 Message Date
Balint Reczey
ef677436aa test: Pass personality test even when i686 userland runs on x86_64 kernel
(cherry picked from commit bd89d03544d2b8ea53af7af0a97d4d121ef048c4)
v243.3
2019-10-10 14:56:01 +02:00
Zbigniew Jędrzejewski-Szmek
3f6398c450 docs: fix inadvertent change in uid range
a305eda35f (r35378755)
(cherry picked from commit 581004bd336567d936e94e616d35679da8ce32a0)
2019-10-10 14:54:54 +02:00
Mike Kazantsev
25bb377a73 cgroup: fix typo in BPF firewall support warning message
(cherry picked from commit fc103b3e342429637527d3042bf7bdf15c12624d)
2019-10-10 14:53:23 +02:00
Norbert Lange
6d97aca0d5 fix build with compilers with default stack-protector enabled
building systemd fails with a compiler that supports
-fstack-protector but does not enable it by default.
(will miss several __stack_chk_* symbols).

fix this by also adding the switch during linking.

Signed-off-by: Norbert Lange <nolange79@gmail.com>
(cherry picked from commit 68e70ac2b27dcb5007fc4009553472f0b9700e66)
2019-10-10 14:52:49 +02:00
Nicolas Douma
fbad077cec nspawn: surrender controlling terminal to PID2 when using the PID1 stub
(cherry picked from commit de1b29f375b13b0566814517bf81e3cdbdd9a610)
2019-10-10 14:52:42 +02:00
Franck Bui
0553c3c668 pid1: fix DefaultTasksMax initialization
Otherwise DefaultTasksMax is always set to "inifinity".

This was broken by fb39af4ce42.

(cherry picked from commit c0000de87d2c7934cb1f4ba66a533a85277600ff)
2019-10-10 14:51:25 +02:00
Dan Streetman
f406a691a7 src/core/automount: use DirectoryMode when calling mkdir -p
mkdir -p is called both when setting up the autofs mount, as well
as after being notified that the real mount unit should be called.
However the first mkdir -p is hardcoded with 0555, while the second
uses the value specified to DirectoryMode in the automount unit; the
second mkdir -p is only needed when called from coldplug, so under
normal operation the dirs are incorrectly created with mode 0555.

This replaces the hardcoded 0555 mode with the value of DirectoryMode.

Closes #13683.

(cherry picked from commit 8084dcb9d759e93669127f200bf5ca755432b96e)
2019-10-10 14:51:14 +02:00
Yu Watanabe
20438f96c3 udevadm trigger: do not propagate EACCES and ENODEV
Inside container, writing file returns EACCESS. Moreover, some devices
return ENODEV rather than EACCES. So, let's also ignore these two
error causes.

Closes #13652.

(cherry picked from commit 67acde4869a9505f9721e31fa5167c82445e0e12)
2019-10-10 14:51:01 +02:00
Jonas Thelemann
6480630bc3 hwdb: Correct WWWW Pattern In Documentation Comment
(cherry picked from commit 56783ddf228c406522af5e53910d095fa2572540)
2019-10-10 14:50:15 +02:00
Zbigniew Jędrzejewski-Szmek
9d8e889810 nspawn: consistenly fail if parsing the environment fails
We would parse the environment twice (to re-apply settings after reading
config from disk), but we would not check the return code first time.
This means that for some settings we would ignore invalid values, while
for others, we'd fail at some point.

Let's just consistently fail. Those environment variables define important
aspects of behaviour, and it is better for the user if we ignore invalid
values. (Unknown settings are still ignored, so forward compatibility is
maintained.)

(cherry picked from commit 490486842b6521104b594c511ca912504f61a8f3)
2019-10-10 14:49:52 +02:00
Zbigniew Jędrzejewski-Szmek
40e169b304 nspawn: default to unified hierarchy if --as-pid2 is used
See comment added in the patch.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1756143.

(cherry picked from commit 75b0d8b89d6e86319e75eaead3f4b0d187a66729)
2019-10-10 14:48:39 +02:00
Chris Down
b5df1037a0 cgroup: Mark memory protections as explicitly set in transient units
A later version of the DefaultMemory{Low,Min} patch changed these to
require explicitly setting memory_foo_set, but we only set that in
load-fragment, not dbus-cgroup.

Without these, we may fall back to either DefaultMemoryFoo or
CGROUP_LIMIT_MIN when we really shouldn't.

(cherry picked from commit 184e989d7da4648bd36511ffa28a9f2b469589d1)
2019-10-10 14:48:00 +02:00
Chris Down
f14e3e02cc cgroup: Respect DefaultMemoryMin when setting memory.min
This is an oversight from https://github.com/systemd/systemd/pull/12332.

Sadly the tests didn't catch it since it requires a real cgroup
hierarchy to see, and it wasn't seen in prod since we're only currently
using DefaultMemoryLow, not DefaultMemoryMin. :-(

(cherry picked from commit 64fe532e90b3e99bf7821ded8a1107c239099e40)
2019-10-10 14:47:40 +02:00
Chris Down
ea248e53bf cgroup: Check ancestor memory min for unified memory config
Otherwise we might not enable it when we should, ie. DefaultMemoryMin is
set in a parent, but not MemoryMin in the current unit.

(cherry picked from commit 7c9d2b79935d413389a603918a711df75acd3f48)
2019-10-10 14:47:31 +02:00
Chris Down
de1d25a506 cgroup: docs: memory.high doc fixups
The docs just tautologically call this the "high limit". Just call it
throttling as we do in cgroup-v2.rst.

(cherry picked from commit ba79e19cb299623c9c0dd4c6a1ae80f795409b04)
2019-10-10 14:47:19 +02:00
Chris Down
2ab45f38d8 cgroup: docs: Mention unbounded protection for memory.{low,min}
I got asked why Memory{Low,Min} don't allow "infinity". They do, but the
docs don't say that like they already do for Memory{High,Max}.

(cherry picked from commit b62087d4d06777ccde9eb9e7a97abc7b8945d5f5)
2019-10-10 14:47:14 +02:00
Kenneth D'souza
19a43dc38a Consider smb3 as remote filesystem
Currently systemd will treat smb3 as local filesystem and cause
can't boot failures. Add smb3 to the list of remote filesystems
to fix this issue.

Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
(cherry picked from commit ff7d6a740b0c6fa3be63d3908a0858730a0837c5)
2019-10-10 14:47:06 +02:00
Michael Olbrich
5c0224c7bf Handle d_type == DT_UNKNOWN correctly
As documented in the man-page, readdir() may return a directory entry with
d_type == DT_UNKNOWN. This must be handled for regular filesystems.

dirent_ensure_type() is available to set d_type if necessary. Use it in
some more places.

Without this systemd will fail to boot correctly with nfsroot and some
other filesystems.

Closes #13609

(cherry picked from commit 28e68bb23547cbc11cd3f62a1a38dbe2b387b370)
2019-10-10 14:47:01 +02:00
Chris Down
8282bc61df util-lib: Don't propagate EACCES from find_binary PATH lookup to caller
On one of my test machines, test-path-util was failing because the
find_binary("xxxx-xxxx") was returning -EACCES instead of -ENOENT. This
happens because the PATH entry on that host contains a directory which
the user in question doesn't have access to. Typically applications
ignore permission errors when searching through PATH, for example in
bash:

    $ whoami
    cdown
    $ PATH=/root:/bin type sh
    sh is /bin/sh

This behaviour is present on zsh and other shells as well, though. This
patch brings our PATH search behaviour closer to other major Unix tools.

(cherry picked from commit 4e1ddb661272ddb2f03d6046369c973657dfdd62)
2019-10-10 14:46:39 +02:00
Yu Watanabe
9d0ae987a6 network: drop noisy log message
Closes #13595.

(cherry picked from commit 55a1729fd095f2e0733247e7b4911cf41bf6b2ed)
2019-10-10 14:46:03 +02:00
cbzxt
f67f0e4ec4 Updated log message when the timesync happens for the first time (#13624)
(cherry picked from commit 37afb0ac787783a1635165b8a4e3ba5fbd007dfd)
2019-10-10 14:45:10 +02:00
Zbigniew Jędrzejewski-Szmek
e151bf4674 units: make systemd-binfmt.service easier to work with no autofs
See https://bugzilla.redhat.com/show_bug.cgi?id=1731772:
when autofs4 is disabled in the kernel,
proc-sys-fs-binfmt_misc.automount is not started, so the binfmt_misc module is
never loaded. If we added a dependency on proc-sys-fs-binfmt_misc.mount
to systemd-binfmt.service, things would work even if autofs4 was disabled, but
we would unconditionally pull in the module and mount, which we don't want to do.
(Right now we ony load the module if some binfmt is configured.)
But let's make it easier to handle this case by doing two changes:
1. order systemd-binfmt.service after the .mount unit (so that the .service
   can count on the mount if both units are pulled in, even if .automount
   is skipped)
2. add [Install] section to the service unit. This way the user can do
   'systemctl enable proc-sys-fs-binfmt_misc.mount' to get the appropriate behaviour.

(cherry picked from commit 508133917d9628f8c0adc5db34d595196b72b1c8)
2019-10-10 14:44:56 +02:00
Steve Traylen
2b8e574d82 Corect man page reference in systemd-nologin.conf comments
The reference to the man page of `systemd-user-sessions.service`
in the comments of `tmpfiles.d/systemd-nologin.conf` is corrected.

(cherry picked from commit 7a72a95741970fa4919f137f6844fe11b951efd3)
2019-10-10 14:44:24 +02:00
Philip Withnall
a0577353f1 man: Add a missing space in machinectl(1)
Signed-off-by: Philip Withnall <withnall@endlessm.com>
(cherry picked from commit abdc57dfe149bfba79af094fd623eb9929eff5e3)
2019-10-10 14:44:15 +02:00
Filipe Brandenburger
693e983988 log: Add missing "%" in "%m" log format strings
These were clearly intended to be "%m" to display the human readable version
of the error stored in errno.

(cherry picked from commit 28b77ab246b88d05076080bbd69ca3c353fa0f27)
2019-10-10 14:44:09 +02:00
Zbigniew Jędrzejewski-Szmek
ea7151b8c4 pid1: do not warn if /run/systemd/relabel-extra.d/ doesn't exist
After all, that is the expected state.

(cherry picked from commit 90b059b608d6c53c8efb23b8791190dffadd1a17)
2019-10-10 14:42:18 +02:00
Michael Biebl
b90549290e man: fix typo
(cherry picked from commit decef551afaff9fb72f3cde499c9c1bcd23e5874)
2019-10-10 14:39:14 +02:00
Yu Watanabe
fab6f010ac dhcp6: use unaligned_read_be32()
Closes #13591.

(cherry picked from commit 0eb5e6d3f08c6b3a41cfa7ac02bcc6302259ed4a)
v243.2
2019-09-21 23:07:00 +02:00
Yu Watanabe
f2d9af4322 dhcp6: add missing option length check
Closes #13578.

(cherry picked from commit 6ffe71d0e22326f8ea5775c188ae0e13573cd123)
2019-09-21 23:07:00 +02:00
Yu Watanabe
ccf797511e ndisc: make first solicit delayed randomly
Closes #13460.

(cherry picked from commit 9973e6c43abb9d3d73fcfee83c886dbd32e700ca)
2019-09-21 23:07:00 +02:00
Yu Watanabe
f2275b6e12 dhcp6: read OPTION_INFORMATION_REFRESH_TIME option
Fixes #13460.

(cherry picked from commit fcb51238e0523d64a698b8738a15bbc1aea9febe)
2019-09-21 23:07:00 +02:00
AsciiWolf
6dfbe58ee7 l10n: update Czech Translation
(cherry picked from commit 1697a28567628ba0c2cb69ab36a7c80e66c01aa0)
2019-09-21 23:07:00 +02:00
Georg Müller
d4cd0e9d32 sd-radv: if lifetime < SD_RADV_DEFAULT_MAX_TIMEOUT_USEC, adjust timeout (#13491)
The RFC states that lifetime (AdvDefaultLifetime) must be at least
MaxRtrAdvInterval (which more or less corresponds to SD_RADV_DEFAULT_MAX_TIMEOUT_USEC
in systemd).

To fulfill this limit, virtually lower MaxRtrAdvInterval and MinRtrAdvInterval
accordingly.

Also check that min is not lower than 3s and max is not lower than 4s.

(cherry picked from commit ef90b6a4fb9509f61b9b917bbe4db7343afe1853)
2019-09-21 23:07:00 +02:00
AsciiWolf
dbefe59259 polkit: fix typo
(cherry picked from commit 984b96aa7a793f74747b0349f0ed68e992ae17b2)
2019-09-21 23:06:59 +02:00
Yu Watanabe
a321507476 sd-netlink: fix invalid assertion
It is natural that n_attiributes is less than type. But in that case,
the message does not contain any message about the type. So, we should
not abort execution with assertion, but just return -ENODATA.

(cherry picked from commit 48fb0d1301c78112360df943f2b6ebeb545b8510)
2019-09-21 23:06:58 +02:00
Yu Watanabe
45dca7fe86 network: do not enter failed state if device's sysfs entry does not exist yet
(cherry picked from commit 4d59e14f321d50cbdec1a2ef702e2d258e377356)
2019-09-21 23:06:58 +02:00
Yu Watanabe
dd83d58796 network: add missing link->network checks
When the function is called, no network file may be assigned to the
link.

(cherry picked from commit b1b0b42e48303134731e017a108c6c334ef5f4c8)
2019-09-21 23:06:58 +02:00
Michal Sekletar
b294305888 path: stop watching path specs once we triggered the target unit
We start watching them again once we get a notification that triggered
unit entered inactive or failed state.

Fixes: #10503
(cherry picked from commit 8fca6944c2ee20c63d62154c8badddc77170b176)
2019-09-21 23:06:58 +02:00
matthiasroos
2cd636c437 hwdb: add Medion Akoya E2292 (#13498)
Fixes #13480.

(cherry picked from commit 358e50fa7fab98509f2ef96cd8d6d7d1af6ed59a)
2019-09-21 23:06:56 +02:00
Rafael Fontenelle
d133bdd1fa po: update Brazilian Portuguese translation
(cherry picked from commit bf55a2df4da0234932c0949801579a9a9dca72bc)
2019-09-21 23:06:56 +02:00
Piotr Drąg
530e09b594 po: update Polish translation
(cherry picked from commit 9870c55ef5df8f079cd972b409ec59414869a256)
2019-09-21 23:06:55 +02:00
Zbigniew Jędrzejewski-Szmek
0c5c3e34c1 polkit: change "revert settings" to "reset settings"
"reset" is more understandable. The verb is "revert", but it might actually be
better to have a description which uses different words instead of duplicating
the name of the command.

379158684a (commitcomment-34992552)
(cherry picked from commit ea2552639b22004c89df26f2374e3d3f1d2acace)
2019-09-21 23:06:53 +02:00
Zbigniew Jędrzejewski-Szmek
73e0f372d8 man: fix description of ARPIntervalSec= units
https://bugzilla.redhat.com/show_bug.cgi?id=1751363
(cherry picked from commit 06c52cc2b7c6cf2729e130f2a23c5a7ce62e27b9)
2019-09-21 23:06:52 +02:00
baybal
5412cc54a1 hwdb: axis override for Dell 9360 touchpad
and possibly other XPS models sharing the touchpad (#13472)

(cherry picked from commit 26fe3af8ae7d52847eb3f2267eaa3df3af90d811)
2019-09-21 23:06:52 +02:00
Frantisek Sumsal
9d4e658529 test: drop the missed || exit 1 expression
...as we've already done in the rest of the testsuite, see
cc469c3dfc398210f38f819d367e68646c71d8da

(cherry picked from commit 67c434b03f8a24f5350f017dfb4b2464406046db)
2019-09-21 23:06:49 +02:00
Yu Watanabe
7ed7ea82f6 udevadm: use usec_add()
Also fixes description of event source.

(cherry picked from commit f6e8ba816577a1a26037a8aeae23fda36d74f0ac)
2019-09-21 23:03:43 +02:00
Yu Watanabe
477bf86c91 udevadm: missing initialization of descriptor
(cherry picked from commit 2f5b282aab78bd2378df428c57c5fd1cc09e9f4f)
2019-09-21 23:03:35 +02:00
Zbigniew Jędrzejewski-Szmek
19ac31c989 networkd: unbreak routing_policy_rule_compare_func()
!r is the same r == 0, so this was short-circuiting the comparison when
streq(a->iff, b->iff) or streq(a->off, b->off). Before the parent commit which
moved those comparisons to the end, this was short-circuiting quite a bit
of the comparison function.

(cherry picked from commit 314ed4f9948bb73300862935546a63294bba1d5c)
2019-09-21 23:03:19 +02:00
ypf791
a20a2157a8 core: coldplug possible nop_job
(cherry picked from commit b49e14d5f3081dfcd363d8199a14c0924ae9152f)
2019-09-21 23:01:49 +02:00
Franck Bui
eb55241742 tty-ask-pwd-agent: fix message forwarded to wall(1)
Commit a1c111c2d12429d2 wrongly replaced '!' with ':' when the message is
forwarded to wall(1).

Indeed in this case we are not requesting the user for providing a password but
instead we are simply displaying a message to suggest starting
tty-ask-password-agent for providing the password.

(cherry picked from commit 65943cc3507bf54390d598e06df60771e913fb72)
2019-09-21 23:01:36 +02:00