shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-01-05 13:18:06 +03:00
Code
a67a206379
systemd/coccinelle/flags-set.cocci

25 lines
630 B
Plaintext
Raw Normal View History

licensing: add spdx to our .cocci files Since those are chunks of code based on our codebase, it's easiest to use the same license.
2021-10-01 13:28:36 +03:00
/* SPDX-License-Identifier: LGPL-2.1-or-later */
Add macro for checking if some flags are set This way we don't need to repeat the argument twice. I didn't replace all instances. I think it's better to leave out: - asserts - comparisons like x & y == x, which are mathematically equivalent, but here we aren't checking if flags are set, but if the argument fits in the flags.
2018-04-20 16:36:20 +03:00
@@
coccinelle: disable flags-set where it doesn't make sense
2020-10-02 12:31:47 +03:00
/* Disable this transformation in cases where it doesn't make sense or
* where it makes the resulting expression more confusing
*/
position p : script:python() {
not (p[0].file == "src/shared/securebits-util.h" or
p[0].file == "src/core/manager.h" or
p[0].current_element == "log_set_max_level_realm" or
p[0].current_element == "unichar_is_valid")
};
coccinelle: filter out a couple of 'false-positive' transformations * flag-set.cocci: perform the transformation only if the second argument is a constant * sd-journal/lookup3.c: skip the cocci completely for this file, since it's not "ours" * strjoina.cocci: skip the transformation on the "test_strjoina" test, since it intentionally tests the "incorrect" expression we're trying to transform (the same thing was already done in strjoin.cocci)
2021-03-18 13:59:53 +03:00
expression x;
constant y;
Add macro for checking if some flags are set This way we don't need to repeat the argument twice. I didn't replace all instances. I think it's better to leave out: - asserts - comparisons like x & y == x, which are mathematically equivalent, but here we aren't checking if flags are set, but if the argument fits in the flags.
2018-04-20 16:36:20 +03:00
@@
coccinelle: further restrict certain transformations Some transformations generate results we don't want to keep, so let's disable such transformations for specific files. Also, disable const-strlen.cocci everywhere, as the STRLEN macro has a pretty limited scope, so the transformation generates false positives in most cases.
2019-04-29 17:12:41 +03:00
(
- ((x@p) & (y)) == (y)
Add macro for checking if some flags are set This way we don't need to repeat the argument twice. I didn't replace all instances. I think it's better to leave out: - asserts - comparisons like x & y == x, which are mathematically equivalent, but here we aren't checking if flags are set, but if the argument fits in the flags.
2018-04-20 16:36:20 +03:00
+ FLAGS_SET(x, y)
coccinelle: further restrict certain transformations Some transformations generate results we don't want to keep, so let's disable such transformations for specific files. Also, disable const-strlen.cocci everywhere, as the STRLEN macro has a pretty limited scope, so the transformation generates false positives in most cases.
2019-04-29 17:12:41 +03:00
|
- (x@p & (y)) == (y)
Add macro for checking if some flags are set This way we don't need to repeat the argument twice. I didn't replace all instances. I think it's better to leave out: - asserts - comparisons like x & y == x, which are mathematically equivalent, but here we aren't checking if flags are set, but if the argument fits in the flags.
2018-04-20 16:36:20 +03:00
+ FLAGS_SET(x, y)
coccinelle: further restrict certain transformations Some transformations generate results we don't want to keep, so let's disable such transformations for specific files. Also, disable const-strlen.cocci everywhere, as the STRLEN macro has a pretty limited scope, so the transformation generates false positives in most cases.
2019-04-29 17:12:41 +03:00
|
- ((x@p) & y) == y
Add macro for checking if some flags are set This way we don't need to repeat the argument twice. I didn't replace all instances. I think it's better to leave out: - asserts - comparisons like x & y == x, which are mathematically equivalent, but here we aren't checking if flags are set, but if the argument fits in the flags.
2018-04-20 16:36:20 +03:00
+ FLAGS_SET(x, y)
coccinelle: further restrict certain transformations Some transformations generate results we don't want to keep, so let's disable such transformations for specific files. Also, disable const-strlen.cocci everywhere, as the STRLEN macro has a pretty limited scope, so the transformation generates false positives in most cases.
2019-04-29 17:12:41 +03:00
)
Copy Permalink