shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2024-11-07 18:27:04 +03:00
Code

timesyncd: consider too long packets as invalid

Browse Source 
If the received NTP message from server didn't fit to our buffer, either
it is doing something nasty or we don't know the protocol. Consider the
packet as invalid.

(David: add parantheses around conditional)
This commit is contained in:
Topi Miettinen 2015-01-18 16:01:25 +02:00 committed by David Herrmann
parent 50efadb0ae
commit 43fcd650e5
Notes: Lennart Poettering 2015-02-12 17:18:22 +01:00 
Backport: bugfix
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/timesync/timesyncd-manager.c
View File

@ -525,7 +525,8 @@ static int manager_receive_response(sd_event_source *source, int fd, uint32_t re
return manager_connect(m);
}
if (iov.iov_len < sizeof(struct ntp_msg)) {
/* Too short or too long packet? */
if (iov.iov_len < sizeof(struct ntp_msg) || (msghdr.msg_flags & MSG_TRUNC)) {
log_warning("Invalid response from server. Disconnecting.");
return manager_connect(m);
}