shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-01-10 05:18:17 +03:00
Code

lgtm: complain about accept() [people should use accept4() instead, due to O_CLOEXEC]

Browse Source
This commit is contained in:
Lennart Poettering 2019-04-10 19:36:40 +02:00
parent 86a3d44de5
commit e2d0fa6feb
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.lgtm/cpp-queries/PotentiallyDangerousFunction.ql
View File

@ -41,6 +41,9 @@ predicate potentiallyDangerousFunction(Function f, string message) {
) or ( ) or (
f.getQualifiedName() = "strerror" and f.getQualifiedName() = "strerror" and
message = "Call to strerror() is not thread-safe. Use strerror_r() or printf()'s %m format string instead." message = "Call to strerror() is not thread-safe. Use strerror_r() or printf()'s %m format string instead."
) or (
f.getQualifiedName() = "accept" and
message = "Call to accept() is not O_CLOEXEC-safe. Use accept4() instead."
) )
} }