1
0
mirror of https://github.com/systemd/systemd.git synced 2024-10-30 14:55:37 +03:00
Commit Graph

60587 Commits

Author SHA1 Message Date
Jan Janssen
0bc4ac526d macro: Use more correct type in IN_SET
This will now catch mistakes like this:
    struct s {
            int i:2;
    } s = { 1 };
    assert_se(IN_SET(s.i, ULLONG_MAX));

> warning: implicit conversion from 'unsigned long long' to
> 'typeof (+s.i)' (aka 'int') changes value from 18446744073709551615
> to -1 [-Wconstant-conversion]
2022-10-26 03:27:09 +09:00
Yu Watanabe
bcf04e9b27 tree-wide: fix typo 2022-10-26 03:24:45 +09:00
Yu Watanabe
d0f69be793
Merge pull request #25131 from poettering/image-root-help-text-fix
analyze/coredumpctl: add --image=/--root= to --help texts
2022-10-26 03:17:17 +09:00
xiaoyang
02c0d656b4
Revert "core: drop non-default value for DefaultLimitMEMLOCK=" (#25058)
This reverts commit 606104bcdb.
2022-10-26 01:49:07 +09:00
Yu Watanabe
9918dfb98b test: rewrite tests for renaming network interface
- use `udevadm wait` instead of `udevadm info --wait-initialized`,
- use `timeout` command instead of the fixed time sleep,
- add basic tests for #25106,
- add brief comment about #25115.
2022-10-26 01:47:18 +09:00
Jacek Migacz
c89d0c3b05 core: give a nicer error message on invalid aliases 2022-10-25 18:18:57 +02:00
Lennart Poettering
2d15dc86ca coredumpctl: add --root= + --image= to --help text 2022-10-25 17:47:52 +02:00
Lennart Poettering
9f5b68d6b7 analyze: add --image= + --root= to --help text 2022-10-25 17:47:52 +02:00
Lennart Poettering
0cdb1a2fa3 update TODO 2022-10-25 17:46:18 +02:00
Daan De Meyer
bb6a971cca man: Mention that journal file size is capped to 4G in compact mode 2022-10-25 21:23:01 +09:00
Zbigniew Jędrzejewski-Szmek
aa314c87c5 Report version string as in the Boot Loader Spec, fix boot loader upgrades
We generate a "version string" that is reported by various tools. This patch
changes this version string to use the characters specified for the version
string in the Boot Loader Specification. We start using the special characters
we have in the spec for this exact purpose and thus fix version comparisons.
We also stop using '+' which is not part of the allowed charset and is used for
boot attempt counting and should not be part of the version string.

The version string is (among other places) used in sd-boot and the comparison
result is used by 'bootctl update' to decide whether to install a new binary.
Before, because 'nn-rc1' compares higher than 'nn', we would refuse to upgrade
pre-release versions.

The boot loader is the primary motivation. I'm not aware of programatic version
comparisons in other places, but it makes sense to use the same versions string
everywhere.

(This patch effectively only matters for non-distro builds, because distro
builds presumably use -Dversion-tag to set something meaningful. Ideally, those
version strings are compatible with our version strings, but this is outside of
our control.)
2022-10-25 13:23:57 +02:00
Yu Watanabe
4117366a28 btrfs-util: move btrfs_defrag_fd() from fd-util.[ch]
After d71ece3f0b, the function is not used
in libbasic or libsystemd anymore. Let's move it to more appropriate
place.
2022-10-25 16:25:46 +09:00
Luca Boccassi
876d7e0b4f
Merge pull request #25118 from bluca/rc2
hwdb/news for rc3
2022-10-24 23:02:58 +02:00
Luca Boccassi
a5683afba8 Update autosuspend hwdb
ninja -C build update-hwdb-autosuspend
2022-10-24 20:26:22 +01:00
Luca Boccassi
3203190130 Update hwdb
ninja -C build update-hwdb
2022-10-24 20:25:58 +01:00
Luca Boccassi
fa9b3a5f81 NEWS: update contributors list 2022-10-24 20:14:12 +01:00
Yu Watanabe
8cf144c3f6
Merge pull request #25052 from yuwata/resolvconf-compat
resolvconf-compat: first try to use the specified interface name as is
2022-10-25 04:08:41 +09:00
Frantisek Sumsal
f5dfbdd014 udev: fix the errno check if a couple of places
Follow-up to 691a596da1.
2022-10-25 04:08:17 +09:00
Luca Boccassi
022684221e mkosi: libbpf0 -> libbpf1 2022-10-24 20:40:07 +02:00
Yu Watanabe
8207ec4b49
Merge pull request #25080 from keszybz/search-paths
Refusing linking files underneath our hierarchy, improve error messages
2022-10-25 01:57:41 +09:00
Yu Watanabe
72ca42c1b4 test: add tests for setting DNS servers by resolvectl or resolvconf 2022-10-25 01:52:16 +09:00
Luca BRUNO
88f8bd753a test-string-util: remove several strdupa() calls
This performs the same semantic transformation as the Coccinelle
script 'strdupa.cocci'.
Somehow the existing semantic patch is not properly triggering on
this 'string_replace_char' test.
2022-10-25 01:04:12 +09:00
Edson Juliano Drosdeck
a58b8d65ca
hwdb: fix key toggle and programmable button for Positivo K142 (#25111) 2022-10-25 01:03:52 +09:00
H A
d8e777e0a5 po: Translated using Weblate (Estonian)
Currently translated at 71.5% (138 of 193 strings)

Co-authored-by: H A <contact+fedora@hen.ee>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/et/
Translation: systemd/main
2022-10-25 00:27:39 +09:00
Lennart Poettering
3b1494ad70 homed: properly initialize all return params 2022-10-24 15:56:59 +02:00
Yu Watanabe
7d4e850323 resolvconf-compat: first parse provided interface name as is
Then, try to drop multiple protocol specifiers at the end.

Strictly speaking, this breaks backward compatibility:
if eth0 and eth0.42 exists, then previously,
    echo 'nameserver 192.168.0.1' | resolvconf -a eth0.42
adds the DNS server to eth0 instead of eth0.42, as we unconditionally
dropped the specifier after the last dot, and
    echo 'nameserver 192.168.0.1' | resolvconf -a eth0.42.dhcp
adds the DNS server to eth0.42. However, with this commit, now
the both commands add the DNS server to eth0.42. But, hopefully,
this should be preferable behavior.

Fixes #25032.
2022-10-24 20:34:10 +09:00
Zbigniew Jędrzejewski-Szmek
32d2e70ae4 man: fix count mismatch
We said "search path" and "search paths" in the same sentence…
2022-10-24 12:54:03 +02:00
Zbigniew Jędrzejewski-Szmek
a6f318a554 systemctl,manager: refuse linking unit files underneath the search paths
We treat symlinks to unit files outside of the search path differently from
symlinks to unit files *in* the search path. The former are "linked" unit
files, while the latter are enablement symlinks and such and will be removed
when disabling the unit.

The history of the check for in_search_path() is interesting: this condition
was added already in the first version of the code in
830964834f. Since the beginning, matching
arguments would simply be ignored. I think this is dubious. The man page says:

> Link a unit file that is *not* in the unit file search paths
> into the unit file search path

But for backwards-compat, let's continue to silently do nothing for files
*in* the search path.

The case of symlinks to unit files underneath the search path, but in some
subdirectory, is less clear. We didn't check for this case, so it was
implicitly allowed. But that's just an oversight, we don't want to allow people
to create additional subhierarchies under our hierarchy. Let's check for this
case and refuse.

Closes #24605.
2022-10-24 12:51:41 +02:00
Zbigniew Jędrzejewski-Szmek
f31f10a620 shared/install: check that install_changes_add() didn't fail on success
This adds a check for an allocation error for the calls to install_changes_add()
where we're plannig to return success from the call. In cases where we're
returning failure, it doesn't matter as much: the operation will fail anyway,
and if the allocation fails, we'll just get a less descriptive error message.
2022-10-24 12:38:28 +02:00
Zbigniew Jędrzejewski-Szmek
81de696273 shared/install: add forgotten calls to install_changes_add()
The machinery to report a good error message only works if the
error was registered with install_changes_add() and a file name. Otherwise
we only get a generic "Op failed: %m" message.

In some places -EINVAL is replaced by -EUCLEAN, so that we get the proper
error message.
2022-10-24 12:38:28 +02:00
Zbigniew Jędrzejewski-Szmek
94e7298d30 shared/install: make install_changes_add propagate passed-in errno value
The function was written to only return an error from internal allocation
failures, because when using it to create a bus message, we want to distinguish
a failed operation from an allocation error when sending the reply. But it
turns out that the only caller that makes this distinction checks that the
passed-in errno value ('type') is not negative beforehand. So we can make the
function pass 'type' value through, which makes most of the callers nicer.

No functional change.
2022-10-24 12:37:19 +02:00
Yu Watanabe
427eeb44f2 resolvectl: rely on invoked_as() 2022-10-24 18:55:53 +09:00
Yu Watanabe
a56dd1580d string-util: make free_and_strdup_warn() return 1 when new string is assigned 2022-10-24 18:55:11 +09:00
Yu Watanabe
5905bddce2 systemctl: fix potential memleak on failure in determine_default()
And make verb_set_default() return zero on success.
2022-10-24 18:55:11 +09:00
Frantisek Sumsal
4856f63846
Merge pull request #25100 from weblate/weblate-systemd-master
Translations update from Fedora Weblate
2022-10-22 19:01:06 +00:00
Jan Kuparinen
cbcd3b1b9c po: Translated using Weblate (Finnish)
Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: Jan Kuparinen <copper_fin@hotmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/fi/
Translation: systemd/main
2022-10-22 19:19:52 +02:00
Yuri Chornoivan
dad6735cdf po: Translated using Weblate (Ukrainian)
Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: Yuri Chornoivan <yurchor@ukr.net>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/uk/
Translation: systemd/main
2022-10-22 19:19:52 +02:00
Oğuz Ersen
f8270d8aad po: Translated using Weblate (Turkish)
Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: Oğuz Ersen <oguz@ersen.moe>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/tr/
Translation: systemd/main
2022-10-22 19:19:51 +02:00
김인수
60a325bbfe po: Translated using Weblate (Korean)
Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: 김인수 <simmon@nplob.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/ko/
Translation: systemd/main
2022-10-22 19:19:51 +02:00
Daniel Rusek
ddf99965fa po: Translated using Weblate (Czech)
Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: Daniel Rusek <mail@asciiwolf.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/cs/
Translation: systemd/main
2022-10-22 19:19:51 +02:00
Zbigniew Jędrzejewski-Szmek
96f8c63601 meson: always use libatomic if found
Semi-quoting https://github.com/systemd/systemd/issues/25057:

clang-16 has made the choice to turn on -Werror=implicit-function-declaration,implicit-int.
(See Gentoo's tracker bug https://bugs.gentoo.org/870412).
Added in commit 132c73b57a, systemd now does a
check to see if libatomic is needed with some compile/link tests with e.g.
__atomic_exchange_1, but the tests don't provide a prototype for
__atomic_exchange_1 so with clang-16 the test fails, breaking the build.

Let's simplify things by linking to libatomic unconditionally if it is found
and seems to work. If actually unneeded, it might be dropped via --as-needed.
This seems to work with gcc and clang.

declare_dependency() is used instead of cc.find_library(), because the latter
picks up a symlink in gcc private directory (e.g.
/usr/lib/gcc/x86_64-redhat-linux/12/libatomic.so), and we don't want that.

Fixes #25057.
2022-10-21 17:40:59 +02:00
Jonathan Kang
2051a98172 hwdb: Add support for Elgato Stream Deck XL (gen 2)
Add support for the following Elgato Stream Deck Device:

  ID 0fd9:008f Elgato Systems GmbH Stream Deck XL
2022-10-21 16:53:33 +02:00
Michael Biebl
8c5787d75e
Merge pull request #25083 from bluca/revert_timer
Revert "Fix issue with system time set back (#24131)"
2022-10-20 19:58:10 +02:00
Frantisek Sumsal
b1c547d161
Merge pull request #25084 from mrc0mmand/scorecard-tweaks
ci: run the Scorecards action in PRs only on config update
2022-10-20 16:45:22 +00:00
Lennart Poettering
efe7ab9652 update TODO 2022-10-20 18:28:55 +02:00
Luca Boccassi
edbaca9f9c
Merge pull request #25081 from keszybz/test-local-addresses-fail
Fix racy check in test-local-addresses
2022-10-20 17:47:14 +02:00
Frantisek Sumsal
b3ea9cf13b ci: run the Scorecards action in PRs only on config update
Also, unify the string quotation a bit and drop one unnecessary
expression syntax (as everything in `if` statements is automatically
evaluated as an expression).
2022-10-20 17:10:50 +02:00
Frantisek Sumsal
3e35a3302c ci: add a missing SPDX line 2022-10-20 17:03:37 +02:00
Luca Boccassi
701f7f6c8f
Merge pull request #25077 from keszybz/completions-optional-components
Fix completions when machinectl is not installed and other fixes
2022-10-20 15:57:46 +02:00
Luca Boccassi
0bf1d0ff04 Revert "Fix issue with system time set back (#24131)"
This fix unfortunately introduced a much worse regression that
is affecting many users, so let's revert it for now and rework
it in the next release.

This reverts commit 5ded3917a1.

Fixes https://github.com/systemd/systemd/issues/24984
2022-10-20 14:01:09 +01:00