1
0
mirror of https://github.com/systemd/systemd.git synced 2024-11-15 07:24:00 +03:00
Commit Graph

13343 Commits

Author SHA1 Message Date
Lennart Poettering
10e4e52be8 update TODO 2013-12-16 17:05:42 +01:00
Lennart Poettering
92d75ca419 util: try harder to increase the send/recv buffers of sockets
If we have the priviliges we will try SO_SNDBUFFORCE/SO_RCVBUFFORCE and
only fall back to SO_SNDBUF/SO_RCVBUF if that fails.
2013-12-16 17:04:36 +01:00
Zbigniew Jędrzejewski-Szmek
4b8268f843 catalog: fix language detection
Detection would fail if language was not specified in the filename
but a dot appeared somewhere higher in the path.
2013-12-15 23:36:36 -05:00
Lennart Poettering
2cfbd749af core: refuse doing %h, %s, %U specifier resolving in PID 1
These specifiers require NSS lookups to work, and we really shouldn't do
them from PID 1 hence. With this change they are now only supported for
user systemd instance, or when the configured user for a unit is root.
2013-12-16 04:59:31 +01:00
Lennart Poettering
213298fb82 build-sys: warn if builds are not byte-by-byte reproducible due to usage of __DATE__ and suchlike 2013-12-16 04:58:20 +01:00
Colin Walters
8e050193e1 Fix segv introduced by 2fd069b18e
n->path is pointing to the value now, we set s = NULL above.
2013-12-15 20:23:23 -05:00
Lennart Poettering
16f4efb415 build-sys: add cppcheck target
This uses --enable=all mode. Should be taken with a grain of salt
though. While many recommendations make sense we should probably keep
"int r" always on function scope, and many of the portability warnings
really don't matter to us because we only care for Linux/glibc.
2013-12-16 00:06:07 +01:00
Zbigniew Jędrzejewski-Szmek
b5dd814873 Fix a few signed/unsigned format string issues
Since numbers involved are all small, behaviour was correct already.

https://bugzilla.redhat.com/show_bug.cgi?id=1043304
2013-12-15 17:49:28 -05:00
Zbigniew Jędrzejewski-Szmek
2fd069b18e Fix a few resource leaks in error paths
https://bugzilla.redhat.com/show_bug.cgi?id=1043304
2013-12-15 17:49:28 -05:00
Lennart Poettering
9bfa2c029d bus: _printf_ attributes should be on prototypes not function definitions for non-static functions 2013-12-15 23:43:47 +01:00
Kay Sievers
b6c631f378 bus: update kdbus monitoring interface 2013-12-15 16:56:28 +01:00
Zbigniew Jędrzejewski-Szmek
d9de321f78 udev-builtin-path: fix printf specifiers 2013-12-14 23:10:03 -05:00
Zbigniew Jędrzejewski-Szmek
5958d08962 bus: return negative errno on error
https://bugs.freedesktop.org/show_bug.cgi?id=72688
2013-12-14 22:45:14 -05:00
Thomas Hindoe Paaboel Andersen
899839b9f8 test-journal-syslog: use streq_ptr since we pass in NULL 2013-12-15 02:31:01 +01:00
Djalal Harouni
815ebc540d systemctl: add the --plain option to the help message 2013-12-14 18:13:24 -05:00
Zbigniew Jędrzejewski-Szmek
6baf995c17 man: remove advice to avoid setting the same var more than once
So far the compatibility with .desktop settings hasn't been imporant
at all, and we do not want people to write convoluted unit
files.
2013-12-14 17:33:10 -05:00
Zbigniew Jędrzejewski-Szmek
ec6039bc08 man: beef up ExecStart description
We have lots of questions from people who assume that shell syntax works
here, so let's be very explicit what is allowed and what is not. A few
examples should also help.

http://bugs.debian.org/732156
2013-12-14 17:33:10 -05:00
Shawn Landden
5d5f8ffa07 build: use -ftrapv for development
We want to find these bugs if they exist.
2013-12-14 17:33:10 -05:00
Thomas Hindoe Paaboel Andersen
9091e686f4 Add more _printf_'s for format-nonliterals
Clang is a bit more strict wrt format-nonliterals:
http://clang.llvm.org/docs/LanguageExtensions.html#format-string-checking

Adding these extra printf attributes also makes gcc able to find more
problems. E.g. this patch uncovers a format issue in udev-builtin-path_id.c

Some parts looked intetional about breaking the format-nonliteral check.
I added some supression for warnings there.
2013-12-14 13:32:22 +01:00
Lennart Poettering
8d35dae708 event: some snake-oil to speed up impossible error checks 2013-12-14 05:10:25 +01:00
Lennart Poettering
9a800b5622 event: instead of reset the revents field when we get new revents data from epoll, OR it in 2013-12-14 05:10:25 +01:00
Lennart Poettering
15b38f936e event: dynamically adjust size of events array instead of pre-allocating it possibly too large or too small 2013-12-14 05:10:25 +01:00
Lennart Poettering
e04b0cdb90 util: port last code over to new namespace utility calls 2013-12-14 05:10:25 +01:00
Lennart Poettering
5e2b3214aa util: when joining a namespace make sure to reset all uids to 0 after
the transition
2013-12-14 05:10:25 +01:00
Lennart Poettering
bc9fd78c7b bus: when connecting to a container's kdbus instance, enter namespace first
Previously we'd open the connection in the originating namespace, which
meant most peers of the bus would not be able to make sense of the
PID/UID/... identity of us since we didn't exist in the namespace they
run in. However they require this identity for privilege decisions,
hence disallowing access to anything from the host.

Instead, when connecting to a container, create a temporary subprocess,
make it join the container's namespace and then connect from there to
the kdbus instance. This is similar to how we do it for socket
conections already.

THis also unifies the namespacing code used by machinectl and the bus
APIs.
2013-12-14 05:10:25 +01:00
Thomas Hindoe Paaboel Andersen
3fa5dd6de7 getty-generator: fix stripping /dev/ 2013-12-13 23:24:16 +01:00
Lennart Poettering
7c9a6f9063 bus: install systemd-bus-proxyd unit files for compatibility with dbus1 2013-12-13 20:49:57 +01:00
Lennart Poettering
207d1d0922 getty-generator: fix segfault when $container_ttys is not set 2013-12-13 20:40:31 +01:00
Lennart Poettering
9d3e3aa58d event: make gcc shut up 2013-12-13 17:39:52 +01:00
Lennart Poettering
49cf4ece20 journal: downgrade comments about sd_journal_print_with_location()
Effectviely these calls are ABI anyway, so downgrade the comments a bit,
since it might actually be useful for language bindings to make use of
them.
2013-12-13 17:33:20 +01:00
Lennart Poettering
58f299eef6 update TODO 2013-12-13 17:16:06 +01:00
Lennart Poettering
ffaf95cc18 man: document that systemd-getty-generator can start additional container gettys on ptys 2013-12-13 17:15:05 +01:00
Lennart Poettering
1d97ff7dd7 getty-generator: look add an environment variable $container_ttys set for PID 1 and start gettys on all ttys listed therein 2013-12-13 16:57:24 +01:00
Lennart Poettering
f4889f656b nspawn: add new --setenv= switch to set an environment variable for the container to spawn 2013-12-13 16:37:16 +01:00
Lennart Poettering
a56b63f41d man: document more error codes for sd_bus_request_name() 2013-12-13 16:01:54 +01:00
Lukasz Skalski
043ccd8383 libsystemd-bus: the same error codes for sd_bus_release_name() (for kdbus and dbus1)
Due to this patch, sd_bus_release_name() function
returns the same code errors for kdbus and dbus1
if we try release non-existing name or foreign
name.
2013-12-13 15:50:41 +01:00
Lukasz Skalski
c97a6dbcf1 build-sys: fix help text for --enable-kdbus 2013-12-13 15:50:38 +01:00
Lennart Poettering
9f97c93671 update TODO 2013-12-13 15:30:12 +01:00
Lennart Poettering
6d6f4904aa bus: when a connection terminated use ECONNRESET as error 2013-12-13 15:30:12 +01:00
Lennart Poettering
1e05d493b7 bus: rework how we attach fds to event loops
When trying a couple of addresses one after the other, make sure to
reattach the fds to the event loop.
2013-12-13 15:30:12 +01:00
Lennart Poettering
30caf8f3af event: add ability to change fd of an active event source 2013-12-13 15:30:12 +01:00
Lennart Poettering
8f726607ec event: allow to query userdata and watchdog state 2013-12-13 15:30:12 +01:00
Zbigniew Jędrzejewski-Szmek
f9f4dd51bd man: add another nspawn example
Taken from https://bugs.freedesktop.org/show_bug.cgi?id=68369.
2013-12-12 23:19:45 -05:00
Lennart Poettering
12179984a3 event: when unreffing an event source from its own handler, detach fd from epoll
The pattern of unreffing an IO event source and then closing its fd is
frequently seen in even source callbacks. Previously this likely
resultet in us removing the fd from the epoll after it was closed which
is problematic, since while we were dispatching we always kept an extra
reference to event source objects because we might still need it later.
2013-12-13 04:06:43 +01:00
Lennart Poettering
7b77ed8cf3 event: be more conservative when returning errors from event handler callbacks
We really should return errors from event handlers if we have a
continous problem and don't know any other solution.
2013-12-13 04:06:43 +01:00
Lennart Poettering
c5ef10429a git: update .gitignore 2013-12-13 04:06:43 +01:00
Lennart Poettering
6b46ea73e3 namespace: include boot id in private tmp directories
This way it is easy to only exclude directories from the current boot
from automatic clean up in /var/tmp.

Also, pick a longer name for the directories so that are globs in
tmp.conf can be simpler yet equally accurate.
2013-12-13 04:06:43 +01:00
Lennart Poettering
6203e07a83 event: rework sd-event exit logic
With this change a failing event source handler will not cause the
entire event loop to fail. Instead, we just disable the specific event
source, log a message at debug level and go on.

This also introduces a new concept of "exit code" which can be stored in
the event loop and is returned by sd_event_loop(). We also rename "quit"
to "exit" everywhere else.

Altogether this should make things more robus and keep errors local
while still providing a way to return event loop errors in a clear way.
2013-12-13 04:06:43 +01:00
Lennart Poettering
6e41a3e53d bus: fix make check 2013-12-13 04:06:43 +01:00
Lennart Poettering
33cb6e7934 bus: properly parse NameOwnerChanged messages when caller explicitly wants to match against names coming/going 2013-12-13 04:06:43 +01:00