1
0
mirror of https://github.com/systemd/systemd.git synced 2024-11-02 02:21:44 +03:00
Commit Graph

9460 Commits

Author SHA1 Message Date
Michal Schmidt
1abc85b8d0 job: avoid recursion into transaction code from job cancelation
I hit an "assert(j->installed)" failure in transaction_apply(). Looking
into the backtrace I saw what happened:
1. The system was booting. var.mount/start was an installed job.
2. I pressed Ctrl+Alt+Del.
3. reboot.target was going to be isolated.
4. transaction_apply() proceeded to install a var.mount/stop job.
5. job_install() canceled the conflicting start job.
6. Depending jobs ended recursively with JOB_DEPENDENCY, among them was
   local-fs.target/start.
7. Its OnFailure action triggered - emergency.target was now going to be
   isolated.
8. We recursed back into transaction_apply() where the half-installed
   var.mount/stop job confused us.

Recursing from job installation back into the transaction code cannot be
a good idea. Avoid the problem by canceling the conflicting job
non-recursively in job_install(). I don't think we'll miss anything by
not recursing here. After all, we are called from transaction_apply().
We will not be installing just this one job, but all jobs from a
transaction. All requirement dependencies will be included in it and
will be installed separately. Every transaction job will get a chance
to cancel its own conflicting installed job.
2012-10-25 03:21:32 +02:00
Michal Schmidt
65eb544e12 job: add comments to JobResult values 2012-10-25 03:21:31 +02:00
Lennart Poettering
a73d88fa02 update TODO 2012-10-25 01:24:44 +02:00
Lennart Poettering
d99ae53a73 journal: properly serialize fields with multiple values into JSON
This now matches the JSON serialization spec from:

http://www.freedesktop.org/wiki/Software/systemd/json
2012-10-25 01:24:44 +02:00
Kay Sievers
cae356ad49 remove Fedora hostname, locale, vconsole legacy file support 2012-10-24 03:51:06 +02:00
Kay Sievers
1ada30ac51 man: udev - add 'udevadm hwdb --update' 2012-10-24 02:10:42 +02:00
Lennart Poettering
db87a36e74 journalctl: remove left-over log message 2012-10-24 01:06:31 +02:00
Lennart Poettering
a19554ed92 update TODO 2012-10-24 01:06:30 +02:00
Tom Gundersen
d0114527f4 units: don't order tmp.monut after local-fs-pre.target
Since tmp.mount is a tmpfs this is not necesary, and should speed up boot marginally.
2012-10-23 22:33:00 +02:00
Tom Gundersen
ef44ed4e2d man: fix typo in tmpfiles.d
Reported-by: Jason St. John <jstjohn@purdue.edu>
2012-10-23 22:15:05 +02:00
Tom Gundersen
a2558205f7 tmpfiles: allow Age to be set to 0
Mostly useful for testing purposes. Setting Age to 1s works just as
well, but it is surprising that using 0s (or just 0) does not work.

Also clarify this in the documentation.
2012-10-23 21:53:20 +02:00
Lennart Poettering
1cb88f2c61 update TODO 2012-10-23 17:13:20 +02:00
Mantas Mikulėnas
4278aa278c cgls: correctly ellipsize command lines for PIDs >= 1000000 2012-10-23 17:13:20 +02:00
Tony Camuso
ef421e4d55 rules: Remove HP iLO from USB HID PM rules
HP iLO fw versions below 1.50 incorrectly report that HP iLO virtual
Kbd/Mouse supports remote wakeup. With the rules change in commit
3bfc7a97b1, the HP iLO was listed for
power control.

In iLO fw versions less than 1.50, the iLO Kbd/Mouse become unresponsive
once they are suspended. HP iLO fw versions 1.50+ correctly report that
they don't support remote wakeup, which makes the rules moot in any case.
2012-10-23 16:57:03 +02:00
Kay Sievers
796b06c21b udev: add hardware database support 2012-10-23 16:43:32 +02:00
Zbigniew Jędrzejewski-Szmek
59bb9d9a14 build-sys: add check for microhttpd version 2012-10-23 15:35:34 +02:00
Zbigniew Jędrzejewski-Szmek
2eb8e90ff9 man: reword journalctl -n description 2012-10-23 11:21:48 +02:00
Michael Biebl
eac223e134 man: the corresponding LSB facility to rpcbind.target is $portmap 2012-10-23 02:34:02 +02:00
Lennart Poettering
4d92e078e9 update contributors list 2012-10-23 02:03:10 +02:00
Lennart Poettering
603cd8fe07 update TODO 2012-10-23 01:53:23 +02:00
Will Woods
bcbd5405b1 mount: make sure m->where is set before unit_add_exec_dependencies()
If you enter unit_add_exec_dependencies with m->where = NULL, you'll
very likely end up aborting somewhere under socket_needs_mount.

(When systemd goes to check to see if the journald socket requires your
mount, it'll do path_startswith(path, m->where)... *kaboom*)

This patch should ensure that:

    a) both branches in mount_add_one() set m->where, and
    b) mount_add_extras() calls unit_add_exec_dependencies() *after*
       setting m->where.
2012-10-23 01:53:02 +02:00
Lennart Poettering
5411ae4782 units: use numerig signal for killing systemd, to avoid incompatibilities with procps/util-linux kill 2012-10-23 00:12:33 +02:00
Lennart Poettering
4474d8abd0 units: also add journalctl suggestion to emergency.service
More often than not we enter emergency.service due to fsck failure, so
it makes sense to direct people to the journal to debug those.
2012-10-23 00:12:33 +02:00
Lennart Poettering
74dc2b17e6 units: suggest journalctl -b in rescue.service so that only messages from the current boot are shown 2012-10-23 00:12:33 +02:00
Lennart Poettering
2609659f0d systemctl: refer to systemctl -n, to not overwhelm the admin 2012-10-23 00:12:33 +02:00
Lennart Poettering
139ee8cc31 build-sys: prepare 195 2012-10-23 00:12:33 +02:00
Lennart Poettering
06bf461193 update TODO 2012-10-23 00:12:33 +02:00
Michal Schmidt
c4b996bd87 readahead: fix fd validity check
https://bugzilla.redhat.com/show_bug.cgi?id=868603
2012-10-22 22:08:06 +02:00
Kay Sievers
f1c0ece144 shared: strbuf - add descriprion 2012-10-22 18:21:12 +02:00
Kay Sievers
3c62146280 shared: move sparse-endian.h from journal 2012-10-22 18:08:48 +02:00
Kay Sievers
5b4882b6aa build-sys: fix distcheck 2012-10-22 17:20:18 +02:00
Kay Sievers
4693cfb3bf shared: strbuf - add description 2012-10-22 16:57:49 +02:00
Kay Sievers
915bf0f60f udev: use strbuf to store rules strings 2012-10-22 16:28:04 +02:00
Kay Sievers
955bd501c2 shared: strbuf - add string de-duplication facility 2012-10-22 16:27:00 +02:00
Kay Sievers
b87377fca3 update .gitignore 2012-10-22 14:33:35 +02:00
Kay Sievers
a9e12476ed util: add (x)bsearch_r(), the missing counterpart of qsort_r() 2012-10-22 14:31:46 +02:00
Dave Reisner
1d870ac769 bash-completion: update journalctl for recently added flags
Fixes a few minor bugs as well with flags which take arguments but for
which the values can never be known.
2012-10-21 16:47:15 -04:00
Dave Reisner
c1c02e07ed configure.ac: fix typo in fallback value for KILL 2012-10-21 08:33:33 -04:00
Lennart Poettering
fe29f9d25b hostnamectl: add more really basic system info to the status output 2012-10-21 03:35:54 +02:00
Lennart Poettering
7cd28a8a2f man: add man page for localectl 2012-10-21 03:35:54 +02:00
Lennart Poettering
e8c61d7b74 journal: use le64_t instead of uint64_t where this is appropriate 2012-10-21 03:35:54 +02:00
Dave Reisner
0dd1795907 bash-completion: avoid appending space after field competion
Resolves the TODO, and also uses compgen's -S flag to append the
trailing equals, rather than relying on an array-wide parameter
expansion.

Suggested-by: Ran Benita <ran234@gmail.com>
2012-10-20 18:38:28 -04:00
Dave Reisner
a632a03076 bash-completion: ensure iterators are locally scoped
Avoids leaking the 'i' variable to the user's shell session.
2012-10-20 17:54:08 -04:00
Dave Reisner
26be51de33 bash-completion: add completions for hostnamectl 2012-10-20 17:48:11 -04:00
Lennart Poettering
0962e09ec3 journal: link up documentation with the file structure header 2012-10-20 17:01:19 +02:00
Lennart Poettering
936d6fcb6c update TODO 2012-10-20 17:01:19 +02:00
Dave Reisner
44e2f7316c bash-completion: add completions for localectl 2012-10-20 08:27:52 -04:00
Dave Reisner
5c840a2dad bash-completion: add completions for timedatectl 2012-10-20 08:27:52 -04:00
Christian Hesse
20f59e42cd shared/install: fix typo in comment 2012-10-19 17:34:38 +02:00
Christian Hesse
df77cdf0fc systemctl: fix return code in chroot
If 'systemctl enable' (and friends) is run inside chroot it always
exits with a bad return code. unit_file_enable() returns the number of
symlink rules that were supposed to be created. So resetting r to 0 and
exiting gracefully should be the correct way.
2012-10-19 17:34:02 +02:00