1
0
mirror of https://github.com/systemd/systemd.git synced 2024-11-06 16:59:03 +03:00
Commit Graph

11027 Commits

Author SHA1 Message Date
David Herrmann
43ef760376 bus: simplify bus_message_read_strv_extend()
Avoid unbound for(;;) loop and use the established coding-style:
  while ((r = sd_bus_message_read*(...)) > 0) {
  }
  if (r < 0)
          return r;

This is much easier to read and used all over the code base.
2015-04-09 22:59:59 +02:00
David Herrmann
0704ea57b7 bus: use free_and_strdup()
Save some LOCs by replacing strdup()+error-handling+free+assign with
free_and_strdup().
2015-04-09 22:59:59 +02:00
David Herrmann
0a790ab540 terminal/idev: fix NULL terminator for bus-property mapping
We require a NULL entry as sentinal in bus_properties_map. Fix this!
2015-04-09 22:59:58 +02:00
Ronny Chevalier
3e348b8a6a test-journal-flush: fix memleak 2015-04-09 18:47:52 +02:00
Ronny Chevalier
cd977dca10 util: cunescape - fix memleak in error path 2015-04-09 18:47:52 +02:00
Lennart Poettering
019c7fba75 util: add shell_maybe_quote() call for preparing a string for shell cmdline inclusion
If necessary the passed string is enclosed in "", and all special
characters escapes.

This also ports over usage in bus-util.c and job.c to use this, instead
of a incorrect local implementation that forgets to properly escape.
2015-04-09 18:32:21 +02:00
Lennart Poettering
ab51b943d4 vconsole: some modernizations, indentation fixes 2015-04-09 13:13:07 +02:00
Lennart Poettering
71044f609b tmpfiles: properly return error code from path_set_acl() 2015-04-09 13:13:07 +02:00
Lennart Poettering
34f6453603 tmpfiles: add file attribute calls to list of glob needing commands 2015-04-09 13:13:07 +02:00
Lennart Poettering
aecb6fcb03 vconsole: stick to kernel-style function error handling
This undoes part of 8931278c8a.

We really should stick to kernel-style "int" return values from
functions, and not covnert success into boolean returns.
2015-04-09 13:13:07 +02:00
Thomas Hindoe Paaboel Andersen
8489a3b769 networkd: do not assign the variable twice 2015-04-09 00:05:58 +02:00
Lennart Poettering
88ec4dfa28 tmpfiles: rework file attribute code
- Stick to one type for the flags field: unsigned. This appears to be
  what the kernel uses, and there's no point in using something else.

- compress the flags array by avoiding sparse entries

- extend some error messages to not use abbreviated words

- avoid TTOCTTOU issues by invoking fstat() after open() when applying
  file flags

- add explanation why we need to check the file type with fstat().

- don't needlessly abbreviate "attribute" as "attrib", in particually as
  "chattr" abbreviates it as "attr" rather than "attrib".
2015-04-08 22:35:52 +02:00
Lennart Poettering
1ed8f8c16d util: merge change_attr_fd() and chattr_fd() 2015-04-08 20:47:35 +02:00
Lennart Poettering
171181bcd6 fstab-generator: don't continue on OOM 2015-04-08 20:27:11 +02:00
Lennart Poettering
481b3f9e99 timesyncd: print an INFO log message when we successfully reached a time server 2015-04-08 20:14:04 +02:00
Lennart Poettering
b90930c73b man: avoid confusion regarding "time synchronization state"
Also, update example in the timedatectl man page to match the actual
timedatectl output.
2015-04-08 18:34:08 +02:00
Jan Janssen
a4921cf4e2 systemctl: Use logind for --firmware-setup if possible 2015-04-08 18:22:16 +02:00
Zbigniew Jędrzejewski-Szmek
a40e26f392 Indentation 2015-04-08 11:28:45 -04:00
Zbigniew Jędrzejewski-Szmek
50b03c8ea1 core/automount: beef up error message
This should not happen... but when it does more information is nice.
2015-04-08 11:28:45 -04:00
Lennart Poettering
822db23cfa resolved: maintain order when writing resolv.conf entries
http://lists.freedesktop.org/archives/systemd-devel/2015-March/029850.html
2015-04-08 17:23:27 +02:00
Lennart Poettering
4a280a7e78 util: add minimal OrderedSet type
OrderedSet implements a Set-like structure, but maintains insertion
ordered. It is hence to Set what OrderedHashmap is for Hashmap.

Internally, this is only a wrapper around OrderedHashmap for now, but
this could one day be improved and be added to hashmap.c natively.
2015-04-08 17:22:15 +02:00
Alexander Sverdlin
b06ac35c79 missing.h: Define IFA_F_NOPREFIXROUTE
Fixes second systemd compilation problem against Linux 3.12 uapi
headers.

IFA_F_NOPREFIXROUTE is a usual #define appeared in Linux 3.14, so
AC_CHECK_DECLS is not necessary.
2015-04-08 12:59:40 +02:00
Lennart Poettering
de79f906ab sd-rtnl: properly size attribute array if IFA_FLAGS was missing 2015-04-08 12:56:57 +02:00
Ronny Chevalier
39505e3c3b remove duplicated includes 2015-04-08 02:42:50 +02:00
Ronny Chevalier
3906ab4adf timedatectl: trim --help output to 80 chars 2015-04-08 02:42:50 +02:00
Ronny Chevalier
07916bea07 test-socket-util: add test for in_addr_to_string 2015-04-08 02:42:50 +02:00
Thomas Hindoe Paaboel Andersen
2bb9e6203d device: remove unused null check
We dereference the variable right before the null check. We never reach
this point with a null value anyway so let's just remove it.
2015-04-07 21:11:38 +02:00
Lennart Poettering
889f25b2cc logind: drop "interactive" parameter from SetRebootToFirmwareSetup() bus call
Newer dbus versions have an "allow interactive authentication" bit in
the message header, hence it is not necessary to take a boolean for this
explicitly.
2015-04-07 21:09:18 +02:00
Lennart Poettering
34f7b9f98f missing.h: define IFA_FLAGS if it is missing 2015-04-07 21:09:18 +02:00
Thomas Hindoe Paaboel Andersen
5d84c44a97 test-util: don't mix declarations and code 2015-04-07 20:54:23 +02:00
Lennart Poettering
e5403f09aa socket: minor modernizations 2015-04-07 18:51:45 +02:00
Jan Janssen
5bdf22430e logind,systemctl: add reboot to EFI firmware support 2015-04-07 18:51:45 +02:00
Lennart Poettering
2fc4f5bd92 timedatectl: avoid specifically referring to NTP
systemd-timesyncd not only does NTP, but also manages clock monotonicity
using a flags file. In future, it might learn PTP support. Hence don't
expose its enablement state as "NTP" but use the more generic term
"network time synchronization". After all, for similar reasons
systemd-timesyncd is not called systemd-ntpd.
2015-04-07 16:43:37 +02:00
Lennart Poettering
da00518b3f path-util: fix more path_is_mount e792e890f fallout 2015-04-07 16:03:45 +02:00
Lennart Poettering
ceb2422926 polkit: rename bus_verify_polkit() to bus_test_polkit() and make it strictly non-interactive
Interactive authorization should only happen asynchronously, hence
disallow it in synchronous bus_verify_polkit(), and rename it to
bus_test_polkit(). This way even if the bus message header asks for
interactive authorization, we'll ask for non-interactive authorization
which is actually the desired behaviour if CanSuspend, CanHibernate and
friends, which call this function.
2015-04-07 15:42:25 +02:00
Lennart Poettering
527b7a421f util: rework cunescape(), improve error handling
Change cunescape() to return a normal error code, so that we can
distuingish OOM errors from parse errors.

This also adds a flags parameter to control whether "relaxed" or normal
parsing shall be done. If set no parse failures are generated, and the
only reason why cunescape() can fail is OOM.
2015-04-07 15:42:25 +02:00
David Herrmann
64f75d7a28 core: fix mount setup to work with non-existing mount points
We must not fail on ENOENT. We properly create the mount-point in
mount-setup, so there's really no reason to skip the mount. Make sure we
just skip the mount on unexpected failures or if it's already mounted.
2015-04-07 14:03:44 +02:00
David Herrmann
24eb4a3098 device: fix sysattr newline cutter
Right now, we always drop the last character of all values we write to
sysfs. Fix this!
2015-04-07 13:11:18 +02:00
Hans de Goede
bd1acc9f2f udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER
input_id already (tries to) tag accelerometers as such, but this only works
for absolute accelerometers. Recent kernels mark accelerometers through an
input prop. Trust that prop and always tag devices with it with
ID_INPUT_ACCELEROMETER.

Note that detection by the prop bit works the same as the existing detection
and will ensure that no other tags get set on the device.
2015-04-07 11:32:36 +10:00
Peter Hutterer
606df97b6a udev: input_id: tag pointing sticks as ID_INPUT_POINTINGSTICK
Also referred to as trackpoint, trackstick. These are marked by recent kernels
through an input prop. Forward that prop as udev property so userspace can
easily determine whether there is a pointing stick present.

These devices were previously marked as ID_INPUT_MOUSE, for backwards
compatibility we keep that in place, the new property is an addition.
2015-04-07 11:07:32 +10:00
Daniel Mack
b604cb9bf6 core: mount-setup: handle non-existing mountpoints gracefully
Commit e792e890f ("path-util: don't eat up ENOENT in
path_is_mount_point()") changed path_is_mount_point() so it doesn't hide
-ENOENT from its caller. This causes all boots to fail early in case
any of the mount points does not exist (for instance, when kdbus isn't
loaded, /sys/fs/kdbus is missing).

Fix this by returning 0 from mount_one() if path_is_mount_point()
returned -ENOENT.
2015-04-07 00:50:10 +02:00
Lennart Poettering
f70a17f8d4 btrfs: add support for recursive btrfs snapshotting 2015-04-06 15:26:59 +02:00
Lennart Poettering
cbf21ecc02 btrfs: missing endian conversion fix 2015-04-06 14:55:45 +02:00
Lennart Poettering
e9bc1871b9 btrfs: make btrfs_subvol_snapshot() parameters a flags field 2015-04-06 14:54:58 +02:00
Lennart Poettering
d9e2daaf3d btrfs: support recursively removing btrfs snapshots 2015-04-06 11:28:16 +02:00
Lennart Poettering
41d1ed059b machined: drop btrfs subvolumes when removing container images 2015-04-06 10:57:53 +02:00
Lennart Poettering
e792e890fe path-util: don't eat up ENOENT in path_is_mount_point()
There's no reason to eat up ENOENT, it should be OK to simply report the
error back.
2015-04-06 10:57:53 +02:00
Lennart Poettering
05d990efd7 path-util: make sure fd_is_mount_point() returns true for root directory 2015-04-06 10:57:53 +02:00
Lennart Poettering
9e9b663aae rm-rf: add support for recursively removing btrfs subvolumes 2015-04-06 10:57:53 +02:00
Lennart Poettering
8f06b239f2 path-util: if parent can do name_to_handle() but relevant dir not, it's a mount point 2015-04-06 10:57:53 +02:00