1
0
mirror of https://github.com/systemd/systemd.git synced 2024-11-07 01:27:11 +03:00
Commit Graph

12449 Commits

Author SHA1 Message Date
Kay Sievers
7759ecb21e silent a few more gcc warnings 2013-10-21 18:40:33 +02:00
Kay Sievers
03a170c03c build-sys: disable _FORTIFY_SOURCE for -Og builds for now
Older gcc versions throw things like:

  In file included from /usr/include/fcntl.h:302:0,
                 from ../src/core/execute.c:25:
In function 'open',
    inlined from 'open_null_as' at ../src/core/execute.c:196:12:
/usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode'
  declared with attribute error: open with O_CREAT in second argument needs 3 arguments
    __open_missing_mode ();
2013-10-21 18:29:53 +02:00
Kay Sievers
df28bc0836 build-sys: use -Og instead of -O0 to catch warnings
$ touch src/core/dbus.c; make CFLAGS=-O0
  make --no-print-directory all-recursive
  Making all in .
    CC       src/core/libsystemd_core_la-dbus.lo
    CCLD     libsystemd-core.la

  $ touch src/core/dbus.c; make CFLAGS=-Og
  make --no-print-directory all-recursive
  Making all in .
    CC       src/core/libsystemd_core_la-dbus.lo
  src/core/dbus.c: In function 'init_registered_system_bus':
  src/core/dbus.c:798:18: warning: 'id' may be used uninitialized in this function [-Wmaybe-uninitialized]
           dbus_free(id);
                    ^
    CCLD     libsystemd-core.la

-Og Optimize debugging experience. -Og enables optimizations that do
not interfere with debugging. It should be the optimization level of
choice for the standard edit-compile-debug cycle, offering a
reasonable level of optimization while maintaining fast compilation
and a good debugging experience.
2013-10-21 15:46:00 +02:00
Kay Sievers
d1f0e886e1 rules: remove pointless MODE= settings
Changing the default MODE= for the group accessi, but not specifying
a GROUP= does not provide anything.

It disables the default logic that the mode switches to 0660 as soon
as a GROUP= is specifed, which make custom rules uneccesarily complicated.

https://bugs.freedesktop.org/show_bug.cgi?id=70665
2013-10-21 03:49:03 +02:00
Dave Reisner
464b3d6441 socket-proxyd(1): fix references to non-existant files
socket.target -> sockets.target
/usr/bin/systemd-socket-proxyd -> /usr/lib/systemd/systemd-socket-proxyd
2013-10-20 19:30:38 -04:00
Kay Sievers
bd4b5df2cb bus: initialize variable, now that we might skip debug logging 2013-10-21 00:56:47 +02:00
Kay Sievers
ca2871d9b0 bus: remove static introspection file export 2013-10-21 00:41:26 +02:00
Kay Sievers
af8601fa8b bus: allow to specify NULL as an empty string to add 2013-10-21 00:21:27 +02:00
Colin Walters
f24e86530c log: Fix previous commit to use correct level 2013-10-20 16:02:26 -04:00
Kay Sievers
87ff6b1c2a log: avoid calling the logging functions for log levels above the current maximum
Messages with log levels above the current maximum log level will be dropped
inside log_meta(). But to be able to call the function, all parameters for
the function need to be provided. This can easily get expensive, if values
need to be calculated or functions are used in parameters.

Avoid all useless work by checking inside the macro, before we look
at any parameters passed to the logging functions.
2013-10-20 21:26:47 +02:00
Kay Sievers
145d22584f build-sys: unify foo_CFLAGS = usage and add explaining comments
Always add the default AM_CFLAGS first.

If variables are used in conditionals, the default assignment
of AM variables is disabled, even when the conditional is not
in use; foo_CFLAGS = $(AM_CFLAGS) is needed, even when it looks
like a no-op.
2013-10-20 17:34:15 +02:00
Colin Walters
a54156a297 Revert "build-sys: move journalctl CFLAGS= to one line"
This reverts commit e5d5aa1d0f4e143f12f5e00ca072547369d37e53; it
breaks if !HAVE_QRENCODE since then we aren't using $(AM_CFLAGS) for
journalctl.
2013-10-20 09:53:05 -04:00
Kay Sievers
3396c37f91 vimrc: disable -fdiagnostics-color output 2013-10-20 04:29:39 +02:00
David Strauss
6298945d5c socket-proxyd: Remove datagram research TODO. This proxy will not work with them. 2013-10-19 17:11:36 -07:00
David Strauss
20c7c931a9 socket-proxyd: Comment and log text cleanup.
* Standardize on "nonblocking" spelling, per Linux man pages.
 * Clarify that the nonblocking sockets are never in a "blocking"
   or "unblocked" state, just a "would block" or "ready" state.
2013-10-19 17:05:42 -07:00
Kay Sievers
8100106762 man: systemd-fstab-generator - remove <term>
Element term in namespace '' encountered in para, but no template matches.
2013-10-20 01:16:32 +02:00
Kay Sievers
743bc3c979 hwdb: update 2013-10-20 01:12:29 +02:00
Kay Sievers
b6818c7d10 socket-proxyd: initialize variable used in error code path 2013-10-20 01:10:49 +02:00
Kay Sievers
e5d5aa1d0f build-sys: move journalctl CFLAGS= to one line 2013-10-20 01:00:23 +02:00
Tom Gundersen
a7f9b27596 trivial: rfkill - don't include util.h twice 2013-10-19 19:28:21 +02:00
Colin Walters
e6a5e5be83 trivial: rfkill: It's util.h, not utils.h
How about we actually run make locally before pushing, eh?
2013-10-19 09:02:01 -04:00
Tom Gundersen
255ee79bf3 man: fix typos in backlight/rfkill page
/me must learn to also test manpage changes
2013-10-19 12:33:47 +02:00
Tom Gundersen
182ae34769 TODO: update 2013-10-19 12:23:41 +02:00
Tom Gundersen
06f0639331 udev-builtin: uaccess - inherit logging form udev
Not that it makes a difference in this builtin, but otherwise /etc/udev/udev.conf is not respected.
2013-10-19 12:23:17 +02:00
Tom Gundersen
a7623afb7a fsck-root: only run when requested in fstab
fsck-root is redundant in case an initrd is used, or in case the rootfs
is never remounted 'rw', so the new default is the correct behavior for
most users. For the rest, they should enable it in fstab.
2013-10-19 12:23:17 +02:00
Tom Gundersen
d09ee17da2 efi-boot-generator: hookup to fsck 2013-10-19 12:23:17 +02:00
Tom Gundersen
accdd018ed mount/service: drop FsckPassNo support
We now treat passno as boleans in the generators, and don't need this any more. fsck itself
is able to sequentialize checks on the same local media, so in the common case the ordering
is redundant.

It is still possible to force an order by using .d fragments, in case that is desired.
2013-10-19 12:23:17 +02:00
Thomas Bächler
4952a9beff Remove FsckPassNo from systemd-fsck-root.service 2013-10-19 12:23:17 +02:00
Thomas Bächler
4c8bda2442 gpt-auto-generator: Generate explicit dependencies on systemd-fsck@.service instead of using FsckPassNo
[tomegun: check for OOM]
2013-10-19 12:23:17 +02:00
Thomas Bächler
64e70e4b86 fstab-generator: Generate explicit dependencies on systemd-fsck@.service instead of using FsckPassNo
[tomegun:
  * order all fsck instances after fsck-root
  * check for OOM
  * added notes in the manpages]
2013-10-19 12:23:17 +02:00
Thomas Bächler
7f5806d709 fstab-generator: When parsing the root= cmdline option, set FsckPassNo to 1
[tomegun: without this we would never fsck the rootfs if it was directly
mounted 'rw' from the initrd. We now risk fsck'ing it twice in the case it
is mounted 'ro', so that should be addressed in a separate patch.]
2013-10-19 12:23:17 +02:00
Tom Gundersen
295edddf5a kerne-command-line: introduce option 'systemd.restore_state'
When set to 0 this will stop tools like the backlight and rfkill tools to
restore state from previous boot. This is useful in case the stored state
is bogus to the extent that it is preventing you from resetting it (e.g.,
the backlight settings cause the screen to be off on boot on a system where
the backlight can not be adjusted directly from the keyboard).
2013-10-19 00:46:10 +02:00
Tom Gundersen
efc815a13d TODO: add some fsck items 2013-10-19 00:07:50 +02:00
Colin Walters
4ca302b967 build-sys: Honor CFLAGS for journalctl again
Regression from e905a45681.
2013-10-18 10:13:52 -04:00
Lennart Poettering
58c5d4215a build-sys: fix += vs = in Makefile 2013-10-18 14:21:36 +02:00
Lennart Poettering
1daf812152 bus: if we hit the end of an array container return 0 as EOF indicator when reading it 2013-10-18 14:07:44 +02:00
Tom Gundersen
89456fcee4 update-utmp: port to sd-bus
Change from GetUnit to LoadUnit to make sure we can detect the current legacy
runlevel, even if nothing loaded the legacy target files yet.
2013-10-18 06:21:26 +02:00
Lennart Poettering
96c374d0a5 socket-proxyd: rename from saproxy
The thing is a daemon, hence needs a "d" prefix. Also, we tend to not
abbreviate names of background components unnecessarily, since they are
not primary commands people type. Then, the fact that this thing does
socket actviation is mostly in implementationd detail for the proxy.

Also, do some minor indenting clean-ups and other code updates.
2013-10-18 02:58:47 +02:00
Lennart Poettering
e905a45681 build-sys: drop a number CFLAGS assignments in Makefile that are pointless 2013-10-18 02:37:38 +02:00
Lennart Poettering
abc5fe7250 bus: automatically flush bus queue when we exit the event loop
This way, we do not have to call it manually
2013-10-18 01:43:55 +02:00
Tom Gundersen
b75b4db0af initctl: port to sd-bus 2013-10-18 01:34:55 +02:00
Tom Gundersen
d05f1cae2f cgroup-agent: port to sd-bus 2013-10-18 00:55:24 +02:00
Tom Gundersen
0c842e0ac0 fsck: port to sd-bus 2013-10-18 00:55:24 +02:00
Lennart Poettering
7e9cf16c20 timedated: disable debug logging 2013-10-18 00:49:01 +02:00
Lennart Poettering
66a4c743c0 hostnamed: port over from libdbus to libsystemd-bus 2013-10-18 00:49:01 +02:00
Dave Reisner
fe8245eb3c sd-event: initialize return value
src/libsystemd-bus/sd-event.c:1597:13: warning: 'r' may be used
uninitialized in this function [-Wmaybe-uninitialized]
2013-10-17 16:19:48 -04:00
David Strauss
70d8320978 Fix kmod error message to have correct version requirement 2013-10-17 13:19:29 -07:00
Tom Gundersen
a18535d9e1 static-nodes: don't call mkdir
This is no longer necessary with kmod-15. Bump the requirement.
2013-10-17 19:53:44 +02:00
Kay Sievers
ca2f4176fe tmpfiles: log unaccessible FUSE mount points only as debug message 2013-10-17 03:20:46 +02:00
Lennart Poettering
03cc26dda4 timedated: expose time and NTP sync flag via the bus
This way, timedatectl can be run over the network and determine all
properties correctly from the server rather than the client.
2013-10-17 01:03:39 +02:00