1
0
mirror of https://github.com/systemd/systemd.git synced 2024-11-01 00:51:24 +03:00
The systemd System and Service Manager
Go to file
Zbigniew Jędrzejewski-Szmek a88f9dbae2 systemctl: unset const char* arguments in static destructors
When fuzzing, the following happens:
- we parse 'data' and produce an argv array,
- one of the items in argv is assigned to arg_host,
- the argv array is subsequently freed by strv_freep(), and arg_host has a dangling symlink.

In normal use, argv is static, so arg_host can never become a dangling pointer.
In fuzz-systemctl-parse-argv, if we repeatedly parse the same array, we
have some dangling pointers while we're in the middle of parsing. If we parse
the same array a second time, at the end all the dangling pointers will have been
replaced again. But for a short time, if parsing one of the arguments uses another
argument, we would use a dangling pointer.

Such a case occurs when we have --host=… --boot-loader-entry=help. The latter calls
acquire_bus() which uses arg_host.

I'm not particularly happy with making the code more complicated just for
fuzzing, but I think it's better to resolve this, even if the issue cannot
occur in normal invocations, than to deal with fuzzer reports.

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=31714.
2021-05-31 19:29:07 +02:00
.github Merge pull request #19669 from mrc0mmand/ci-mkosi-arch 2021-05-20 10:14:30 +01:00
.lgtm/cpp-queries lgtm: complain about accept() [people should use accept4() instead, due to O_CLOEXEC] 2019-04-10 20:03:38 +02:00
.mkosi mkosi: stop pulling in vi 2021-05-19 10:55:03 +02:00
.semaphore ci: drop py2 lxml, pull in jinja2 2021-05-19 10:25:26 +09:00
catalog meson: revert the change to unquote commands in add_install_script 2021-05-14 19:52:25 +02:00
coccinelle coccinelle: filter out a couple of 'false-positive' transformations 2021-03-18 11:59:53 +01:00
docs man: document new nspawn --bind-user= feature 2021-05-19 17:46:59 +02:00
factory/etc pam: fix typo try_authtok → use_authtok 2021-05-12 12:14:17 +02:00
hwdb.d Merge pull request #19697 from jwrdegoede/hwdb-more-accel-quirks 2021-05-22 23:57:18 +01:00
man network: IPv6LinkLocalAddressGenerationMode=none disables IPv6LL addressing 2021-05-23 17:13:06 +09:00
mkosi.default.d mkosi: Enable InstallDirectory and SourceFileTransferFinal options 2021-01-06 23:28:34 +00:00
modprobe.d Add READMEs in all .d directories 2021-03-26 09:35:07 +01:00
network meson: revert the change to unquote commands in add_install_script 2021-05-14 19:52:25 +02:00
po Update Korean translation (#19083) 2021-05-13 10:19:48 +02:00
presets license: LGPL-2.1+ -> LGPL-2.1-or-later 2020-11-09 13:23:58 +09:00
rules.d meson: use jinja2 for rules.d templates 2021-05-19 10:24:43 +09:00
shell-completion meson: use jinja2 in shell-completion/ 2021-05-19 10:25:26 +09:00
src systemctl: unset const char* arguments in static destructors 2021-05-31 19:29:07 +02:00
sysctl.d meson: use jinja2 in sysctl.d/ 2021-05-19 10:24:43 +09:00
sysusers.d meson: replace some m4 templates with jinja2 2021-05-19 10:24:43 +09:00
test systemctl: unset const char* arguments in static destructors 2021-05-31 19:29:07 +02:00
tmpfiles.d meson: add workaround for old meson 2021-05-19 10:25:26 +09:00
tools Drop dependency on m4 2021-05-19 10:24:43 +09:00
units units: make sure importd has CAP_LINUX_IMMUTABLE flag 2021-05-22 16:02:02 +09:00
xorg scripts: use 4 space indentation 2019-04-12 08:30:31 +02:00
.clang-format clang-format: set SpaceBeforeParens to ControlStatementsExceptForEachMacros 2020-11-16 16:57:51 +09:00
.ctags editors: Prevent ctags from following symlinks 2019-02-15 11:01:20 -08:00
.dir-locals.el scripts: use 4 space indentation 2019-04-12 08:30:31 +02:00
.editorconfig editorconfig: add man configuration 2020-05-26 15:37:05 +02:00
.gitattributes udev: Extract RAM properties from DMI information 2020-12-16 18:32:29 +01:00
.gitignore Move shared mkosi settings to a single file in mkosi.default.d/ 2021-01-06 12:10:58 +00:00
.lgtm.yml ci: drop py2 lxml, pull in jinja2 2021-05-19 10:25:26 +09:00
.mailmap mailmap: two more names 2021-03-30 13:17:58 +02:00
.packit.yml packit: drop the 'sources' file after cloning the Fedora repo 2021-04-12 18:10:04 +02:00
.vimrc scripts: use 4 space indentation 2019-04-12 08:30:31 +02:00
.ycm_extra_conf.py ycm: add doc string for all the functions in configuration file 2017-11-29 13:21:49 -07:00
configure tree-wide: add spdx header on all scripts and helpers 2021-01-28 09:55:35 +01:00
LICENSE.GPL2
LICENSE.LGPL2.1 licence: remove references to old FSF address 2012-12-17 11:41:31 +01:00
Makefile tree-wide: add spdx header on all scripts and helpers 2021-01-28 09:55:35 +01:00
meson_options.txt test: enable fuzz regression tests by default 2021-05-20 09:30:43 +02:00
meson.build test: enable fuzz regression tests by default 2021-05-20 09:30:43 +02:00
mkosi.build mkosi: work-around to make systemd build in Fedora images that lack populated /etc 2021-04-07 17:45:28 +02:00
NEWS NEWS: prep release date 2021-03-30 22:00:11 +02:00
README Drop dependency on m4 2021-05-19 10:24:43 +09:00
README.md ci: point the Fossies badge to main 2021-01-21 20:08:44 +01:00
TODO update TODO 2021-05-07 22:44:39 +02:00

Systemd

System and Service Manager

Count of open issues over time Count of open pull requests over time Semaphore CI 2.0 Build Status
Coverity Scan Status
OSS-Fuzz Status
CIFuzz
CII Best Practices
Language Grade: C/C++
CentOS CI - CentOS 7
CentOS CI - Arch
CentOS CI - Arch (sanitizers)
Fossies codespell report
Packaging status

Details

Most documentation is available on systemd's web site.

Assorted, older, general information about systemd can be found in the systemd Wiki.

Information about build requirements is provided in the README file.

Consult our NEWS file for information about what's new in the most recent systemd versions.

Please see the Hacking guide for information on how to hack on systemd and test your modifications.

Please see our Contribution Guidelines for more information about filing GitHub Issues and posting GitHub Pull Requests.

When preparing patches for systemd, please follow our Coding Style Guidelines.

If you are looking for support, please contact our mailing list or join our IRC channel.

Stable branches with backported patches are available in the stable repo.