shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-08-29 09:49:33 +03:00
Code Issues Projects Releases Wiki Activity

util: Relax name validation (bz 917444)

Browse Source 
Warn about common cases like spaces in name, and let libvirt error on
the rest.
This commit is contained in:
Cole Robinson
2014-02-01 08:37:28 -05:00
parent 17c0ae3a3c
commit 4ce356985a
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
virtinst/util.py
View File

@ -140,15 +140,16 @@ def validate_uuid(val):
def validate_name(name_type, val):
if type(val) is not str or len(val) == 0:
raise ValueError(_("%s name must be a string") % name_type)
if re.match("^[0-9]+$", val):
raise ValueError(_("%s name can not be only numeric characters") %
name_type)
if re.match("^[a-zA-Z0-9._-]+$", val) is None:
raise ValueError(_("%s name can only contain alphanumeric, '_', '.', "
"or '-' characters") % name_type)
# Rather than try and match libvirt's regex, just forbid things we
# know don't work
forbid = [" "]
for c in forbid:
if c in val:
raise ValueError(_("%s name can not contain '%s' character.") % c)
def validate_macaddr(val):