3562 Commits

Author SHA1 Message Date
Cole Robinson
16390a5433 clitest: Infrastructure for skipping test compare
Our virt-xml tests don't compare correctly if we aren't using the
latest libvirt that supports the <panic> device.
2014-01-30 11:05:45 -05:00
Giuseppe Scrivano
3a4be995db tests: fix tests with latest libvirt from git
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-01-30 08:41:52 -05:00
Cole Robinson
dde0012732 tests: Fix my busted clone skip change 2014-01-30 08:41:28 -05:00
Cole Robinson
3cd47c9e9f console: Make sure viewer exists before setting grab_keys 2014-01-29 13:07:43 -05:00
Cole Robinson
4314a8379b tests: Silence needless 'skip' output 2014-01-29 11:36:19 -05:00
Cole Robinson
7585474662 man: Don't fully document deprecated options 2014-01-29 11:27:36 -05:00
Cole Robinson
88cef6d25d Fix some pylint 2014-01-29 11:03:20 -05:00
Cole Robinson
0a77093cbc console: Handle ipv6 addresses (bz 974126) 2014-01-29 11:02:54 -05:00
Cole Robinson
6042d762b5 cli: Add --graphics connected option (bz 730923) 2014-01-29 09:52:49 -05:00
Cole Robinson
64b2d0c6b7 Move shared graphics editing UI to gfxdetails.py
Fixes a couple UI bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=696217
https://bugzilla.redhat.com/show_bug.cgi?id=875403
2014-01-29 09:22:28 -05:00
Cole Robinson
d0c734e215 devicegraphics: Fix updating listen address
We need to make sure to change the corresponding <listen> block on newish
libvirt.
2014-01-29 09:22:28 -05:00
Cole Robinson
c5581c01d2 Move sharedui.py to vmmenu.py
Since that's all it contains now
2014-01-29 09:22:28 -05:00
Cole Robinson
00d5312bd6 Break out shared storage creation UI to addstorage.py 2014-01-29 09:22:28 -05:00
Giuseppe Scrivano
8c5b1de33c doc: do not mention state="on|off" for features
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1024700

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-01-29 14:58:29 +01:00
Chen Hanxiao
45ec7baf92 details: show port number of console device in typelabel
We could set multi console for VM and containers.
But our UI did not show the number of it.
It would bring troubles when we want to delete one.
This patch will show port number of console device
in typelabel.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-29 10:44:55 +08:00
Chen Hanxiao
3b9b915292 man: fix a small typo in virt-manager man page
s/supportted/supported

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-29 10:15:23 +08:00
Cole Robinson
1597677e61 netlist: Listen for net-added events and update the list 2014-01-28 14:40:17 -05:00
Cole Robinson
8bb9853ec8 Move shared cdrom media UI to mediacombo.py 2014-01-28 14:20:57 -05:00
Cole Robinson
745ec7cb96 create: Reinit netlist on each run
Will be easier to handle if we make the netlist react to connection
signals.
2014-01-28 13:59:31 -05:00
Cole Robinson
bd15cd3d6e distroinstaller: Fix volume upload with latest libvirt bindings (bz 1058720) 2014-01-28 10:00:06 -05:00
Cole Robinson
169ae1203d Break out shared network list UI to netlist.py
Use this to show vport stuff in addhw, give a warning about macvtap
networking, and allow macvtap from the create wizard.
2014-01-28 10:00:06 -05:00
Martin Kletzander
53a57fcdd8 Don't use SCSI or USB disks with stable_defaults
One more fix I forgot to ammend into commit dc0b9bb.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-01-28 11:27:39 +01:00
Chen Hanxiao
ffda1e8ef4 virt-install: add support for option "--cpu host-model-only"
commit 7003a3a52821e2813d41989ab7a88d2b7aa590f1 introduced
"nearest host cpu model" option.
This patch add an option "--cpu host-model-only" to virt-install.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-28 09:40:00 +08:00
Chen Hanxiao
269a09de8f man: fix typos in virt-xml man page
s/editting/editing
s/editted/edited

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-28 09:28:30 +08:00
Cole Robinson
dde460e399 xmlbuilder: Fix adding devices with child properties
And test it
2014-01-27 19:55:37 -05:00
Cole Robinson
37e1242bf4 details: Fix virtualport UI when IDs are empty 2014-01-27 15:06:27 -05:00
Cole Robinson
dc4e1da434 addhw: macvtap: select bridge mode by default 2014-01-27 15:05:50 -05:00
Cole Robinson
b963c3ec39 cli: Allow '--option help' for introspection as well 2014-01-27 14:48:23 -05:00
Cole Robinson
e2cb91c39d man: virt-xml: Tweak some examples 2014-01-27 11:12:28 -05:00
Cole Robinson
9d922f56df fsdetails: Fix error reporting
The UI file layout meant we were trying to use a gtk.Grid object
as the error dialog parent. Rework things to behave like snapshots.py
2014-01-27 11:03:59 -05:00
Cole Robinson
889ec18031 uiutil: Use list selection helpers everywhere 2014-01-27 10:46:14 -05:00
Cole Robinson
2771511946 uiutil: Make more use of set_combo_text_column 2014-01-26 21:35:42 -05:00
Chen Hanxiao
4b72c5f2a0 virtinst: clearer error message when disks upper limits reached
We set upper limits for virtio, hd ... disks in virtinst.
So we should let users know this.

Improve error message suggested by:
https://bugzilla.redhat.com/show_bug.cgi?id=822331

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-27 10:22:08 +08:00
Cole Robinson
708a2737cf Split uihelpers into sharedui and uiutil
Reserve uiutil for the little gtk helper functions, rest goes into shared
UI (which all should probably be factored into their own files but thats
a task for another day)
2014-01-26 18:15:50 -05:00
Cole Robinson
2a34b353da uihelpers: Move browse_local to error.py
It doesn't fit any better, but now it's accessible to all UI classes
more easily.
2014-01-26 18:01:10 -05:00
Cole Robinson
58d5e0b799 uihelpers: Move a few more functions closer to their callers 2014-01-26 17:51:15 -05:00
Cole Robinson
20088ab8fb Move many shared UI functions to addhw static functions
Much of uihelpers is just simple stuff that's shared between addhw
and details UI, so just make it staticmethods in addhw, which details
already has a reference to.
2014-01-26 17:09:07 -05:00
Cole Robinson
ad363f9774 details: Remove runtime vcpu pinning list
I don't think anyone depended on this, and it's overkill for virt-manager.
2014-01-26 14:21:24 -05:00
Cole Robinson
e771af0112 details: If refresing page errors, still disable apply
and switch to the busted page, rather than strangely stay on the
previous page.
2014-01-26 14:15:46 -05:00
Cole Robinson
11ebe5d84e details: Move inspection info to its own page 2014-01-26 14:15:46 -05:00
Cole Robinson
46ad7e8bdb details: Remove UI for security, apic, acpi, clock
99% of users never need to tweak them, and now that we have virt-xml,
most of what they could want to do is a simple CLI oneliner.
2014-01-26 14:15:46 -05:00
Cole Robinson
2688ca64bb virt-xml: Fill in man page 2014-01-26 13:09:26 -05:00
Cole Robinson
b004d11eae cli: Fix unsetting --disk path 2014-01-26 13:09:26 -05:00
Cole Robinson
57e89cda8b virt-xml: Create storage if necessary 2014-01-26 13:09:26 -05:00
Cole Robinson
6e06b3642b cli: Explicitly error on cli options like --disk readonly
All options should be opt=val pairs, but we behaved weirdly on missing
= before.
2014-01-25 20:30:08 -05:00
Cole Robinson
443ae1b303 virt-xml: Change clear format to clearxml=yes, add --help example 2014-01-25 20:30:08 -05:00
Cole Robinson
110d6aac83 virt-xml: Add --build-xml option for just outputing XML 2014-01-25 20:30:08 -05:00
Cole Robinson
48f69dd638 virt-xml: Add --update option for hotplug/hotunplug 2014-01-25 19:51:56 -05:00
Cole Robinson
ecfc1a527d virt-xml: Make --domain positional, allow stdin XML 2014-01-25 18:16:16 -05:00
Cole Robinson
6fa2876486 virt-xml: Actually update the INACTIVE xml 2014-01-25 17:20:30 -05:00