shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-22 22:03:58 +03:00
Code Issues Projects Releases Wiki Activity
6,892 Commits 2 Branches 64 Tags
Commit Graph

1426 Commits

Author SHA1 Message Date
Cole Robinson
2897951ce1 tests: Drop os.system calls 
Use python native code instead. This seems to avoid an occasional
crash or abort of some sort with latest libosinfo
 2019-07-17 16:54:59 -04:00
Cole Robinson
f4d62660f1 tests: Don't use the root logger 
Stops logging spam from requests
 2019-07-16 16:53:22 -04:00
Cole Robinson
0df8577e11 test_urls: dont try ftp:// with --force-libosinfo 2019-07-16 16:53:14 -04:00
Cole Robinson
3eeef679da test_urls: Remove dead mageia link 2019-07-16 16:53:08 -04:00
Athina Plaskasoviti
2b24a85884 cli: Add --clock timer[0-9]*.track, timer[0-9]*.mode, timer[0-9]*.frequency options 
XML Mapping:

<clock>
...
  <timer track="X" mode="X" frequency="X"/>
...
</clock>

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
 2019-07-15 16:11:51 -04:00
Cole Robinson
a15770fbaf Fix codespell errors 2019-07-12 16:10:39 -04:00
Cole Robinson
0c223ab21f guest: Don't set default uefi if firmware= is set 2019-07-12 16:01:21 -04:00
Fabiano Fidêncio
e5980863dd unattended: Always set "media" as install-source for ISOs 
Let's set "media" as installation source for all the ISOs, even the
net-installer ones, as this can be dealt with on osinfo-db side.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
 2019-07-12 15:07:22 -04:00
Cole Robinson
e678d94b45 tests: Add debian10 URL testing 2019-07-11 14:29:17 -04:00
Cole Robinson
aaa065d38e createpool: Add more coverage testing 2019-07-03 19:37:01 -04:00
Cole Robinson
616a7f2dd5 createpool: Simplify LVM volume group UI 
Only show the volgroup name, and nothing else, which is all mostly
extraneous

https://bugzilla.redhat.com/show_bug.cgi?id=1316977
 2019-07-03 19:37:01 -04:00
Cole Robinson
105553563a storage: Simplify source pool enumeration 
Don't return an XML object stub, just return the relevant data.
Make it explicit that we currently are only supporting lvm
enumeration
 2019-07-03 19:37:01 -04:00
Cole Robinson
fd8847c24e storage: test default_target_path 2019-07-03 19:37:01 -04:00
Cole Robinson
199e9593bf storage: test default_source_name 2019-07-03 19:37:01 -04:00
Cole Robinson
9d7b20d3de storage: Add lots of coverage testing and exemptions 2019-07-03 19:37:01 -04:00
Cole Robinson
f64655a843 storage: Replace pool supports_property with supports_X 
Makes usage more explicit, and easier to track for coverage testing
 2019-07-03 19:37:01 -04:00
Fabiano Fidêncio
58c6876450 unattended: Read the passwords from a file 
Let's not expose the user/root password in the CLI and, instead, let's
rely on a file passed by the admin and read the password from there.

'CVE-2019-10183' has been assigned to the virt-install --unattended
admin-password=xxx disclosure issue.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
 2019-07-03 13:25:26 -04:00
Cole Robinson
5312a9611b virt-install: Revive --wait 0 as alias for --noautoconsole 
This was the behavior prior to last release, and we received
a bug report about it. Revive it, but warn about the recommended way
to do it

https://bugzilla.redhat.com/show_bug.cgi?id=1724287
 2019-07-03 13:12:19 -04:00
Cole Robinson
f3e7b9a8f0 cli: Finish off test coverage 2019-07-03 13:12:10 -04:00
Cole Robinson
3a1f10c6c5 cli: Remove warnings about spice and GL 
libvirt catches the missing support here, and the warnings are not
accurate because these values can work with SDL and EGL headless.
 2019-07-02 14:58:44 -04:00
Cole Robinson
1277f5ebb1 clitest: Add non-testsuite virt-install stub 
For hitting some logging code paths that are disabled for the
testsuite
 2019-07-02 12:55:53 -04:00
Cole Robinson
5824cccf23 tests: test_urls: Add a fedora ftp:// example 2019-07-01 19:32:57 -04:00
Cole Robinson
2df7a6bab4 tests: test_urls: Actually test centos7 aarch64 2019-06-25 10:15:42 -04:00
Cole Robinson
2c49c3887c tests: test_urls: Better error report overwriting 2019-06-24 19:39:07 -04:00
Cole Robinson
e4b4834a58 uitests: newvm: More attempts to make the PXE test less flakey 2019-06-18 10:01:26 -04:00
Athina Plaskasoviti
b6563b90e5 cli: Add --numatune options memnode[0-9]*.cellid, memnode[0-9]*.mode, memnode[0-9]*.nodeset 
XML Mapping:

<numatune>
...
  <memnode cellid="X" mode="X" nodeset="X"/>
...
</numatune>

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
 2019-06-17 17:41:25 -04:00
Andrea Bolognani
eda3c22458 guest: Add memory balloon by default 
libvirt already does this for pretty much all QEMU guests, but
ARM virt guests for example don't get a memory balloon by default
at that level of the stack.

virt-manager is in a good position to make sure defaults are
consistent across architectures, and there's no downside in having
the device in the XML passed to libvirt anyway.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
 2019-06-17 13:52:07 -04:00
Andrea Bolognani
1502417566 tests: Add a couple of virt-xml memballoon tests 
We're going to slightly change how the device is handled in
a minute, and we want to make sure we don't break existing
functionality while doing so.

Note that the existing singleton-config-* test cases already
provide coverage for both enabling and disabling the memory
balloon in virt-install.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
 2019-06-17 13:50:11 -04:00
Cole Robinson
8c5e0797e5 tests: dist: Drop forbidden import test 
It's broken, and in practice it has not turned out to be an issue
preventing gdk or gtk from leaking into virtinst
 2019-06-17 13:32:55 -04:00
Cole Robinson
728fd7cf7b cli: Don't generate path with 'None' if --name not specified 
Use 'disk' instead. It will take some work to unwind this so
that the path isn't generated until a name is truly specified
 2019-06-17 01:04:58 -04:00
Cole Robinson
6215c86fa2 virt-install: Warn about --location $DIR needing extra args 
https://bugzilla.redhat.com/show_bug.cgi?id=1677019
 2019-06-17 00:12:32 -04:00
Cole Robinson
16362671e9 virt-install: Add --install no_install=yes|no 
This just formalizes the behavior of things like --import and
--livecd
 2019-06-17 00:12:32 -04:00
Cole Robinson
230545bdb3 virt-install: Make bare '--wait' mean 'wait indefinitely' 2019-06-17 00:12:32 -04:00
Cole Robinson
e9439a8ef1 virtinst: Move multiple installer .py files to virtinst/install/ 2019-06-17 00:12:32 -04:00
Cole Robinson
f107e39989 Switch to more traditional logging structure 
Init a shared log instance in virtinst/logger.py, and use that
throughout the code base, so we aren't calling directly into
'logging'. This helps protect our logging output from being
cluttered with other library output, as happens with some
'requests' usage
 2019-06-17 00:12:31 -04:00
Cole Robinson
2c03ea5c92 hostnets: Remove SR-IOV info listing 
This is fairly advanced stuff and it should be fine to get this
info from the XML editor page
 2019-06-16 23:48:51 -04:00
Cole Robinson
59873f3876 hostnets: Remove QoS viewing/editing 
This is fairly niche, and can be reviewed or edited with the XML
editor
 2019-06-16 20:25:42 -04:00
Cole Robinson
fe0e36499b uitests: prefs: Another attempt to fix XML editor flakiness 2019-06-16 19:33:45 -04:00
Cole Robinson
9c8e879ff0 virt-install: Add --boot firmware= 2019-06-16 17:15:08 -04:00
Cole Robinson
53f075ab76 virt-xml: Warn if libvirt discards our defined changes 
This can happen if we try to remove a default device, like
 a ps2 mouse on x86, but it can happen for many other reasons as well

https://bugzilla.redhat.com/show_bug.cgi?id=1405263
 2019-06-16 17:08:59 -04:00
Cole Robinson
52c6094c65 virt-xml: Denest and comment code flow a bit 
Add lots of early exits to remove implicit fall through
behavior that I find hard to follow
 2019-06-16 16:47:05 -04:00
Cole Robinson
0221471e4f virt-xml: If no XML diff is generated, explicitly warn 2019-06-16 16:37:48 -04:00
Cole Robinson
4973564e65 virt-clone: add --skip-copy option 
This is the flip side to the --force-copy option. We already
have the plumbing internally

https://bugzilla.redhat.com/show_bug.cgi?id=1564865
 2019-06-16 14:41:54 -04:00
Cole Robinson
88f52f956e urldetect: Don't use dict ordering for URL detection 
ALLSTORES was implicitly using dict() ordering. This exposed
a bug in our code on debian ci which was nice, but it should
be deterministic. Hardcode the ordering
 2019-06-16 14:41:54 -04:00
Cole Robinson
df82856021 tests: Finish cloner.py coverage 2019-06-16 14:37:56 -04:00
Cole Robinson
dcd0b2ac81 cloner: Fill out test coverage 2019-06-15 16:15:01 -04:00
Pavel Hrdina
d6b6397ce0 virtManager: xmleditor: warn when switching to XML tab 
If there are unapplied changes in the UI warn user when they tries to
switch to XML editor.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2019-06-15 15:05:28 +02:00
Cole Robinson
524002da02 virt-xml: Abide domain name for --build-xml 
https://bugzilla.redhat.com/show_bug.cgi?id=1648939
 2019-06-14 21:37:50 -04:00
Cole Robinson
d40975c493 guest: Add back spice virtio-serial for windows 
This was removed in v2.0.0, but we've had some complains since then

https://bugzilla.redhat.com/show_bug.cgi?id=1660123
 2019-06-14 20:51:43 -04:00
Cole Robinson
c52e220504 devices: disk: Handle pool=iscsi-direct volumes 
I don't have a working setup for this so I'm not positive
it actually works, but this roughly matches what I see in
libvirt test suite data and docs

https://bugzilla.redhat.com/show_bug.cgi?id=1658511
 2019-06-14 20:35:41 -04:00