Commit Graph

2769 Commits

Author SHA1 Message Date
Gene Czarcinski
41c782a37e static route support
The syntax for static route support is defined by the
new <route> subelement which has the form:
  <route family='xx' address='xx' prefix='n' gateway='gg' metric='m'/>
This patch builds on the previous patches for adding IPv6 support and
extending the virtual network support.

The static route support code has been recently added to libvirt and will
be included in libvirt 1.0.6.
.
Signed-off-by: Gene Czarcinski <gene@czarc.net>
2013-05-21 15:45:34 -04:00
Cole Robinson
070e19eab9 Drop 'avahi-tools' package list used during dev (bz 963472) 2013-05-15 17:35:14 -04:00
Cole Robinson
bde9943221 gsettings: Fix default for perms-fix-ignore (bz 962569) 2013-05-15 15:35:55 -04:00
Cole Robinson
0877f9a3d9 Fix some pylint 2013-05-13 16:45:51 -04:00
Guannan Ren
a4e736a7cb domain: add 'pre-startup' signal and do nodedevs checking
This patch introduces 'pre-start' signal and registers
nodedev checking handler to check duplicate USB devices.
If virt-manager can not identify unique usb device any more
before domain startup, it will throw a tip error to tell it
is time to reattach host USB devices to get updated bus/addr info.
2013-05-13 16:43:33 -04:00
Cole Robinson
f625cf66d4 testdriver: Add guest using a duplicate host USB device 2013-05-11 11:44:25 -04:00
Cole Robinson
b68faac8e8 Fix crash when creating guest from ISO media (bz 958641)
Accessing another unknown gsettings key. Should be the last one
though...
2013-05-09 20:07:29 -04:00
Cole Robinson
d8deda4264 spec: Make sure virt-manager pulls in -common (bz 958730) 2013-05-09 18:32:30 -04:00
Cole Robinson
cce9d6fb2a virt-manager: Fix error reporting with invalid cli arg (bz 959795) 2013-05-09 18:29:07 -04:00
Cole Robinson
a3da77dab6 spec: Fix dep on vte (bz 958945) 2013-05-09 18:24:09 -04:00
Guannan Ren
32f0781531 addhardware: differentiate duplicate usb devices by bus/addr
When there are multiple usb devices with same vendor/product
in the host device list, the bus/addr is going to be used when
attaching one of usb devices.

Currently is_dup flag is only useful to VirtualHostDeviceUSB.

I put get_nodedevs_number() in connection.py, so the startup
hooks can use it.
2013-05-09 13:48:18 -04:00
Guannan Ren
4c1039252a virtinst: set is_dup to true when --host-device come with bus.addr
When there are multile USB devices, --host-device with bus.addr
can identify unique device, so we need to add bus/addr info to
XML rather than only vendor/product

If there is only one USB device with --host-device bus.addr,
adding bus/addr is no harm under the request of user.
2013-05-09 13:48:18 -04:00
Michal Novotny
3f58dc5423 INSTALL: Fix typo in RPM generation command
Signed-off-by: Michal Novotny <minovotn@redhat.com>
2013-05-08 14:22:26 -04:00
Cole Robinson
d3f9bc8e7a details: Remove unused bit in the UI 2013-04-29 12:24:46 -04:00
Tadej Janež
e8e6278c65 manager: show guest machine stats under Details -> Performance.
This fixes rhbz #878425.
2013-04-29 12:20:44 -04:00
Cole Robinson
44f788bb99 setup.py: Fix sdist 2013-04-27 09:28:15 -04:00
Cole Robinson
40cbc39a98 Revert "add a checkbox for cpu host-model mode, remove 'copy' button"
host-model is a bit more scary then previous behavior, since the
model of an existing VM can transparently change across libvirt
upgrade or HW upgrade. This will probably be improved at the libvirt
level, but for now revert.

This reverts commit 17f43e47fb.
2013-04-27 09:28:15 -04:00
Guannan Ren
5a316b9a51 details: the bus, device values of USB device is decimal rather than hex
Although the code in lookup_nodedev() is general to deal with
hostdev, it has to seperate USB device from PCI device there.
For PCI device, the domain/bus/slot/function is hex.
For USB device, the bus/device is decimal.

This fix makes the label use hostdev pretty_name:

 +------------------------------------------------------+
 | Physical USB Device                                  |
 |   Device: 006:032 RSA RSA SecureID (R) Authenticator |

(crobinso: fix some pylint)
2013-04-27 09:28:15 -04:00
Martin Kletzander
54c6bb6bd1 Add controller example into virt-install manual page
There was an example for USB controller, but to show all the
sub-options, there was the master= option used without extra
information about the fact that it is used for companion controllers
only.  So this patch adds second example in front of the previous one
and re-words the description a little bit.
2013-04-26 12:53:11 +02:00
Martin Kletzander
13c5ffc6cd Describe controller models in virt-install man page
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=952086
2013-04-26 08:53:42 +02:00
Guannan Ren
0802cb1add virtinst: throw error when --host-device can't specify unique device
When there are mutiple USB devices with identical vendorId and
productId, with --host-device <vendorId:productId>, virt-install
fails to specify one.
Currently the virt-install add the first node device with
these vendorId and productId.
This fix will throw out an error when argument to --host-device
can't specify unique node device.

For example:
virt-install ${other args} \
             --host-device <vendorId:productId>
ERROR    15e1:2007 corresponds to multiple node devices
2013-04-25 13:40:23 -04:00
Cole Robinson
b15e51e73b baseclass: Privatize refcount debug helper 2013-04-25 12:07:57 -04:00
Cole Robinson
6f4167a66f clone: Fix --preserve-data --file /existing/storage/vol
We were validating storage creation in a bunch of cases where we
shouldn't, since it was all skipped anyways.
2013-04-24 10:50:20 -04:00
Cole Robinson
978140b065 engine: Remove unneeded helper function 2013-04-23 20:00:12 -04:00
Cole Robinson
8d1ad359ee Don't leave *c files around after tests 2013-04-23 17:19:27 -04:00
Cole Robinson
b2041f7399 clitest: Remove massive dict, turn test cases into objects
This will make it easier in the future to annotate test cases with
libvirt version information, so the test suite can work across
libvirt versions.
2013-04-23 17:18:34 -04:00
Cole Robinson
a63a83684b manager: Fix a pep8 warning 2013-04-23 14:24:52 -04:00
Cole Robinson
1b18ddea3a gsettings: Simplify remembering last used paths 2013-04-23 14:21:46 -04:00
Cole Robinson
2f09a3665c prefs: Remove distinction between local and remote sound
Remote sound works fine these days. If people want to turn the
preference off, they probably want to do it in all cases, and can
'customize before install' to alter the rest.
2013-04-23 14:21:46 -04:00
Cole Robinson
f84ccc0cf9 prefs: Remove preference for 'history length'
Also kinda pointless, and I've never heard of anyone actually
tweaking it.
2013-04-23 14:21:45 -04:00
Cole Robinson
974867189d virtcli: Explicitly error if schemas fail to compile 2013-04-23 14:21:45 -04:00
Cole Robinson
c2aa6db6be manager: Fix weirdly changing row colors
Every launch was giving me different connection row colors, must be
some gtk/gobject bug.
2013-04-23 13:04:33 -04:00
Cole Robinson
4dbb2ee36d manager: Make creating list model more explicit 2013-04-23 12:42:41 -04:00
Cole Robinson
cd8dbad8b2 gsettings: Remove url-list-length
Kinda pointless, just default to 10
2013-04-23 12:42:22 -04:00
Cole Robinson
c6d5e5d267 config: Fix crash when launching create wizard
Caused by accessing invalid gsettings key
2013-04-23 12:28:21 -04:00
Martin Kletzander
70fa76a780 Support incomplete .treeinfo files
In case there was '.treeinfo' file available, virt-install was
forcibly getting image information out of the file.  For some
distributions (especially older releases, e.g. RHEL 4), there might be
'.treeinfo' file available, but with incomplete information.  Allow
fallback to default values even when '.treeinfo' file is found.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=954262
2013-04-22 16:57:40 +02:00
Cole Robinson
a58442ec3e Remove AUTHORS
Kind of a maintenance pain, and it's just poorly duplicating info
from the git logs. We could autogenerate this but I don't really
have the interest in figuring it out. Patches welcome :)
2013-04-21 14:05:06 -04:00
Cole Robinson
6f7fca5f2a tests: Greatly expand testdriver.xml
Mostly comes from my own testdriver I used for manual virt-manager testing.
Add some notes to HACKING about using it.
2013-04-21 13:34:51 -04:00
Cole Robinson
7ae458f1ba virt-install: Error if -c <uri> specified
-c maps to --cdrom for virt-install, but for other libvirt tools like
virsh it maps to --connect.

Handle -c and --cdrom a little differently: if -c contains '://',
error out with an explanation. User can work around it by using
--cdrom. This could in theory break some users, but the change they
make will be backwards compatible.
2013-04-21 12:28:14 -04:00
Cole Robinson
42bfb8fe19 console: s/console-vnc/console-gfx/g
Just for clarity
2013-04-21 12:10:14 -04:00
Guannan Ren
17f43e47fb add a checkbox for cpu host-model mode, remove 'copy' button
If the host-model is selected, disable the cpu model drop down
and features list. They still show what exact configuration the
host-model is using.
For the old libvirt which doesn't support <cpu mode='host-model'/>
virt-manager still copy cpu configs from caps XML to domain XML.

(crobinso: Fix some minor pylint)
2013-04-20 16:07:39 -04:00
Guannan Ren
e941a9e92b cpu: add helper function to reset cpu related variables to none
The helper function aims to reset cpu related vars to none except
<topology>.
It is named with clear_attrs(). clear() could be saved for later use
of clearing all of them including <topology>.
2013-04-20 16:04:55 -04:00
Guannan Ren
15f72a84ab check cpu host-model mode support
UPDATE_CPU flag exists after v0.8.0, so libvirt that
supports HOST_MODEL should support UPDATE_CPU,
the earliest version we are going to check is v0.9.10.
2013-04-20 16:04:43 -04:00
Cole Robinson
3214cec085 manager: Remove duplicate function 2013-04-20 14:23:21 -04:00
Cole Robinson
76936272c7 manager: Fix connection row spacing when VMs are active
I guess the text ordering/expanding piece was causing some weirdness.
2013-04-20 14:14:15 -04:00
Cole Robinson
232c8608c2 manager: Add _build_conn_row function
More consistent with VM function names
2013-04-20 14:14:15 -04:00
Cole Robinson
f1a0b99a38 manager: Make connection rows a bit taller
Closer to what it was like with the gtk2 version
2013-04-20 14:14:15 -04:00
Cole Robinson
77441ea4d4 manager: Tweak VM row indentation 2013-04-20 14:14:15 -04:00
Cole Robinson
bd7c02ce63 manager: Remove unneeded style theming
Even fixing it doesn't really do anything useful.
2013-04-20 14:14:15 -04:00
Cole Robinson
7d328a5c1b Remove todo.txt, it's pretty much done. 2013-04-20 11:42:14 -04:00