Commit Graph

4335 Commits

Author SHA1 Message Date
Cole Robinson
7275da5702 tests: Split out osdict and uriparse from misc.py 2015-04-04 14:43:12 -04:00
Cole Robinson
a7dbc5e250 tests: Add more osdict.py coverage 2015-04-04 14:43:12 -04:00
Cole Robinson
ce73272c7e create: Drop hardcoded STABLE_OS_SUPPORT list
It's out of date, and doesn't even seem to work with current RHEL versions
and no one is complaining.

If we want to add it back, it should be an explicit setup.py configure
option.
2015-04-04 13:48:15 -04:00
Cole Robinson
595b5b4bdf osdict: Drop explicit 'type' class
create.py is the only thing that cares about this nowadays, so we can
work with things to make it all simpler.
2015-04-04 12:48:50 -04:00
Cole Robinson
647420ca90 create: Log results of recommended resources 2015-04-04 12:10:20 -04:00
Cole Robinson
bd9ab2d5b5 osdict: Add toplevel OSDB as API entry point
Makes code more readable, and lazy loading simpler.
2015-04-04 12:06:41 -04:00
Cole Robinson
f644b0997d osdict: Have users call functions, rather than access properties
Gives us more future flexibility, and simplifies the flow quite a bit.
2015-04-04 11:24:18 -04:00
Cole Robinson
710c588eaf guest: Use cached osdict object for all lookups
Rather than have lookup_osdict_key constantly do the dictionary lookup.

This is step one towards simplifying the osdict lazy loading
2015-04-04 11:23:54 -04:00
Cole Robinson
03dbbac806 console: Make API used by vmmDetails explicit
And hide everything else. Similar to what we did with the Viewers, this
should help clarify what the boundaries are here.
2015-04-03 21:34:03 -04:00
Cole Robinson
f589f01665 console: Move viewer classes to viewers.py 2015-04-03 20:54:38 -04:00
Cole Robinson
3b671a9ac3 console: Large amount of internal API tidying
It's very difficult to tell what bits of Viewer that vmmConsolePages
accesses, and what bits of vmmConsolePages that vmmDetails will access.

Clean up the Viewer side with consistent function names, lots of comments,
and privatizing everything that shouldn't be shared.

Yeah this is a big ugly commit...
2015-04-03 20:43:48 -04:00
Cole Robinson
b654db1d17 create: Add aarch64 to the arch priority list
Since it's reasonably well supported now
2015-04-03 17:37:34 -04:00
Cole Robinson
36e46d0276 capabilities: Use _CapsInfo to simplife recommended_machine 2015-04-03 17:37:08 -04:00
Cole Robinson
97259c4d9b capabilities: Store results of guest_lookup together
Simplifies API users lives to not have to remember whether caps guest
or caps domain contains a particular value.
2015-04-03 17:37:08 -04:00
Cole Robinson
81a1910d90 capabilities: Rename no_install_options -> has_install_options
It's easier to visually parse the wording
2015-04-03 17:25:29 -04:00
Cole Robinson
fe9ffe86f6 capabilities: Drop xen-only bios virt checks
These only work for xen x86, and are less relevant nowadays since HW
virt has been around for a very long time. Also it's tough to be sure
that we aren't giving a bogus warning.
2015-04-03 17:25:29 -04:00
Cole Robinson
4e9f70f9b3 Drop all references to kqemu, it's long dead 2015-04-03 16:45:43 -04:00
Cole Robinson
f5b13a6e19 Drop all references to xenner, it's long dead 2015-04-03 16:45:43 -04:00
Cole Robinson
45ae269950 storage: Use XMLBuilder for pool enumerate parsing
And kill the parse_node_helper function, since that paradigm is dead.
2015-04-03 16:45:43 -04:00
Cole Robinson
d4dfbd41b5 capabilities: Use XMLBuilder for cpu_map parsing
And clean up the internal bits a little
2015-04-03 16:45:43 -04:00
Cole Robinson
cac4ac1401 capabilities: Switch to use XMLBuilder
Just a cleanup to finally unify all the XML objects around the same
API, and drop a bunch of old cruft.
2015-04-03 16:45:42 -04:00
Cole Robinson
0492dbc1b1 createpool: Remove some pylint 2015-04-03 15:26:33 -04:00
Charles Arnold
20fe287341 virt-manager: Don't allow an empty string for a network name
When starting the 'Create virtual network' wizard, you are allowed to proceed
without specifying a Network Name.  An error only occurs after all else is
completed with the wizard. This patch stops the user from proceeding if a
network name has not been specified.

The check for an empty string is done in util.py which also effects storage
pool names and guest names neither of which should have empty strings.

Signed-off-by: Charles Arnold <carnold@suse.com>

Message-Id: <551D664702000091000F42E8@prv-mh.provo.novell.com>
2015-04-03 10:49:42 -04:00
Cole Robinson
ce74cd7726 connection: Protect conn state tick() updates with a lock
If the mainloop is backed up, tick_send_signals might not run before
another conn.tick call is scheduled by the tick thread. conn.tick would
then be operating on incorrect self._vms since it was never updated.

Don't run another tick() until tick_send_signals has released a lock.

https://www.redhat.com/archives/virt-tools-list/2015-April/msg00009.html

Reported-by: Charles Arnold <carnold@suse.com>
2015-04-02 14:05:56 -04:00
Giuseppe Scrivano
3ff34c79e2 tests: check that clone keeps the same image format for disks
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-04-02 10:04:58 +02:00
Giuseppe Scrivano
bbb96bcaa8 clone: keep the same image format on a cross-pool clone
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-04-01 11:56:34 +02:00
Cole Robinson
ba527471fc spec: Only pull in gnome-icon-theme on RHEL7 (bz 1207061)
It's the wrong dep on F21+, and it's redundant there anyways. So just
restrict this to RHEL7 where the bug was reported, come RHEL8 time
it likely won't be relevant.
2015-03-30 12:47:39 -04:00
Cole Robinson
82e9684fa6 urlfetcher: Make debian treearch checking more generic
Use regex parsing rather than a whitelist
2015-03-27 13:06:26 -04:00
Mauricio Faria de Oliveira
0dc334fa58 Add ppc64el support for 'virt-install --location' (Debian/Ubuntu)
The installation of Debian/Ubuntu for ppc64el (a.k.a. ppc64le on Fedora/RHEL)
fails with 'virt-install --location', as the arch dir and kernel filename
are not correct for this arch/distros.

This patch fixes it by adding checks for 'treeArch' and 'hvm_kernel_paths'.

Signed-off-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
2015-03-27 12:30:04 -04:00
Cole Robinson
e7666390ff test_inject: Add Fedora 22 URL 2015-03-26 19:37:17 -04:00
Cole Robinson
ba95aa91e6 test_urls: Update fedora URLs 2015-03-26 19:28:53 -04:00
Dustin C. Hatch
7acbdd9bf3 preferences: Correct usbredir preference values
All of the gsettings values of the "prefs-add-spice-usbredir" combo box
result in the preference being set to true, causing all new VMs to have
USB redirection added. This commit corrects the value of the "No" row to
correctly disable the setting when selected.

Signed-off-by: Dustin C. Hatch <dustin@hatch.name>
2015-03-26 19:16:33 -04:00
Cole Robinson
606069b1f4 manager: Use case-insensitive sort for VM names (bz 1155227) 2015-03-26 19:13:29 -04:00
Cole Robinson
b4a7c5e67d virt-manager: Refresh pools after VM/storage is created (bz 1146282)
After the caching changes over the past year, virt-manager's internal state
isn't accurate when virtinst creates new disk storage.

Manually update the pools at the two virtinst entry points: create.py and
addhardware.py
2015-03-26 19:08:04 -04:00
Cole Robinson
6a24eb9d30 createnet: Remove unused module 2015-03-26 18:05:38 -04:00
Cole Robinson
e125aa69d8 nodedev: Handle busted 'system' XML
Libvirt can generated invalid XML for the system nodedev device:

https://bugzilla.redhat.com/show_bug.cgi?id=1184131

This hits at least two people, so catch this specific case, but the
real fix is libvirt not outputing busted XML.
2015-03-26 18:04:23 -04:00
Cole Robinson
af562320a5 createnet: Drop incorrect domain name validation (bz 1195873)
Just let libvirt error if something is wrong
2015-03-26 17:11:23 -04:00
Cole Robinson
dc1737e623 cpu: Drop vendor and features if setting host-model (bz 1190851)
Otherwise via virt-manager we can try to set a <cpu> with a <vendor>
but no <model>, and libvirt complains.
2015-03-26 17:08:15 -04:00
Cole Robinson
2c9d2a2360 virt-install: Don't print virsh command if VM is running (bz 1180558) 2015-03-26 16:43:28 -04:00
Cole Robinson
2f2ab1438f man: Use F21 URL for --location example (bz 1172818)
Because newer fedora has a different URL format
2015-03-26 16:18:25 -04:00
Cole Robinson
87c5094745 details: Don't access console.viewer directly
Add accessors for everything details.py needs. Makes separation clearer
2015-03-26 13:16:50 -04:00
Cole Robinson
26abb5a2b5 console: Drop _has_property
All these checks are redundant with modern deps
2015-03-26 13:10:38 -04:00
Giuseppe Scrivano
0aa200604a addhardware: default to an existing bus when adding a new disk
When a new disk is added, by default choose a bus that is already used
by an existing disk, if any.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1206097

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-26 15:25:16 +01:00
Cole Robinson
7866e291f6 guest: Never use vmvga if host is RHEL (bz 1147662)
We basically need to do this independent of whether the build is configured
for RHEL defaults or not
2015-03-25 09:04:51 -04:00
Cole Robinson
af2aea8bbc tests: xmlconfig: Drop needless version limiting 2015-03-25 08:58:09 -04:00
Cole Robinson
4224772852 netlist: Streamline bridge and macvtap labels (bz 1147660) 2015-03-25 08:47:21 -04:00
Marc Deslauriers
8574eedd2e virt-manager: Don't clear all page visibilities during initialization
Since commit dfa23765, page_changed() sets page visibilities based on the
value of the newpage parameter. Calling the function without it being set
makes all pages invisible at once during initialization, resulting in a
weird scenario which prevents the window from getting proper focus events
when another window partially overlaps it, resulting in stuck grabs.
Message-Id: <55114787.6070401@canonical.com>
2015-03-24 12:36:16 -04:00
Cole Robinson
cfe9e7dc7e virt-install: Make '--cpu none' work with aarch64 2015-03-23 17:46:09 -04:00
Cole Robinson
08a72a4aec connection: Clean up stable_defaults, improve test coverage 2015-03-23 16:49:32 -04:00
Cole Robinson
2a31ff0248 guest: Perform stable_defaults check using our emulator
Not passing an emulator is only for showing ideal defaults in the UI.
When doing internal checks, we only want to disable features if we know
the emulator doesn't support them.
2015-03-23 16:49:32 -04:00