Commit Graph

3407 Commits

Author SHA1 Message Date
Cole Robinson
8bba6b5772 Update translations from RH translators 2013-12-16 19:50:24 -05:00
Cole Robinson
284cbe0000 Pull translations from transifex 2013-12-16 15:53:51 -05:00
Richard W.M. Jones
006fcd3856 guestfs: As virt-manager is multithreaded, don't use an atexit handler.
libguestfs adds an atexit handler to clean up handles on exit.  This
is convenient in single-threaded programs, but causes problems in
multithreaded programs, for example:

https://bugzilla.redhat.com/show_bug.cgi?id=1043520

Disable the atexit handler for all guestfs handles created by
virt-manager.

Note this change requires libguestfs >= 1.20.  However the change to
config.py should ensure that if an earlier version of libguestfs is
installed it should silently fall back to not using inspection.
2013-12-16 12:55:33 -05:00
Cole Robinson
bd5b285eea virt-install: Drop inaccurate comment, update copyright date 2013-12-14 18:28:27 -05:00
Charles Arnold
1124043151 Allow unsafe migrations in virt-manager
Normally, setting cache=none is required in order to ensure a consistent view
of storage between the source and destination migration hosts. However, some
configurations have that quality without resorting to the use of an O_DIRECT
open (which is what cache=none does), and hence cache=none wouldn't be
necessary.

Unfortunately, libvirt is not able to determine on it's own all the
configurations which require cache=none for migration but in the interest of
safety enforces it when it isn't otherwise able to determine migration safety.

For this reason the libvirt api has an 'unsafe' option which allows the user
to override the safety migration checks.

This patch adds a checkbox to allow unsafe migration to the 'Advanced options'
portion of the migration dialog.

Signed-off-by: Charles Arnold <carnold@suse.com>
2013-12-14 12:23:37 -05:00
Cole Robinson
e57cd46904 spec: Require dbus-x11 (bz 1039803)
virt-manager is one of those tools that people will often install when
no traditional desktop is present. dbus-x11 is pulled in by desktop
environments, but not by gtk3 for (presumably) legitimate reasons.
But we need it to do anything worthwhile with dbus.
2013-12-14 12:02:47 -05:00
Giuseppe Scrivano
25723f98ae osdict: append "(or later)" to the last version of an OS
It makes clearer to the user to pick the last version available for an
OS when a newer version is not listed by virt-manager/virt-install.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-06 20:18:28 +01:00
Cole Robinson
2a25c8d37d host: Print iscsi volume key as well in volume list
Suggested here: http://www.redhat.com/archives/virt-tools-list/2013-December/msg00014.html
2013-12-05 09:17:29 -05:00
Cole Robinson
70f1f8df1e storage: Parse volume key 2013-12-05 09:17:12 -05:00
Cole Robinson
c351c8963a storage: Merge duplicate vol list populating 2013-12-04 19:01:52 -05:00
Chen Hanxiao
10d5eb8375 add button to remove cpu feature
We could copy host CPU config by
button 'Copy host CPU configuration'.
If we regret to do this or the host CPU config
caused VM starting failure, we need a button to
help us clear CPU feature.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2013-12-04 18:34:53 -05:00
Giuseppe Scrivano
0abbb6d122 details: show warning when guest inspection fails
If libguestfs fails to inspect the guest then show a warning.

Now the "Operating System" and "Applications" frames are visible
only when the guest inspection is available.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=755869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-03 11:39:27 +01:00
Giuseppe Scrivano
b3131e828e inspection: report guest inspection errors
Add an `error' flag to the inspection data for a guest and set it when
the inspection failed.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-03 11:39:23 +01:00
Cole Robinson
02f3546e02 testdriver: Add <filesystem> examples 2013-12-02 13:47:09 -05:00
Chen Hanxiao
8f661290e3 add RAM filesystems browse support for lxc container
LXC container could use in-memory filesystem,
which do not have source section.
Currently, virt-manager will complain if
dev.source is null.
This patch will fix this issue.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2013-12-02 13:44:17 -05:00
Cole Robinson
a9c42724cd tests: Limit recent clone changes to only very recent libvirt 2013-12-02 13:41:52 -05:00
Giuseppe Scrivano
941350b8ae tests: fix tests with latest libvirt from git
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-02 13:26:31 -05:00
Giuseppe Scrivano
7f3c4cf2f9 virt-manager: correctly initialize the create pool wizard page number
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1034933

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-02 10:45:12 +01:00
Chen Hanxiao
7b9a040249 show read-only check button when add fs for lxc container
Show read-only check button when add fs for lxc container.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2013-11-26 10:08:56 -05:00
Giuseppe Scrivano
e51dd1cf40 capabilities: correctly parse "cpus" in the host NUMA topology
"cpus" might no be the only child element in the "cell" element, so be
sure to check all children.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1032320

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-11-22 13:53:06 +01:00
Cole Robinson
6430065bde virt-manager: Drop semi incorrect comment about dropping stdio/stderr 2013-11-20 14:41:37 -05:00
Cole Robinson
e7ed161f5a support: Use libvirt daemon version correctly
It should be the reference version for all libvirt checks if it exists.

Fixes AUTOSOCKET check for a remote RHEL6 hypervisor for example.
2013-11-19 17:02:51 -05:00
Giuseppe Scrivano
d6fbdf717d virtManager: when present, prefer the user specified in capabilities
Prefer the user specified in the host capabilities to the default one
when checking for the access to disk images.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-11-18 09:05:22 +01:00
Giuseppe Scrivano
d3a6f1a537 virtinst: parse capabilities baselabel element
libvirt since version 1.1.4 shows the security context used to execute
the hypervisor process.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-11-18 09:05:22 +01:00
Cole Robinson
1ffcc0cced urlfetcher: Fix breakage after kernel err report fix 2013-11-10 11:35:22 -05:00
Cole Robinson
bd782d5757 snapshots: Another s/State/VM State/ change 2013-11-10 11:17:12 -05:00
Cole Robinson
de7144d216 create: Don't ask about changing perms if qemu is 'root' user 2013-11-10 11:09:22 -05:00
Cole Robinson
8b42bca801 urlfetcher: Fix error reporting if fetching kernel fails (bz 1017419) 2013-11-09 18:56:09 -05:00
Cole Robinson
8dcb65bd50 create: Fix default qemu-ga setup (bz 1016613)
We were adding default devices before setting the OS value, which qemu_ga
setup depends on.
2013-11-09 18:52:05 -05:00
Cole Robinson
eb33bd34e7 Misc improvements to some debug messages 2013-11-09 18:17:29 -05:00
Cole Robinson
fb3b5a277b snapshots: s/State/VM State/ (bz 1016604) 2013-11-09 18:00:00 -05:00
Cole Robinson
bcfa8d287f serialcon: Release the text console when the VM window is closed (bz 1016445) 2013-11-09 17:54:47 -05:00
Giuseppe Scrivano
5798c5b9b4 virt-manager: prefer os.makedirs to os.mkdir when creating cache dir
Ensure the parent directories exist when attempting to create the
cache directory.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1016435

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-11-05 18:15:11 +01:00
Cole Robinson
395a20edd8 virt-manager: Yet more fixes for DISPLAY unset error
Since these days we have to import Gtk _after_ forking, _and_ Gtk
doesn't raise a nice error for us, we need to postpone dropping stdio
so the user has any chance of seeing the error. Also try to add an
explicit error about DISPLAY again, since we don't get it from Gtk
these days.
2013-11-01 09:48:08 -04:00
Martin Kletzander
30c33ea5cd Fix label at the end of installation
The commit 67c62e68 moved naming of the domain to the last
installation page and this made a placeholder "foobar" appear.
2013-10-29 11:24:52 +01:00
Martin Kletzander
1ac755e7b2 details: Fix processor tab display for some LXC guests
With LXC domain, the 'current' attribute of 'vcpu' element is not
always present, but the code is still depending on it.
2013-10-29 11:24:52 +01:00
Martin Kletzander
2b7aa33887 engine: Fix started libvirt daemon requirement
This patch makes virt-manager usable again without systemd (or dbus).
When started without systemd, but with libvirtd properly working,
there was error reported, and virt-manager didn't even try to connect
to the destination.

This patch modifies the behavior in two ways.  When connection is
added with "do_start=False" it will still try to connect, but won't
error out when unsuccessful.  The second modification is that upon
startup, the idle_connect() function will error out only if we failed
starting libvirtd _and_ we couldn't connect to the uri.  So if we
failed starting libvirtd, but could connect, there is no disruption
for the user.
2013-10-29 11:24:52 +01:00
Giuseppe Scrivano
408771004f virt-manager: show correctly EGD RNG devices information
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:19 +01:00
Giuseppe Scrivano
a7519dc1e9 virt-manager: fix adding EGD RNG devices in UDP mode
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1001773

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:14 +01:00
Giuseppe Scrivano
a832d77559 virt-install: EGD RNG devs need a host to connect to if backend_mode=bind
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:32:06 +01:00
Giuseppe Scrivano
8248331d6c virtinst: allow EGD RNG devices to have both bind and connect sources
Remove backend_mode from VirtualRNGDevice and allow to directly specify
bind and connect sources.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:32:06 +01:00
Giuseppe Scrivano
2a040ccd17 mass update: remove double spaces from comments
Updated by this script:

find -name '*.py' -exec sed -i "s|^\(#.*[^.?\!]\)  \(.*[^#]\)$|\1 \2|g" \{\} \;

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:22:31 +01:00
Giuseppe Scrivano
0df75c7603 headers: update "Red Hat, Inc." copyright for the year 2013
Ensure that any file touched by a @redhat.com author in 2013 has an
updated copyright header.

The files were updated using the build-aux/update-copyright gnulib
script and manually added where the copyright line wasn't present.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:22:26 +01:00
Cole Robinson
2b564f524e Fix a string typo 2013-10-24 14:07:06 +01:00
Cole Robinson
1a88cef3af altlinux doesn't have installable URLs, clarify 2013-10-15 11:21:53 -04:00
Cole Robinson
6673123185 nodedev: Parse PCI iommuGroup 2013-10-10 09:41:49 -04:00
Cole Robinson
2301f19e4b asyncjob: Fix simple error callback 2013-10-09 17:41:08 -04:00
Giuseppe Scrivano
fad01e70fe cliconfig: fix another configuration file parsing problem
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-09 18:02:51 +02:00
Cole Robinson
64b501cdc0 cliconfig: Fix parsing the configuration file 2013-10-08 14:42:59 -04:00
Cole Robinson
cea22b17d7 storagebrowse: Fix signal cleanup after multiple runs 2013-10-08 10:23:15 -04:00