Commit Graph

3825 Commits

Author SHA1 Message Date
Cole Robinson
8fa2aad1d3 createpool: Clarify iscsi IQN fields (bz 1084011) 2014-04-03 11:19:03 -04:00
Cole Robinson
932e6e00bb details: Fix changing graphics type (bz 1083903)
And clean up the API usage to avoid these types of issues in the future.
2014-04-03 10:53:54 -04:00
Cole Robinson
ee6a541167 details: Fix showing vcpus values in 'customize' dialog (bz 1083903) 2014-04-03 10:30:37 -04:00
Cole Robinson
a398d245cb Clean up pylint integration
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
2014-04-02 19:00:24 -04:00
Chen Hanxiao
01718bc408 man: update virt-manager bugreporting URL
Now we use http://virt-manager.org/bugs/ as
bug reporting page.
Although old URL will be redirected to this one,
direct URL would be better.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-01 23:08:30 +08:00
Cole Robinson
adf3545671 connection: Hook into domain balloon event (bz 1081424) 2014-03-31 12:43:49 -04:00
Chen Hanxiao
89c45af26d interface: check ip address format
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-31 22:25:36 +08:00
Cole Robinson
7f802e287c gfxdetails: Show port number for active autoport VM (bz 1081614) 2014-03-30 17:34:26 -04:00
Chen Hanxiao
45d8d4ec85 config: fix a typo
s/authorizaation/authorization

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-30 22:57:21 +08:00
Chen Hanxiao
119025e1ef createinterface: raise value error when no ip addr set
We could set blank ip address

IP setting->Configure->Mode (static), then press "OK".

And libvirt will throw an error not very helpful:
Error creating interface: 'Could not define interface:
XML error: could not get interface XML description:
XML invalid - Element protocol failed to validate attributes.

This patch will forbid setting an empty ip address.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-30 07:47:57 +08:00
Giuseppe Scrivano
5120b90fc3 osdict: lazy load data from libosinfo
I've noticed that virt-manager took more time to startup after we
started reading OSes data from libosinfo.

Now the libosinfo data is loaded the first time it is accessed,
without pre-loading it.

This could be further improved by not loading completely an _OsVariant
object but only the data that is requested.

With the lazy load optimization (best of 10 attempts):

$ echo yes | time ./virt-xml --connect __virtinst_test__test:////home/gscrivano/src/virt-manager/tests/testdriver.xml,predictable --confirm test --edit --cpu host-passthrough > /dev/null
0.13user 0.02system 0:00.22elapsed 74%CPU (0avgtext+0avgdata 26756maxresident)k

Without (best of 10 attempts):

$ echo yes | time ./virt-xml --connect __virtinst_test__test:////home/gscrivano/src/virt-manager/tests/testdriver.xml,predictable --confirm test --edit --cpu host-passthrough > /dev/null
1.26user 0.04system 0:01.36elapsed 95%CPU (0avgtext+0avgdata 57996maxresident)k
0inputs+16outputs (0major+17499minor)pagefaults 0swaps

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-29 21:28:50 +01:00
Chen Hanxiao
58d8795b27 createinterface: set right ip address for ipv6
We use v4_addr for building ipv6 addr.
This patch will use right ip address for ipv6.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-27 22:01:21 +08:00
Giuseppe Scrivano
37eecb215d virtManager: hide "Remove Hardware" for non-devices
The menu item "Remove Hardware" in the Overview window is valid only
when a hardware device is selected, hide it in any other case.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1081373

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-27 13:50:06 +01:00
Giuseppe Scrivano
6c68467be7 virt-manager: update copyright years in the About box
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-26 16:12:13 +01:00
Giuseppe Scrivano
a3e1444a28 osdict: handle libosinfo lookup failure
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-26 16:12:13 +01:00
Giuseppe Scrivano
6b5171031e virt-manager: enable media detection for CD/ISO images
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-26 16:12:13 +01:00
Giuseppe Scrivano
6f52478b19 virtinst: DistroInstaller uses libosinfo detection first
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-26 16:12:13 +01:00
Cole Robinson
9d743ab4c8 snapshots: Tweak warning before run
Make it clear that VM configuration changes will also be dropped if
reverting to a snapshot while the VM is offline.

Suggested-by: Jorge Fábregas <jorge.fabregas@gmail.com>
2014-03-26 08:54:10 -04:00
Giuseppe Scrivano
af216ebaf6 osdict: add new function lookup_os_by_media
"lookup_os_by_media" fetches the OS of the installation media by
querying libosinfo.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-26 10:51:40 +01:00
Marc-André Lureau
c6a48c5123 addhw: fill new char-channel UI
Map values to CharDevice.source_channel.

Set correct channel type and Spice port name for Spice webdav channel.
2014-03-25 17:42:57 -04:00
Marc-André Lureau
2236275d4c addhw: add CharDevice "spiceport" type
Add a new channel type "spiceport".

Adding a new virtio channel of name org.spice-space.webdav.0 connected
to a Spice port with the same name allows the Spice client to share a
folder.
2014-03-25 17:42:57 -04:00
Marc-André Lureau
5882f05e3e addhw: add CharDevice.source_channel
This property maps to channel/source/@channel domain XML.
2014-03-25 17:42:57 -04:00
Marc-André Lureau
2606c1d1b8 ui: add 'channel' to addhardware char panel
Add a 'Channel' entry, to specify the name of a channel (Spice port,
currently).
2014-03-25 17:42:57 -04:00
Chen Hanxiao
e4e39b777d osdict: fix a typo
s/inheiriting/inheriting

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-25 22:34:35 +08:00
Chen Hanxiao
c676f50902 libosinfo: give special emphasis in README
We should emphasize the version of libosinfo
in README.
Virt-manager core dump with libosinfo-0.2.8
on Fedora20.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-25 22:17:41 +08:00
Giuseppe Scrivano
bcb60f0fb1 virt-install: Drop support for --os-variant list
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:42 +01:00
Giuseppe Scrivano
65924171b0 virtManager: by default use the recommended resources to run an OS
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:42 +01:00
Giuseppe Scrivano
2374f8458e osdict: expose libosinfo recommended resources for an OS
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:42 +01:00
Giuseppe Scrivano
db6d001b0e tests: fix to not fail with libosinfo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:42 +01:00
Giuseppe Scrivano
f73c5683c5 virt-manager: add dependency to libosinfo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:42 +01:00
Giuseppe Scrivano
ad0575f731 virtinstall: add some quirks
It also adds aliases for OS names that are different under libosinfo
to maintain backward compatibility.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:42 +01:00
Giuseppe Scrivano
28273e3374 virtinstall: read OSes information from libosinfo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:41 +01:00
Giuseppe Scrivano
517bbad087 virtinstall: allow to redefine typename in _OSVariant
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:41 +01:00
Giuseppe Scrivano
5148f0f1ce virt-install: fix typo in the man page
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:36:13 +01:00
Cole Robinson
8b7ebd4538 Prep for release 1.0.1 2014-03-22 18:38:44 -04:00
Cole Robinson
b49f647e0c details: Fix unsetting autoport values 2014-03-22 18:29:08 -04:00
Cole Robinson
565ef4f3ef connection: Make sure a DEFINED event forces a config-change signal
Even if XML didn't change. This is what we do in the non-event case.
Makes it more clear if details->apply triggers a define, but our
change didn't stick for any reason.
2014-03-22 18:14:43 -04:00
Cole Robinson
1d79667b94 addhw: Remove unused helper function 2014-03-22 18:06:53 -04:00
Cole Robinson
3da3a432e1 details: Fix setting cache/io to hypervisor default 2014-03-22 18:02:50 -04:00
Cole Robinson
f584135b78 gfxdetails: Fix mnemonics to not collide 2014-03-22 17:47:43 -04:00
Cole Robinson
eee5061af8 details: Rework all define and hotplug operations
Rather than register a bunch of functions to call, lump it all into
one function per page. This allows us to easily call UpdateDevice
unconditionally, to pick up any addition hotplug operations that
become available via libvirt and qemu.
2014-03-22 16:48:00 -04:00
Cole Robinson
9050998028 cli: Rename --membacking to --memorybacking
More consistent with the existing --memory option, and the
XML block name.
2014-03-22 12:28:23 -04:00
Cole Robinson
a5b3c1d2f8 guest: Drop back compat hugepage attribute 2014-03-22 12:25:28 -04:00
Cole Robinson
d1749c614d cli: Move hugepages=on example to membacking 2014-03-22 12:19:44 -04:00
Chen Hanxiao
7096c3708e virt-install: Add --membacking option
Add option --membacking for "Memory Backing".

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-22 12:16:24 -04:00
Chen Hanxiao
58a07d04fb remove memoryBacking parameters from --memory
Remove some "Memory Backing" parameters from --memory,
and keep 'hugepages' for backward compatibility.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-22 12:16:24 -04:00
Cole Robinson
8562c3258e More pylint fixes 2014-03-22 11:21:19 -04:00
Cole Robinson
d763126862 Turn off some warnings with latest pylint 2014-03-22 10:01:19 -04:00
Cole Robinson
bc393b5f1f details: Don't try to show machine type for management domain 2014-03-20 14:04:29 -04:00
Cole Robinson
e4c182f39d create: Add some more logging 2014-03-20 14:04:29 -04:00