Commit Graph

4988 Commits

Author SHA1 Message Date
Cole Robinson
467fea9df7 asyncjob: Convert to GtkBox 2016-01-11 14:46:53 -05:00
Lin Ma
21fd079eb1 Replace the unar to more common archivers
Because some of distributions dont provide the unar (universal archiver),
Using more common archivers to replace it.

Signed-off-by: Lin Ma <lma@suse.com>

(crobinso: adjust test suite)
2016-01-10 18:23:29 -05:00
Cole Robinson
9747cd5473 asyncjob: Only show X button if dialog is cancellable (bz 1295418) 2016-01-10 18:04:36 -05:00
Pavel Hrdina
89c3638b63 connection: fix detection that libvirtd is stopped
In case that libvirtd is stopped, we could receive another type of error
from libvirt "libvirtError: internal error: client socket is closed".
This one is usually reported from local connection.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2016-01-08 10:21:42 +01:00
Cole Robinson
35e3bf1715 spec: Replace %define with %global 2015-12-29 12:00:40 -05:00
Cole Robinson
450be4a259 Prep for release 1.3.2 2015-12-24 13:18:32 -05:00
Cole Robinson
437d25f356 spec: Depend on latest vte package vte291
The vte291 package is actually the latest vte with API version 2.91, while
the vte3 package is effectively a compat package with API version 2.90.
virt-manager works fine with either, so pull the latest bits so there's
no ambiguity.
2015-12-24 12:29:46 -05:00
Cole Robinson
0d223e7008 serialcon: Drop the Vte version check
We can work with both the 2.90 and 2.91 APIs no problem, so drop the version
check. The pylint error seems to have disappeared anyways :/
2015-12-24 12:26:08 -05:00
Pavel Fedin
ecf4b3ad40 Prohibit adding PCI host devices to container
libvirt does not allow this and attempt to do so causes error during domain
startup. Prevent this in the beginning instead with correct explanation.

Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
2015-12-24 11:37:59 -05:00
Cole Robinson
33ca0fff7d Only use spice on x86
qemu isn't compiled with spice support for non-x86

Reported-by: Kevin Zhao <kevinzs@linux.vnet.ibm.com>
2015-12-24 11:33:47 -05:00
Cole Robinson
95fd32dffd storage: Avoid some test suite noise on thread cleanup 2015-12-24 11:30:15 -05:00
Cole Robinson
f10bbfe5b3 storagelist: Fix error message for vol delete 2015-12-08 12:44:59 -05:00
Cole Robinson
a28800ae35 Prep for release 1.3.1 2015-12-06 19:36:51 -05:00
Cole Robinson
2b7a119457 engine: Drop handling for old asyncjob nested main loops
Hasn't been needed for a long time
2015-12-06 15:41:49 -05:00
Cole Robinson
f7ae826f0a Fix some gi version errors from pylint 2015-12-06 15:41:49 -05:00
Cole Robinson
febe0abdd2 virt-manager: Drop manual dbusapi, use GtkApplication
So I was confused here and completely missed that GtkApplication is
meant to handle the common case of invoking actions in an existing
app instance. So drop the manual dbus server and use the simpler
Gtk support.

Fix a bunch of other errors in this area too
2015-12-06 15:41:49 -05:00
Cole Robinson
7ef17138da Prep for release 1.3.0 2015-11-24 22:04:26 -05:00
Cole Robinson
d1d202bb1f test_urls: Update and improve an error message 2015-11-24 21:59:26 -05:00
Cole Robinson
8700fda757 urlfetcher: Fix ubuntu url detection with latest libosinfo 2015-11-24 21:59:23 -05:00
Cole Robinson
e13f81a7c5 guest: Add qemu-ga virtio channel for arm
Originally we didn't add this since arm vexpress virtio only had 4
virtio-mmio slots. But the now-common -M virt target has 32 slots,
so we aren't starved.
2015-11-24 19:39:19 -05:00
Cole Robinson
739e31e9b0 console: Fix traceback when switching to fullscreen
Traceback (most recent call last):
  File "/home/crobinso/src/virt-manager/virtManager/details.py", line 1257, in switch_page
    self.console.details_refresh_can_fullscreen()
  File "/home/crobinso/src/virt-manager/virtManager/console.py", line 965, in details_refresh_can_fullscreen
    return self._refresh_can_fullscreen()
  File "/home/crobinso/src/virt-manager/virtManager/console.py", line 464, in _refresh_can_fullscreen
    self.widget("control-fullscreen").set_sensitive(allow_fullscreen)
TypeError: Argument 1 does not allow None as a value
2015-11-24 18:23:36 -05:00
Cole Robinson
a9bc56add3 virt-manager: revive cli dbus API (bz 1162815)
This allows virt-manager command line that launch windows to work for an
existing virt-manager instance. This is handy for scripting, and giving
other apps a reasonable way to launch a virt-manager VM window for
example.
2015-11-24 16:30:18 -05:00
Kothapally Madhu Pavan
f801a7e4ec man: virt-install: Documenting boot_order parameter
virt-install man page doesn't have boot_order documentation.
This patch documents boot_order.

Signed-off-by: Kothapally Madhu Pavan <kmp@linux.vnet.ibm.com>
2015-11-23 14:05:55 -05:00
Cole Robinson
356f30d7ba create: Hide pxe warning if there's no issue 2015-11-21 20:39:55 -05:00
Cole Robinson
6d3b5e2838 cli: Have '--input tablet' default to bus=usb (bz 1232087)
Make the default a little smarter in other ways too
2015-11-21 20:26:50 -05:00
Cole Robinson
2178cc8c93 create: Drop explicit kickstart UI
Few users actually use this, and they can easily do it with the kernel
options field.
2015-11-21 20:21:09 -05:00
Cole Robinson
4f9fd84f8f diskbackend: Use type=file for empty cdrom, not type=block
It doesn't have any operational effect, however since most people use
type=file for cdrom isos, this makes it easier for people to hand edit
the XML.
2015-11-21 20:07:05 -05:00
Cole Robinson
e18d2caa45 create: Don't go back to NewVM on error, if customize dialog launched
The code really isn't set up to handle exiting the customize dialog,
so just make the UI enforce it.
2015-11-21 19:55:48 -05:00
Cole Robinson
778eba5e2a man: virt-xml: Tweak some of the examples 2015-11-21 11:00:17 -05:00
Pavel Hrdina
0ccbcd8883 storage: remove attempt counter from disk allocation thread
Remove the lookup counter from _progress_thread, it's not necessary, the
loop is terminated by _install_finished boolean.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1270277

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-11-19 15:09:59 +01:00
Cole Robinson
e68efe8103 domain: Use setMemoryStatsPeriod for QEMU
Since that's what is required to get cooperative memory stats from
the guest balloon driver.
2015-11-18 21:20:36 -05:00
Cole Robinson
689b0db2c7 fsdetails: Don't sort type list, use the specified order
For LXC we want 'Mount' at the top, not the alphabetical 'Block'
2015-11-18 21:15:53 -05:00
Cole Robinson
c3b5fb407a details: Fix editing filesystem devices 2015-11-18 21:12:35 -05:00
Cole Robinson
71a52300ae systray: Log if we will use AppIndicator 2015-11-18 18:54:17 -05:00
Cole Robinson
cbef4ad84b systray: Fix appindicator icon name (bz 1257949) 2015-11-18 18:48:30 -05:00
Cole Robinson
603fc361bc connect: Fix generated URI for IPv6 addresses 2015-11-18 16:56:41 -05:00
Cole Robinson
3b7366d608 domainnumatune: Remove generate_cpuset helper
This is the function that handled the cpuset=auto old behavior. The last
two commits killed the users, so it's no longer needed
2015-11-18 15:08:24 -05:00
Cole Robinson
d32953d8c6 details: Remove UI for vcpu pinning
This UI exposed the old NUMA allocation policy detailed in the last commit.
It's very much sub-optimal, and should be removed.

Manual cpuset configuration is also quite uncommon and not really something
worth exposing in the UI. It can easily be done from the command line
with virt-xml.

If people complain, I'd consider adding a checkbox for vcpu placement=auto,
or an option to do that by default for new VMs.
2015-11-18 15:05:21 -05:00
Cole Robinson
0d095e22f7 cli: Have --vcpu cpuset=auto use placement=auto
For many years virt-install has supported a bit of logic that maps
--cpuset=auto to a CPU pinning based on host NUMA topology; we look
for a NUMA node who's current free memory is closest to the requested
memory allocation. This isn't very useful though, since it's a one time
allocation, the conditions at VM creation time likely aren't the
conditions of the machine in the future.

Libvirt has supported a smarter option in vcpu placement=auto for a long
while, which will perform a similar operation but at every VM startup.

Convert cpuset=auto to use this functionality instead.
2015-11-18 15:00:54 -05:00
Cole Robinson
492c9c4f28 cli: Add --vcpu placement=static|auto option 2015-11-18 15:00:42 -05:00
Cole Robinson
8189674c8d tests: Add explicit caps test for parsing numa topology
We get this implicitly via --cpuset=auto cli testing, but that's about
to change in upcoming commits
2015-11-18 14:53:28 -05:00
Cole Robinson
e9d5347395 cli: Support --network link_state=up|down 2015-11-18 13:59:15 -05:00
Kevin Zhao
35792f7dd6 Add the console target "sclp" for s390x
Add console target "sclp" for s390x ,since the newest Distro guests has
supported the console target, solve some console issues in s390x.Also
modified the test xml cover this change.

crobinso: fix the test suite output
2015-11-16 19:54:15 -05:00
Chen Hanxiao
908a00cc73 details: show Channel label by device type
Currently we show channel label by its name.
If we use name com.redhat.spice.0 but set it
as unix socket, the label in details keep unchanged.

This patch will set label according to device type
if we failed matching target_name

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2015-11-12 22:53:17 +08:00
Pavel Hrdina
fedf2e7b66 ui: improve pause/resume tooltip
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1238618

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-11-12 13:13:19 +01:00
Pavel Hrdina
3bca4e7fcb Revert "virt-install: fix condition that detect if console is present"
This reverts commit 588c2d4481.

Actually it was correct before this patch.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-11-11 22:07:53 +01:00
Pavel Hrdina
588c2d4481 virt-install: fix condition that detect if console is present
Function get_devices() always returns a list, if there is no requested
device the list is empty.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-11-11 21:25:50 +01:00
Pavel Hrdina
ef14f04226 virt-install: warn user about missing console while installing on arm
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-11-11 21:23:19 +01:00
Cole Robinson
3e049583cc details: Drop ignorePause variable; just block the signals 2015-11-10 18:30:31 -05:00
Cole Robinson
72f83b638d guest: Clarify archs that skip adding the qemu-ga channel 2015-11-10 17:55:55 -05:00