Commit Graph

4679 Commits

Author SHA1 Message Date
Cole Robinson
a91137dbdd engine: Clean up some object lifecycle leaks
pygobject doesn't seem to choke on debug_leak_check anymore, so we
can use it to find object leaks. just doing a few for now since it's
generally not a big deal.
2015-09-20 15:30:00 -04:00
Cole Robinson
b6111b5e85 details: Fix misaligned labels (bz 1264628)
Shows up with different sized translation strings

https://bugzilla.redhat.com/show_bug.cgi?id=1264628

Reported-by: João Pirralha <joaopirralha@gmail.com>
2015-09-20 12:58:23 -04:00
Cole Robinson
d5d6cfff2c Copy urlgrabber progress bar code into virt-manager.git
This is so we can drop the dep on system python-urlgrabber, which will
block us from going to python3.

All we need is like 300 lines from python-urlgrabber for the progress
bar. In reality our needs are much lower, we don't need the fancy
progress bar that urlgrabber provides, but it's nice to have. So if
keeping a copy of this code causes issues in the future, we can probably
come up with something simpler (or hopefully there's a more common
python progressbar impl that we can use at that point).
2015-09-18 20:55:44 -04:00
Cole Robinson
5584863d18 urlfetcher: Switch to requests and urllib2 instead of urlgrabber
urlgrabber is largely dead upstream and isn't going to be ported to
python3 AFAIK. So we will need to move off of it eventually.

Use requests for http handling which is the most common library nowadays,
and just plain old urllib2 for ftp fetching.
2015-09-18 19:50:35 -04:00
Cole Robinson
9a4f15f4ad urlfetcher: Rework early treeinfo lookup
We are duplicating the regex checks which I don't like. So just grab
the treeinfo early, and use that during the main distro lookup
2015-09-18 18:01:57 -04:00
Cole Robinson
b7beb0edb0 urlfetcher: Use python style tempfiles
Simplifies things WRT writing file contents
2015-09-18 17:11:37 -04:00
Cole Robinson
cda3e381e6 urlfetcher: Bunch of small cleanups to the ImageFetcher classes 2015-09-18 17:08:34 -04:00
Cole Robinson
ec166e2cc4 console: Centralize more widget state updating 2015-09-18 13:22:48 -04:00
Cole Robinson
0b881591ec console: Add a separate notebook for serial pages
Rather than the 'offset' page hack we previously did that is hard to
keep track of. This allows for a handful of code simplifications
2015-09-18 12:36:06 -04:00
Cole Robinson
dc61755e8b domain: Don't track xen Domain-0
It doesn't really fit our UI, so blacklist it
2015-09-17 16:06:14 -04:00
Cole Robinson
a9d3cbd6cc connection: Add infrastructure to blacklist failing objects
It happens every now and then that a libvirt bug means calling XMLDesc
on an object will always fail. For example:

https://bugzilla.redhat.com/show_bug.cgi?id=1225771

We don't handle this very well and it can bleed into many other parts of
the code in a bad way. So if the initial polling of the object fails,
blacklist it entirely and ignore it for all future polling.
2015-09-17 15:51:52 -04:00
Cole Robinson
053cda8de7 virt-manager: Add hidden options --test-old-poll and --test-no-events
For easy testing of fallback codepaths
2015-09-17 15:18:22 -04:00
Cole Robinson
b15c44923c capabilities: Handle missing cpu_map.xml
It shouldn't be a fatal issue. Hit on freebsd where they install
libvirt bits into /usr/local

https://www.redhat.com/archives/virt-tools-list/2015-September/msg00056.html
2015-09-16 16:55:37 -04:00
Cole Robinson
5df6757a0b viewers: Use GtkVnc.Display() not GtkVnc.Display.new()
The latter doesn't cause problems on Fedora, but it's currently throwing
errors on Freebsd:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203152
2015-09-16 16:46:39 -04:00
Cole Robinson
5f0433700b connection: Don't immediately encode pretty_name into gconf
Allows the app to change the defaults and users aren't stuck with the
bad names
2015-09-15 19:35:30 -04:00
Cole Robinson
71362cfb7e connection: Tweak pretty_name for Xen connections 2015-09-15 19:30:09 -04:00
Cole Robinson
477e82b35a create: Remove some leftover debug prints 2015-09-15 14:53:10 -04:00
Cole Robinson
bb62a0f7a4 uitests: Add more install tests for arch/machine/virt handling 2015-09-14 19:27:55 -04:00
Cole Robinson
d896dd7347 create: Allow switching between KVM and TCG for armv7l (bz 1214592)
Otherwise we tried to always force KVM which reduces the usefulness
here. We still get the defaults right though

https://bugzilla.redhat.com/show_bug.cgi?id=1214592
2015-09-14 19:27:48 -04:00
Cole Robinson
2fda875072 uitests: Check CPU value in a loop, for robustness 2015-09-14 19:26:26 -04:00
Cole Robinson
1e01395ad9 uitests: newvm: Add basic test case for xen paravirt 2015-09-14 17:01:32 -04:00
Cole Robinson
d661fe7859 createvol: Fix VM name hint setting 2015-09-14 16:29:27 -04:00
Cole Robinson
7953f23975 create: Update storage path in summary when VM name changes
If the name is going to influence the default storage path, update it
as people type
2015-09-14 16:22:17 -04:00
Cole Robinson
4455f7dcb5 create: Use generic helpers for removing already created devices
Simplifies some logic in a few places and makes it clearer IMO
2015-09-14 16:10:42 -04:00
Cole Robinson
a4ddac4bb1 create: Always display the storage path in the summary 2015-09-14 15:22:17 -04:00
Cole Robinson
01da21b93a uitests: Add a basic details.py test
Checks all hw of test-many-devices and make sure an error isn't raised
2015-09-14 14:44:39 -04:00
Cole Robinson
cfd980611a uitests: Add check_in_loop helper function 2015-09-14 12:59:49 -04:00
Cole Robinson
3d9b3528e9 uitests: Separate static methods from DogtailApp 2015-09-14 12:55:04 -04:00
Cole Robinson
3091b2134a test_urls: Use ftp for debian URLs for better FTP testing 2015-09-14 10:35:51 -04:00
Cole Robinson
590f5a525b urlfetcher: Clear cached ftp connection on cleanupLocation
Reported-by: Chun Yan Liu <cyliu@suse.com>
2015-09-14 10:34:19 -04:00
Cole Robinson
ba0711b0bf addhardware: Use same default storage size as create.py (20 GB)
createvol too
2015-09-13 19:32:11 -04:00
Cole Robinson
9f56641b49 addstorage: Tweak labels to be a bit more descriptive
WRT the fact that we aren't just 'browsing' for storage anymore
2015-09-13 19:27:44 -04:00
Cole Robinson
16a744749f addhardware: Drop 'storage format' field
Originally this made sense, as it was the only way to specify a non-default
storage format when creating new storage.

Nowadays the storage browser is a full featured storage manager... and
this field is a bit confusing WRT whether it's used for creating new
storage, or informing libvirt about an existing image's format.

Drop it from the addhardware wizard, and simplify what we show in the
details wizard as well.
2015-09-13 19:13:53 -04:00
Cole Robinson
6861d467a4 addstorage: Clean up validate_storage a bit more 2015-09-13 19:08:30 -04:00
Cole Robinson
a2bd31c2a6 virt-manager: Drop old style config- prefix for widget names
It's redundant and we haven't followed that pattern for a long while
2015-09-13 18:01:39 -04:00
Cole Robinson
c558bb1f56 addstorage: Move validate_storage error catching to the caller
Saves some code indentation, and is more robust
2015-09-13 16:02:35 -04:00
Cole Robinson
4b5e65fe8d details: Remove iotune UI
This is a little low level and rarely used IMO to have it in the UI.
If people want to edit this we should point them at virt-xml which
seems like the appropriate user friendlyness for this feature.
2015-09-13 15:54:47 -04:00
Cole Robinson
15a6a7e210 addstorage: Drop explicit sparse option
This made more sense when raw was the disk image default, but nowadays
we use qcow2 which doesn't even support non-sparse, so the UI is always
disabled.

If the user changed their preference to raw, it still doesn't make much
sense to show the option, since they are likely using raw for performance
in which case they are going to want to preallocate anyways.

So just default to sparse=False. If users want to override it, they can
do it via custom created storage.
2015-09-13 15:43:24 -04:00
Cole Robinson
a51c12660f setup: Do pep8 before pylint
pep8 is super quick, so if there's issue devs can fix those while pylint
is running and gives exhaustive output
2015-09-13 15:07:23 -04:00
Cole Robinson
bcc13dca31 virt-manager: Only save window dimensions on app exit (bz 1262561)
Rather than on every window change event which spams dconf and hits
the disk repeatedly. The new method is roughly what is suggested by
https://wiki.gnome.org/HowDoI/SaveWindowState

https://bugzilla.redhat.com/show_bug.cgi?id=1262561
2015-09-13 14:07:43 -04:00
Cole Robinson
b95af3bedc create: Privatize more variables 2015-09-13 12:45:35 -04:00
Cole Robinson
241c3125e5 create: Drop redundant _have_startup_error
Isn't needed in the modern code
2015-09-13 12:28:16 -04:00
Cole Robinson
ddea18baf9 create: Cleanup of distro detection code
- Use better variable names
- Lots of comments
- Streamline various parts
2015-09-13 12:28:16 -04:00
Cole Robinson
38a8454941 create: Organize code better
- Privatize a bunch of functions
- Rename functions to make their purpose cleared
- Document some functions
- Group functions into logical groups and use comment blocks to separate them
2015-09-13 12:28:16 -04:00
Cole Robinson
0dc74d6409 uitests: Use Centos5.5 URL for tests instead of fedora
Modern fedora + initrd are much larger, so take longer to download
2015-09-13 12:15:11 -04:00
Cole Robinson
d9356025ff uitests: Always disable dogtail file logging, we never want it 2015-09-12 14:25:25 -04:00
Cole Robinson
8ffcfccb5c uitests: Fix them once again
The pylint fix broke things... apparently dogtail advertises one
function signature but then calls it without any arguments...
2015-09-12 14:25:25 -04:00
Cole Robinson
3730c31b40 console: Fix some issues with reconnecting to the viewer
Regressed with my recent console rework bits
2015-09-12 12:07:56 -04:00
Charles Arnold
360fe11040 virtinst: correctly find the sles s390x kernel and initrd
Allow virt-install to correctly find the SLES kernel/initrd on the media
when installing an s390x VM.

Signed-off-by: Charles Arnold <carnold@suse.com>

(crobinso: fix minor pep8 issues)
2015-09-11 12:48:52 -04:00
Cole Robinson
7773a045f8 uitests: Fix some pylint 2015-09-11 12:03:38 -04:00