shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-07 17:18:00 +03:00
Code Issues Projects Releases Wiki Activity
6,091 Commits 2 Branches 64 Tags 98 MiB
b882dbde9c
Commit Graph

6091 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andrea Bolognani
b882dbde9c tests: Add some tests for virt-xml with KVM 
We're mostly interested in how the default bus/model for
devices are influenced by knowledge about the guest OS, but
since the whole thing requires to be connected to the QEMU
driver we might as well create a new category and leave room
for more QEMU-specific tests being added down the line.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
 2018-11-13 12:11:09 +01:00
Andrea Bolognani
ade53764fc virt-xml: Accept --os-variant option 
We're not doing anything with it yet, but having the
parser accept it means we can write tests and see how
their output changes once we wire it up in earnest.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
 2018-11-13 12:08:46 +01:00
Andrea Bolognani
751fb88c58 virt-install: Add "Guest OS" options group 
The --os-variant option doesn't quite fit perfectly into
its current "Installation method" group, plus we want to
add the same option to virt-xml which can't have that
group for obvious reasons.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
 2018-11-12 16:15:33 +01:00
Andrea Bolognani
a550a95727 virt-install: Fix description for --os-variant 
Since we're messing with it either way, might as well use
modern OS names as examples.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
 2018-11-12 16:15:33 +01:00
Radostin Stoyanov
f53e5b024d progress: Remove commented out code 
Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
45d76ccadd progress: Resolve protected-access 
Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
0505f2be3d progress: Resolve E226 
E226: missing whitespace around arithmetic operator

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
48255ea584 progress: Don't use black-listed name 'bar' 
Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
6a66d8cce0 progress: Resolve E502 
E502: the backslash is redundant between brackets

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
5e6b73d439 progress: Resolve E501 and E305 
E501: line too long (82 > 79 characters)
E305: expected 2 blank lines after end of function or class

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
e7a3a55f2d progress: Resolve E231 
E231: missing whitespace after ‘,’, ‘;’, or ‘:’

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
a7254aa006 progress: Resolve E129 
E129: visually indented line with same indent as next logical line

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
19b3d2ac66 progress: Resolve E714 
E714: test for object identity should be ‘is not’

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
6d125cca72 progress: Resolve E265 
E265: block comment should start with ‘# ‘

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
3468a2ec1f progress: Resolve E722 
E722: do not use bare except, specify exception instead

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
c3453422f2 progress: Resolve E261 
E261: at least two spaces before inline comment

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
cd1a46c2ae progress: Resolve E701 
E701: multiple statements on one line (colon)

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
9a472f506d progress: Resolve E221 
E221: multiple spaces before operator

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
ed98a29dda progress: Resolve E302 
E302: expected 2 blank lines

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
b7c7c27f7c progress: Resolve W0201 
W0201: Attribute %r defined outside __init__

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov
5b1f6ad2b8 pylint: Don't exclude progress.py 
Currently progress.py file was excluded from pylint/pycodestyle check
because the code was straight from python-urlgrabber and it was not
PEP8 compliant. The following patched resolve the code style issues.

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Martin Kletzander
9308bae310 util: Fix typo vpcu -> vcpu 
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
 2018-10-22 15:05:30 +01:00
Cole Robinson
25b8873340 urldetect: Don't overload suse_content variable 
Use an explicit check_for_suse_content variable rather than
stuffing -1 into suse_content
 2018-10-18 17:16:14 -04:00
Cole Robinson
49f469a034 test_urls: Always check for distro value 2018-10-18 13:43:12 -04:00
Cole Robinson
cd122b9387 test_urls: Drop dead code 
This is solved by the "testsuite-fedora-rawhide" hack
 2018-10-18 13:36:16 -04:00
Cole Robinson
fe9aa7085b test_urls: Add kernelregex= option 
For verifying detected kernel paths. Add a few basic examples. I
will use this in my local iso test suite for checking debian
iso vs http-iso case
 2018-10-18 13:21:44 -04:00
Johannes Tiefenbacher
b8aff28087 virtinst: quickfix ubuntu net-preseed insert cdrom error 
the proper kernel/initrd pair for booting from an http server is found in install/netboot/... on a mounted ubuntu iso.
this last worked in v1.4.2

Discussion: https://github.com/virt-manager/virt-manager/pull/34

(crobinso: add the fetcher.is_iso handling and add a comment)
 2018-10-18 13:21:41 -04:00
Cole Robinson
943f1d4bc2 Prep for release 2.0.0 2018-10-15 08:34:18 -04:00
Cole Robinson
e127d5e269 tests: inject: use qemu system, not session 
system will give us vol upload coverage
 2018-10-14 19:06:06 -04:00
Cole Robinson
1b24ce455c tests: urls: Update for latest osinfo data 2018-10-14 17:09:48 -04:00
Cole Robinson
369cf6774b guest: Don't add spicevmc channel if virtio not supported 
Not that big of a deal for linux guests, but will add ?
devices on windows
 2018-10-14 12:29:33 -04:00
Cole Robinson
9be5fec593 tests: inject: fix some pylint 2018-10-13 17:54:07 -04:00
Cole Robinson
b051b6c95d cpu: Have host-copy use domcaps if qemu is new enough (bz 1637767) 
capabilities is known problematic. Use domcaps if libvirt+qemu
reports working host-model

https://bugzilla.redhat.com/show_bug.cgi?id=1637767
 2018-10-13 17:48:25 -04:00
Cole Robinson
535e34481d libvirtobject: Add is_X object type helpers 2018-10-13 17:23:18 -04:00
Cole Robinson
d39b7d1079 details: Fix launching wrong window for duplicate VM name (bz 1630220) 
https://bugzilla.redhat.com/show_bug.cgi?id=1630220
 2018-10-13 17:16:21 -04:00
Cole Robinson
6e00d816c7 preferences: Fix some mnemonics (bz 1630217) 
https://bugzilla.redhat.com/show_bug.cgi?id=1630217
 2018-10-13 17:05:21 -04:00
Cole Robinson
2ba48539ea tests: Regenerate with osinfo-db git 2018-10-13 16:33:37 -04:00
Cole Robinson
f102d2a256 tests: inject: use virt-install, not direct API 
Simplifies the code and gives us actual command line coverage,
but requires a small hack to work correctly for modern
centos/fedora test cases, inst.repo from --location takes
precedence over our kickstart URL
 2018-10-13 16:31:04 -04:00
Cole Robinson
e212ce84e6 installer: extraargs -> extra_args 
Better matches what's on the command line
 2018-10-13 16:29:32 -04:00
Cole Robinson
4ae24802d7 installer: Fix --initrd-inject 2018-10-13 15:51:38 -04:00
Cole Robinson
cec5fdeabe addhardware: Fix some pylint 2018-10-13 15:34:09 -04:00
Cole Robinson
30448f3c81 tests: uitests: Add click() wrapper 2018-10-13 15:33:44 -04:00
Cole Robinson
edab908f42 guest: Use q35 chipset by default for new qemu + supported OS 
There's been various discussions about changing the x86 default
from 'pc' to 'q35' over the years, but it's unlikely to happen
at the qemu or libvirt level for compatibility reasons. So
let's start using it for new enough OS that support it.
 2018-10-13 14:58:57 -04:00
Cole Robinson
a00152d72a manager: fix some --test-leak-debug issues 2018-10-13 14:27:10 -04:00
Cole Robinson
0cbb420347 virt-install: Limit --os-variant warning to kvm+x86 
As that's really all that libosinfo defaults presently matter for
 2018-10-13 12:55:34 -04:00
Cole Robinson
570e6bbb29 tests: add osinfo net fallback test 
using openbsd4.9 with its pcnet recommendation
 2018-10-13 12:40:22 -04:00
Cole Robinson
452f5286cd addhardware: Don't show pci-bridge devices 
These aren't assignable
 2018-10-13 12:38:06 -04:00
Cole Robinson
c23a0d4c96 nodedev: add is_linux_root_hub helper 
Move the check out of connection.py, and simplify the addhardware
code
 2018-10-13 12:18:50 -04:00
Cole Robinson
467c524684 tests: Add show_nographics_warnings coverage 2018-10-13 11:50:49 -04:00
Cole Robinson
41d0f8fdf1 installer: Order install CDROM before any manual CDROMs 
This is important for the virtio-win case: --cdrom media should
always be ordered first, so it's the boot preference.

https://www.redhat.com/archives/virt-tools-list/2018-September/msg00048.html
 2018-10-13 10:44:09 -04:00