Cole Robinson
bc232eb8de
devices: disk: Drop DIR+floppy validation
...
Libvirt already gives us a similar warning at parse time, this is
obscure enough that we don't need to catch it upfront
2019-06-05 11:13:33 -04:00
Cole Robinson
08b26e9b1c
devices: disk: Add tests for missing _storage_backend
2019-06-05 11:13:33 -04:00
Cole Robinson
f22a0ec2e4
xmlbuilder: Add replace_child
...
This will be used for UI XML editing of devices
2019-06-05 11:13:33 -04:00
Cole Robinson
5e7322edca
libvirtobject: Make _redefine overrides more clear
2019-06-05 11:13:33 -04:00
Cole Robinson
78526aea74
man: virt-install: mention <iothreadids> too
2019-06-04 14:17:45 -04:00
Athina Plaskasoviti
27a51b2210
cli: Add --iothreads iothreadids.iothread[0-9]*.id
...
XML Mapping:
<domain>
...
<iothreadids>
<iothread id="X"/>
...
</iothreadids>
...
</domain>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-06-04 14:17:01 -04:00
Cole Robinson
fe20c4c96e
man: virt-install: Document --iothreads
2019-06-04 10:58:31 -04:00
Athina Plaskasoviti
8c708210db
cli: Add --iothreads
...
XML Mapping:
<domain>
...
<iothreads>X</iothreads>
...
</domain>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-06-04 10:58:31 -04:00
Athina Plaskasoviti
304b323f5d
cli: Fix add --memballoon stats.period
...
XML Mapping
<memballoon model=...>
<stats period="10"/>
</memballoon>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-05-29 14:03:14 -04:00
Athina Plaskasoviti
5b443fd383
cli: Fix --memballoon autodeflate
...
Fixing commit ebf2199875
XML Mapping:
<memballoon model="virtio" autodeflate="on"/>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-05-28 17:32:58 +02:00
Athina Plaskasoviti
ebf2199875
cli: Add --memballoon autodeflate
...
XML Mapping:
<memballoon model=...>
<autodeflate>on</autodeflate>
</memballoon>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-05-23 10:03:27 -04:00
Pavel Hrdina
06c2f87397
cli: fix cpu secure option to actually work
...
The 'secure' option is processed after the model is already set.
CPU security options are resolved while setting CPU model so we need
to know the 'secure' option value before we set the CPU model.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2019-05-22 16:40:54 +02:00
Pavel Hrdina
abda575e48
tests: include CPU security features in kvm q35 domcapabilities
...
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2019-05-22 14:09:59 +02:00
Athina Plaskasoviti
35c53fc02c
cli: Add --disk rawio
...
XML mapping:
<disk type=... rawio="yes">
...
</disk>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
2019-05-20 15:32:04 +02:00
Cole Robinson
0b4c6dd066
addhardware: tpm: select version 2.0 by default
...
The full default selection of CRB + version 1.2 is explicitly
rejected by libvirt. Select version 2.0 by default so it has
a chance of working
2019-05-17 15:57:53 -04:00
Cole Robinson
2b49fae921
details: Align cpu model combo left
2019-05-17 15:35:41 -04:00
Athina Plaskasoviti
d171489f7d
cli: Add --disk wwn
...
XML mapping:
<disk>
<wwn>...</wwn>
</disk>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-05-17 15:29:18 -04:00
Cole Robinson
0366eb15e2
docs: Multiple updates
...
* Renaming HACKING.md to CONTRIBUTING.md, special github naming
* Point to modern virt-manager.org bug link
* Mention option to use github issue tracker
* Point to the github wiki for more contribution docs
* Many minor updates
2019-05-16 16:31:27 -04:00
Cole Robinson
d50187e65c
setup: Make codespell an optional part of the 'pylint' target
2019-05-16 14:43:31 -04:00
Cole Robinson
bc4573a14b
Fix codespell errors
2019-05-16 14:43:31 -04:00
Cole Robinson
de59d33a59
tests: clitest: Move all skip checks into their own class
2019-05-16 14:24:20 -04:00
Cole Robinson
4e3e38cad1
tests: Fix test suite failures on f29 libvirt 4.7.0
2019-05-16 11:29:12 -04:00
Cole Robinson
6394ab7f9a
cli: --graphics: Add zlib.compression=
...
This maps --graphics zlib.compression=auto to the XML:
<graphics>
<zlib compression='auto'/>
</graphics>
2019-05-16 10:21:19 -04:00
Cole Robinson
aeff4e248f
tests: Fix testsuite on non-latest libvirt
...
The memory hotplug changes only work on libvirt 5.3.0, among a few
other pieces. Still do the XML compare but skip domain define if
the new check_version_define comparison fails.
2019-05-15 20:19:58 -04:00
Cole Robinson
cee7ae8711
cli: --network: Advertise old style network= and bridge= options
2019-05-15 18:29:19 -04:00
Cole Robinson
53c7978ef5
cli: --disk: Don't try to detect path opt collisions
...
The checking is hard to get right because there are many ways to
specify storage. Rework it to try to determine if we should
create storage from disk XML contents
2019-05-15 18:25:19 -04:00
Cole Robinson
4d5f6951a2
man: Don't document broken --controller virtio-scsi
...
AFAICT this has never worked.
2019-05-15 18:00:24 -04:00
Cole Robinson
f5c5c815e4
cli: Add --seclabel alias for --security
...
The <domain> XML it alters is called <seclabel>, and security is
really generic sounding. Add the alias and switch the documentation
over to prefer --seclabel
2019-05-15 17:49:58 -04:00
Cole Robinson
656045478d
tests: Verify all cli subopts and aliases are triggered
...
Add some cli infrastructure and testsuite magic to track whether
a cli suboption and cli alias is triggered. This makes it harder
to accidentally add cli option regressions.
We make some exceptions for shared options, requiring them to only
be tested once, otherwise trying to test all address options for
every device will be a giant pain.
2019-05-15 17:45:19 -04:00
Cole Robinson
23f7b4fa7e
tests: clitest: Cover all address.* options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
7eedcac1e7
tests: clitest: Cover all char options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
2b613d2ef5
tests: clitest: Cover all --rng options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
65f3197a02
tests: clitest: Cover all --vcpus and --video options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
cc6ca85ce8
tests: clitest: Cover all --network options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
e2e9c0cadd
tests: clitest: Cover all --sysinfo options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
a8fedab9f2
tests: clitest: Cover all --memdev options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
d5c7771e49
tests: clitest: Cover all --graphics options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
56f47faf49
tests: clitest: Cover all --features options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
4543ef2baa
tests: clitest: Cover all --disk options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
0947045f11
tests: clitest: Cover all --cpu options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
58daf6722e
tests: clitest: Cover all --controller options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
5f5c7daca1
tests: clitest: Cover all --clock options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
f986273e17
tests: cli: Cover all --hostdev options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
fa8cbe5628
tests: clitest: Cover all --memorybacking options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
0da94e25b2
tests: clitest: Cover all --blkiotune and --idmap aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
dbb6f338ab
tests: clitest: Cover all --vsock options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
084122dfbe
tests: clitest: Cover all --tpm options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
0b2206be0e
tests: clitest: Cover all --pm and --numatune options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
300400f26c
tests: clitest: Cover all --boot options and aliases
2019-05-15 17:34:01 -04:00
Cole Robinson
dc0f9632ee
tests: Repurpose spice-gl test as a generic singleton test
...
We need another entrypoint for singleton testing
2019-05-15 17:34:01 -04:00