shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-25 23:21:45 +03:00
Code Issues Projects Releases Wiki Activity
5,602 Commits 2 Branches 64 Tags 98 MiB
befafe9dc7
Commit Graph

5602 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Cole Robinson
950e8803bc config: Explain and simplify our gsettings wrapper a bit 2018-01-09 17:41:20 -05:00
Cole Robinson
09dd1596e2 uitests: Add preferences dialog tests 2018-01-09 17:41:20 -05:00
Cole Robinson
c073fc2a7e ui: about: Bump copyright year 2018-01-09 17:41:20 -05:00
Cole Robinson
7a12899b44 uitests: Add test for 'about' dialog 2018-01-09 17:41:20 -05:00
Cole Robinson
61158d3bce config: Use memory backend with --test-first-run 
Meaning we start with a blank slate of gsettings data, and never
save anything to disk.
 2018-01-09 17:41:20 -05:00
Cole Robinson
4b4f532417 uitests: Wire up --coverage 
Need to launch the external coverage process to actually measure
things
 2018-01-09 13:51:53 -05:00
Cole Robinson
b4a2c46f6a virt-manager: If --connect passed, wait for it to init 
...before showing the UI. This helps the UI test suite be less
racy at least.
 2018-01-09 13:51:53 -05:00
Cole Robinson
0c615497b1 uitests: Drop sleeps from newvm tests 
Adds a few new uiutils options to facilitate watching for the expected
result, rather than depending on hardcoded sleeps
 2018-01-09 13:51:53 -05:00
Cole Robinson
4fbffc4086 uitests: Drop redundant sleeps 
All these cases have sleep+backoff built into the dogtail logic,
so we don't need to manually sleep
 2018-01-09 12:04:49 -05:00
Cole Robinson
8030e0a35c uitests: Centralize app shutdown 
Try a graceful shutdown, wait for app to respond, before trying SIGKILL.
 2018-01-09 12:04:43 -05:00
Cole Robinson
acfd59f22b uitests: Split out UITestCase class 2018-01-09 10:06:26 -05:00
Cole Robinson
ab1b4f8628 virt-manager: Gracefully exit app on ctrl-c, not sys.exit 
Will be needed for uitests coverage support
 2018-01-09 09:57:20 -05:00
Cole Robinson
044d93d471 tests: Rework how we pass command line objects down to test data 2018-01-08 17:05:55 -05:00
Cole Robinson
89945118df uitests: Make unittest.installHandler work as expected 
And ctrl-c exiting in general.
 2018-01-08 09:21:42 -05:00
Cole Robinson
cf165241a1 tests: Force verbose mode for UI tests 2018-01-08 09:21:42 -05:00
Cole Robinson
6009044463 tests: Don't always generate coverage data 
We were doing this unconditionally, and on my laptop it seems to be
responsible for about 20% of the runtime... whoops!
 2018-01-08 09:21:42 -05:00
Pavel Hrdina
bc8c5b0778 cli: append "--attach" to virt-viewer if graphics has listen type none 
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1527834

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2018-01-07 08:59:43 +01:00
Cédric Bosdonnat
1c3e32553e Unify invisible_char values 
To be consistent across the UI, change the few remaining different
invisible_char values to match the most common one.
 2018-01-06 17:21:35 -05:00
Cédric Bosdonnat
50fd011153 oscontainer: ask root password in the wizard 
When creating a new root file system out of an downloaded image,
the root password is likely to be changed. Add a field for this
in the new guest wizard.
 2018-01-06 17:21:35 -05:00
Cédric Bosdonnat
03e827b24b Improve container image url examples 
Replace the docker://fedora placeholder by a tooltip that shows more of the
possible values (taken from virt-bootstrap's man page). Finding an image
that has a /sbin/init on the docker hub is rather hard, better remove
the misleading value.
 2018-01-06 17:21:35 -05:00
Lin Ma
c4c78d2894 details: Show attached disk information in scsi controller page 
It helps users to recognize controllers <-> disks mapping relationship.

Signed-off-by: Lin Ma <lma@suse.com>
 2018-01-06 16:40:30 -05:00
Lin Ma
12c5945be0 details: Disallow removing the scsi controller if disks attached to it 
Through virt-manager, After we removed a virtio-scsi controller which
virtual disks still attach to it, Libvirt will add a LSI scsi controller
for this guest automatically and trigger a lifecycle event, virt-manager
updates and shows this new scsi controller in details panel once it got
the lifecycle event.

It may confuse user that a LSI scsi controller occurs while one removes
the virtio-scsi controller.

This patch prevents removing a scsi controller if any disks attaching to
it.

Signed-off-by: Lin Ma <lma@suse.com>
 2018-01-06 16:40:30 -05:00
Lin Ma
066b91b2a0 ui: details: Add ui for showing attached controller devices in the future 
Signed-off-by: Lin Ma <lma@suse.com>
 2018-01-06 16:40:30 -05:00
Lin Ma
2c06086495 details: Rename the variable 'dev' to 'controller' in refresh_controller_page 
Use the more appropriate name for more correctly identifies controllers.

Signed-off-by: Lin Ma <lma@suse.com>
 2018-01-06 16:01:54 -05:00
Lin Ma
75eb62fdb1 virtinst: Add pretty_desc function for device address printing 
Signed-off-by: Lin Ma <lma@suse.com>
 2018-01-06 16:01:49 -05:00
Lin Ma
65db33fec0 virtinst: Add a compare_controller function for future use 
Signed-off-by: Lin Ma <lma@suse.com>
 2018-01-06 16:01:45 -05:00
Cole Robinson
0198db6d3f tests: cli: Skip iso test if isoinfo isn't installed 2018-01-06 15:08:23 -05:00
Cole Robinson
fe04438832 spec: Add dep on genisoimage, for isoinfo 2018-01-06 14:18:19 -05:00
Cole Robinson
c727db2380 tests: Drop --skipcli option 
cli tests are much faster nowadays, this option isn't all that useful
 2018-01-06 14:04:34 -05:00
Cole Robinson
c9ca8ab7ce tests: test_urls: Simplify adding in local tests 
I'll use this to scoop up local ISOs for comprehensive testing
locally.
 2018-01-06 14:04:34 -05:00
Cole Robinson
c7ed34de63 tests: test_urls: Big rework 
Move all the test cases to an .ini file. Various cleanups and
minor improvements throughout
 2018-01-06 14:04:34 -05:00
Cole Robinson
26046c5948 urlfetcher: Fix detection with latest ALT media 2018-01-06 14:04:34 -05:00
Cole Robinson
a183031793 urlfetcher: More debian CD arch handling 2018-01-06 14:04:34 -05:00
Andrew Wong
a7aa02ffa9 virtinst: Use isoinfo to extract files from ISOs and block devices 2018-01-06 14:02:11 -05:00
Cole Robinson
23c9dd3ee7 tests: clitest: Add an actual stub iso for --location testing 
And add an explicit nfs URL test
 2018-01-06 14:01:44 -05:00
Chen Hanxiao
3e3ffe1e2d pylint: remove a unnecessary pass 
pylint complains:
  Unnecessary pass statement (unnecessary-pass)

Reviewed-by: Pavel Hrdina <phrdina.redhat.com>
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-12-22 21:48:35 +08:00
Cédric Bosdonnat
0c6bcb0917 python3: fix bytes/string mess in serial console 
Add a few encode() and decode() to convert between libvirt stream
functions expecting bytes arrays and Vte callbacks providing strings.
 2017-12-20 16:09:35 -05:00
Cole Robinson
b5b2433ad5 baseclass: Fix UI file loading on py3 
We were passing in a unicode string object, but add_from_string
depends on knowing binary length. This caused signals to not
be registered which broke reopening the details window

Just switch to add_from_file to sidestep the issue
 2017-12-20 16:04:36 -05:00
Cole Robinson
c174b5509f connection: Another py3 exception variable fix 2017-12-20 14:16:13 -05:00
Cédric Bosdonnat
60968fa259 py3: store exception variables for use outside except 
In python3 exceptions aren't defined outside the except block. Leading
to 'UnboundLocalError: local variable 'e' referenced before assignment'
errors.

To work around this, store the local variable into one that will have a
longer life.
 2017-12-20 14:13:27 -05:00
Anthony
ca3c3a5869 ui: create: fix bootstrap typo 2017-12-20 14:02:55 -05:00
Scott Garfinkle
249ff1ed36 virtio-scsi by default on power 
Power architecture guests should default to virtio-scsi rather than spapr-scsi

Signed-off-by: Scott Garfinkle <scottgar@linux.vnet.ibm.com>
 2017-12-20 13:30:45 -05:00
Lin Ma
08b2b808bd addhardware: Remove IDE from list while adding controllers 
Libvirt only supports built-in IDE controller so far, There is no
any case that needs us manually add an IDE controller, So remove
it from the controller list.

Signed-off-by: Lin Ma <lma@suse.com>
 2017-12-20 13:15:46 -05:00
Pavel Hrdina
f3f9dd6b73 virtinst.support: fix copy&paste error 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-12-18 19:18:31 +01:00
Cole Robinson
4224b0926e tests: Remove storage UUID hackery 
In several cases we were trying to define two different pools with
the same UUID. Libvirt used to accept that but as of a recent
commit it started rejecting it for the test driver.

The UUID stuff isn't adding anything so drop it from all the test
cases and data.
 2017-12-14 12:45:01 -05:00
Cole Robinson
fe59c33772 virtinst: storage: Don't generate UUID by default 
Just let libvirt do it for us, it doesn't really add anything
 2017-12-14 12:45:01 -05:00
Cole Robinson
c286593b56 virtinst: network: Don't generate UUID by default 
Just let libvirt do it for us, it doesn't really add anything
 2017-12-14 12:45:01 -05:00
Cole Robinson
8b4befae60 virtinst: Drop UUID validation 
It's redundant as libvirt will give us these checks already, and we
aren't even testing it
 2017-12-14 12:45:01 -05:00
Cole Robinson
5ac933e98a guest: Set default rendernode= if spice gl requested 
Since this is required to work out of the box with qemu:///system
 2017-11-25 17:29:02 -05:00
Cole Robinson
bd1c6e55ad gfxdetails: Select rendernode by default when user requests gl=on 
Since it's required for qemu:///system to work
 2017-11-25 17:28:57 -05:00