Cole Robinson
cff08223ba
util: Move uri_split to its own URISplit class
...
Does what uri_split did, but wraps it all up in an object that makes
handling the data easier, and makes it easy to extend.
2014-12-09 08:43:19 -05:00
Cole Robinson
81009caa54
tests: clitest: Drop explict readonly file testing
...
This was originally to hit certain code paths in virtinst that are long
gone, and was causing issues for running the test suite in certain
situations:
http://www.redhat.com/archives/virt-tools-list/2014-December/msg00010.html
2014-12-09 07:13:27 -05:00
Chen Hanxiao
9e6eaf5d18
virt-clone: improve some error prompts
...
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-09 16:10:35 +08:00
Chen Hanxiao
802e57ea5e
diskbackend: fix some comment typos
...
s/if/If
s/a/an
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-09 15:53:21 +08:00
Cole Robinson
00957db6e0
devicedisk: Clarify _xmlpath
2014-12-07 10:08:33 -05:00
Cole Robinson
cd305da3f8
virt-install: support network --disk's
...
Handle type=network in devicedisk.py, and wire up all the network fields
for virt-install --disk. Right now it requires manually spelling out
all the protocol, name, host/port etc fields.
The one 'magic' bit is that VirtualDisk.path will be a pretty URL when
all those network fields are specified. This is keeps things mostly
working in various parts of the code where we expect 'path' to be an
identifier for a VirtualDisk.
2014-12-06 21:00:51 -05:00
Cole Robinson
c5f5827499
tests: xmlparse: Simplify disk lookup
2014-12-06 21:00:07 -05:00
Cole Robinson
0f6fddf610
devicedisk: Simplife get_xmlpath
...
Rather than deal with hacks, just read the backing paths and return
the first hit
2014-12-06 17:29:05 -05:00
Cole Robinson
86682c8c54
virt-install: Support --disk source_pool,source_volume
...
For setting type=volume disks. This requires some reworking of
devicedisk bits
2014-12-06 17:14:16 -05:00
Cole Robinson
9b62c2260d
devicedisk: Catch --disk /dev/idontexist,size=2
2014-12-06 16:44:21 -05:00
Cole Robinson
52691c511e
devicedisk: Move more validation into diskbackend
2014-12-06 16:44:21 -05:00
Cole Robinson
7e7b1bdd4e
tests: Order disks in same order libvirt shows them
2014-12-06 16:43:53 -05:00
Cole Robinson
7b8e850bc0
clitest: Sanitize diff output some more
2014-12-06 16:32:10 -05:00
Cole Robinson
cf0206a58c
devicedisk: Break apart set_create_storage
...
And break about the vol_install vs local clone storage creators. And
just generally delete a lot of code. The commit aint pretty but it works
and deletes a ton of hacks
2014-12-05 23:28:53 -05:00
Cole Robinson
7e2ea81a2c
addstorage: Switch away from set_create_storage
2014-12-05 21:49:10 -05:00
Cole Robinson
92663eb1de
devicedisk: Drop transient parameter
...
Just patch it in from distroinstaller
2014-12-05 21:49:10 -05:00
Cole Robinson
40a5ec75b7
tests: Switch away from set_create_storage
2014-12-05 21:49:10 -05:00
Cole Robinson
210ab4d8e0
devicedisk: Add set_vol_install
...
And use it in places where we don't need set_create_storage
2014-12-05 21:49:10 -05:00
Cole Robinson
2acbf52ce3
cli: If creating storage, always build vol_install
...
This is the start of moving this logic out of devicedisk
2014-12-05 20:00:11 -05:00
Cole Robinson
ef0beeb18b
cli: Clean up disk source handling
...
...sort of. This stuff is a hairy mess, but this makes it more stream line
and easier to extend.
2014-12-05 19:05:15 -05:00
Cole Robinson
0cdf6032fb
devicedisk: Remove some redundant validation
2014-12-05 15:31:13 -05:00
Cole Robinson
3e87aadeb7
devicedisk: Clarify backend vs creator code
2014-12-04 21:25:49 -05:00
Cole Robinson
dfc062c611
diskbackend: Make check_if_path_managed more readable
2014-12-04 21:08:38 -05:00
Cole Robinson
66a8c5d374
vmm: conn: Don't abuse path_definitely_exists for pool refreshing
...
Just catch any errors and continue on
2014-12-04 20:39:27 -05:00
Cole Robinson
6489df83ca
devicedisk: Rename path_exists -> path_definitely_exists
...
Since it's a best effort attempt, try to make it more clear that
we aren't certain if paths exist in some cases.
2014-12-04 20:10:37 -05:00
Cole Robinson
ba05e1cd43
diskbackend: Drop all pool source matching
...
It's only used to try and determine if a path actually exists, however
in the pool source case there isn't much we can actually do with that
info.
2014-12-04 20:10:37 -05:00
Cole Robinson
0389ab23a7
diskbackend: Remove backing by pool object
...
It just muddles things up for a minor edge case. The autopoolify logic
should catch all practical cases we care about.
2014-12-04 19:45:00 -05:00
Cole Robinson
c7d00baf66
virtinst: connection: Only poll volumes for running pools
2014-12-04 19:25:15 -05:00
Cole Robinson
a75aa47daf
devicedisk: Use consistent capitalization for property names
2014-12-04 16:30:18 -05:00
Cole Robinson
0e67ffba2e
xmlbuilder: Remove now unused clear_attrs infrastructure
2014-12-04 15:29:12 -05:00
Cole Robinson
e71e5cd9dd
devicedisk: Open code _xmlpath handling
...
Rather than depend on xmlbuilder infrastructure. We will need to extend
this logic for network disks, and it's easier this way.
2014-12-04 15:28:14 -05:00
Cole Robinson
e992cc15b2
virt-xml: Disable clearxml= for devices
...
It doesn't work in the general case, and users can just --remove and
--add devices as needed for the same effect
2014-12-04 15:28:14 -05:00
Cole Robinson
8d6ffafa1b
tests: testdriver: More network storage examples
2014-12-04 13:06:20 -05:00
Cole Robinson
899bff4c4d
tests: Quiet things with non-latest libvirt
2014-12-04 13:04:02 -05:00
Chen Hanxiao
43550c6daa
devicedisk: add qed in driver_types
...
We already used 'qed' in our codes,
but seems we forgot to add this in driver_types.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-04 08:57:06 +08:00
Cole Robinson
01d6541f69
create: Don't show default disk path on summary page
...
Since it's dependent on the VM name, which the user might change
2014-12-03 13:14:36 -05:00
Cole Robinson
4a678f0543
create: Fix default storage path when VM name is changed (bz 1169141)
...
Regressed with 2e7ebd4 . Use skip_disk_page() to determine when we
shouldn't assume default storage
2014-12-03 13:08:18 -05:00
Cole Robinson
c090d18beb
console: Show multiple graphics devices in menu list
...
But actually switching to one isn't supported, so show a tooltip to
that effect.
2014-12-03 12:21:57 -05:00
Cole Robinson
ef99daa3d1
console: Rework serial menu building
...
Mostly code reorg with some minor bug fixes thrown in.
2014-12-03 12:14:32 -05:00
Cole Robinson
d178923609
create: Clarify function name
...
It's no longer the 'name' page
2014-12-03 10:13:39 -05:00
Cole Robinson
0b391fe9ed
virt-manager: Enforce gobject introspection versions
...
This is needed with freebsd and opensuse at least. See:
https://bugzilla.suse.com/__show_bug.cgi?id=901869
http://www.redhat.com/archives/libvir-list/2014-December/msg00184.html
2014-12-02 14:01:28 -05:00
Giuseppe Scrivano
d2e6271337
Revert "tests: fix tests suite with last libvirt version"
...
This reverts commit 9477f063762d25f858855172caf49e23511a85be.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-01 18:00:16 +01:00
Giuseppe Scrivano
9477f06376
tests: fix tests suite with last libvirt version
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-01 17:02:22 +01:00
Giuseppe Scrivano
51e5a47120
virt-manager: reset vgamem for video when changing device type
...
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1169295
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-01 17:02:22 +01:00
Chen Hanxiao
a28b915724
HACKING: add more descriptions for test options
...
also added the site of virt-manager translate project.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-01 10:20:18 +08:00
Giuseppe Scrivano
ad1f0fa081
details: fix --show-domain-performance
...
the introspection page could be missing, in this case the tabs values
are shifted by one. The new code looks for the correct row number
before selecting it.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1167600
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-26 08:41:40 +01:00
Giuseppe Scrivano
9d633879b1
tests: fix failures with libvirt upstream version
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-25 10:42:51 +01:00
Cole Robinson
09ef4583a0
virt-install: Also don't show console= warning for machvirt + --location
2014-11-21 13:57:30 -05:00
Cole Robinson
507af25258
virt-install: Don't warn about missing console= for machvirt
...
Since latest kernels figure it out automatically
2014-11-20 19:15:11 -05:00
Cole Robinson
be3787f2d1
urlfetcher: Detect RHEL ARM distro from treeinfo
2014-11-20 19:15:11 -05:00