Commit Graph

325 Commits

Author SHA1 Message Date
Cole Robinson
c9b2ec163f preferences: Add UI for disabling spice usb autoredir
We already have a gconf key and command line option for this.
Drop the CLI option and add UI for it, we should have just done
that to begin with
2018-03-16 14:38:22 -04:00
Cole Robinson
b72db888f6 ui: create: Fix container rootpw mismerge 2018-03-15 21:24:48 -04:00
Cole Robinson
2dcfaafcac inspection: Show inspection error in details page 2018-03-15 21:24:48 -04:00
Cole Robinson
6b1278ccda prefs: Add a setting to enable/disable libguestfs inspection
Rather than key it on the library being available. Makes it much
easier to test both modes of behavior.

Fix up a few inspection bugs while I'm in the area, and convert
it to be more singleton like.
2018-03-15 21:24:48 -04:00
Cole Robinson
a10fda6b5c uitests: console: Add live lxc serial test 2018-01-21 14:42:44 -05:00
Cole Robinson
d774d01e1c uitests: Add live console tests
Using transient VMs connecting to real qemu:///system. uitests are
already system invasive so I think this is okay
2018-01-21 14:42:44 -05:00
Cole Robinson
2bfd2f28c1 uitests: More details config tweaking 2018-01-21 14:42:44 -05:00
Cole Robinson
c68cd7bb00 uitests: Add details editing tests 2018-01-21 14:42:44 -05:00
Cole Robinson
d3137419d0 uitests: Add manager related tests 2018-01-21 10:02:08 -05:00
Cole Robinson
3ccb947ce3 uitests: Add choosecd dialog tests 2018-01-21 10:02:08 -05:00
Cole Robinson
dc3c0b29f7 uitests: addhardware storage/disk testing 2018-01-21 10:02:08 -05:00
Cole Robinson
c620e7405c uitests: addhardware: add network tests 2018-01-21 10:02:08 -05:00
Cole Robinson
9232a51d55 uitests: Add a bunch of addhardware testing 2018-01-19 11:04:44 -05:00
Cole Robinson
be03382e25 uitests: Add snapshot tests 2018-01-18 16:56:07 -05:00
Cole Robinson
d8d71bddfb ui: Add createnet/pool/vol/interface tests 2018-01-11 21:02:34 -05:00
Cole Robinson
570ee90c4d uitests: Centralize object list smoketest handling 2018-01-11 10:27:48 -05:00
Cole Robinson
8716fd92af ui: connect: Add 'Custom URI' option
Proper UI option to just enter your own URI
2018-01-09 17:58:55 -05:00
Cole Robinson
09dd1596e2 uitests: Add preferences dialog tests 2018-01-09 17:41:20 -05:00
Cole Robinson
c073fc2a7e ui: about: Bump copyright year 2018-01-09 17:41:20 -05:00
Cédric Bosdonnat
1c3e32553e Unify invisible_char values
To be consistent across the UI, change the few remaining different
invisible_char values to match the most common one.
2018-01-06 17:21:35 -05:00
Cédric Bosdonnat
50fd011153 oscontainer: ask root password in the wizard
When creating a new root file system out of an downloaded image,
the root password is likely to be changed. Add a field for this
in the new guest wizard.
2018-01-06 17:21:35 -05:00
Cédric Bosdonnat
03e827b24b Improve container image url examples
Replace the docker://fedora placeholder by a tooltip that shows more of the
possible values (taken from virt-bootstrap's man page). Finding an image
that has a /sbin/init on the docker hub is rather hard, better remove
the misleading value.
2018-01-06 17:21:35 -05:00
Lin Ma
066b91b2a0 ui: details: Add ui for showing attached controller devices in the future
Signed-off-by: Lin Ma <lma@suse.com>
2018-01-06 16:40:30 -05:00
Anthony
ca3c3a5869 ui: create: fix bootstrap typo 2017-12-20 14:02:55 -05:00
Cole Robinson
29a5e7a230 details: Remove q35 support warning (bz #1443021)
It's been around long enough and in use long enough that this
isn't required anymore
2017-11-25 15:15:08 -05:00
Lin Ma
083dfcc8ec host: Show details about the network of SR-IOV VF pool
Signed-off-by: Lin Ma <lma@suse.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-10-09 10:22:48 +02:00
Pavel Hrdina
36230c9a18 devicepanic: use model instead of address.type
There are multiple models of the panic device, the address type is only
one and is valid only for "isa" model.

To not break the virt-install/virt-xml the command line parser needs to
be updated.  Before this patch there was only one parameter that
configured the "iobase".  Now the first parameter configures a model
but to keep it backward compatible it follows these rules:

1. there is only one parameter and it matches known model:

  --panic isa

  <panic model='isa'>
    <address iobase='0x505' type='isa'/>
  </panic>

2. there is only one parameter and it doesn't match any model:

  --panic 0x505

  <panic model='isa'>
    <address iobase='0x505' type='isa'/>
  </panic>

3. there are two parameters:

  --panic isa,iobase=0x505

  <panic model='isa'>
    <address iobase='0x505' type='isa'/>
  </panic>

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-09-09 10:09:46 +02:00
Pavel Hrdina
9655f7dfaf virtManager: remove panic iobase from GUI
This is advanced configuration and it's not required to configure
at all to have a working panic device.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-09-09 10:09:46 +02:00
Laurent Bigonville
cd20536143 Use gtk-stop icon for the "Stop" action
When stopping the pools or the interfaces use the gtk-stop icon.

Currently this is inconsistant with the virtual network tab.

https://bugzilla.redhat.com/show_bug.cgi?id=1352974
2017-08-03 13:06:02 -04:00
Cole Robinson
6f8206dc55 uitests: newvm: Fix after CPU UI tweaks 2017-07-20 17:54:11 -04:00
Cole Robinson
091c6155d2 ui: host: Fix some interface panel spacing 2017-07-20 17:27:22 -04:00
Chen Hanxiao
21ce859356 gfxdetails: add checkbox for password visibility toggle
This patch add a checkbox for password visibility toggle.
    As we stored password of SPICE/VNC in clear text in XML,
    it's easy to use in UI.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-07-19 12:26:02 -04:00
Cole Robinson
85cbf9e64d ui: create: modernize layout for memory/cpu page 2017-07-14 19:23:35 -04:00
Radostin Stoyanov
c29cce2673 asyncjob: Add enable/update details methods
Add virtual terminal emulator (Vte) in which could be shown details
of background running process.

Usage example:

- To enable details:
> asyncjob.details_enable()

- To show text inside the Vte:
> asyncjob.details_update("Some text here")
2017-07-13 14:45:28 -04:00
Radostin Stoyanov
bb2e5c0899 create: Add support for OS tree creation
Allow container bootstrap when connected to local Libvirt LXC driver
and if virtBootstrap module is available.
2017-07-10 14:51:31 -04:00
Radostin Stoyanov
fb8db15269 ui: asyncjob: Align Cancel button at bottom-right 2017-06-23 14:05:31 -04:00
Cole Robinson
860268f735 ui: create: Fix vertical alignment of storage summary 2017-06-01 13:55:41 -04:00
Cole Robinson
f30ca19b87 ui: clone: fix alignment of disk checkbox 2017-06-01 13:48:16 -04:00
Radostin Stoyanov
6f6727f78b Use consistent alignment for memory/cpu grid 2017-06-01 13:46:24 -04:00
Radostin Stoyanov
fc5ecbcdf8 Resolve incorrect label alignment
The "xalign" property determines the horizontal alignment of the label
text inside the labels size allocation. Compare this to “halign”,
which determines how the labels size allocation is positioned
in the space available for the label. [1]

When the "width_chars" property is used, labels appear to be centered.
This could be resolved when the property "width_chars" is replaced
with "max_width_chars" or removed in case "max_width_chars" is already
set. [2]

[1] https://developer.gnome.org/gtk3/stable/GtkLabel.html#GtkLabel--xalign
[2] https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkAlign
2017-06-01 13:46:20 -04:00
Radostin Stoyanov
e7671a63ba Use GtkPaned instead of GtkHPaned
GtkHPaned was deprecated since Gtk version 3.2 and should not be
used in newly-written code.[1] Use GtkPaned instead.[2]

By default, GtkPaned's orientation is set to horizontal.[3]

[1] https://developer.gnome.org/gtk3/stable/GtkHPaned.html

[2] https://developer.gnome.org/gtk3/stable/GtkPaned.html

[3] https://developer.gnome.org/gtk3/stable/gtk3-Orientable.html#GtkOrientable--orientation
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
7b44967bf7 Use GtkSeparator instead of GtkHSeparator
GtkHSeparator was deprecated since Gtk version 3.2 and should not be
used in newly-written code.[1] Use GtkSeparator instead.[2]

By default, GtkSeparator's orientation is set to horizontal.[3]

[1] https://developer.gnome.org/gtk3/stable/GtkHSeparator.html

[2] https://developer.gnome.org/gtk3/stable/GtkSeparator.html

[3] https://developer.gnome.org/gtk3/stable/gtk3-Orientable.html#GtkOrientable--orientation
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
951d3fd4fc Remove deprecated GtkActivatable:use-action-appearance property
GtkActivatable:use-action-appearance was deprecated since
Gtk version 3.10 and should not be used in newly-written code.

https://developer.gnome.org/gtk3/stable/GtkActivatable.html#GtkActivatable--use-action-appearance
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
e6ae060ceb Convert GtkTable to GtkGrid
GtkTable was deprecated since Gtk version 3.4 and should not be used
in newly-written code. It should be replaced by GtkGrid.

https://developer.gnome.org/gtk3/stable/GtkTable.html
https://developer.gnome.org/gtk3/stable/GtkGrid.html

GtkTable is mapped to GtkGrid following these rules:
----------------
- n_(row|columns) are removed because they are not required for
  GtkGrid

----------------
- Missing "left_attach" and "top_attach" are added with value set to
  0.
  Example:
    <property name="left_attach">0</property>
    <property name="top_attach">0</property>
----------------
- (right_attach - left_attach) > 1 is stored in new "width" property

  Example:
    In case of: (GtkTable)
      <property name="left_attach">1</property>
      <property name="right_attach">4</property>

    Equivalent to: (GtkGrid)
      <property name="width">3</property>

----------------
- (bottom_attach - top_attach) > 1 is stored in new "height" property

  Example:
    In case of: (GtkTable)
      <property name="top_attach">1</property>
      <property name="bottom_attach">3</property>

    Equivalent to: (GtkGrid)
      <property name="height">2</property>

----------------
- Missing packing "(x|y)_options" property is represented as no
  "(h|v)align" object property and "(h|v)expand" object property
  set to "true"

  Example:
    In case of: (GtkTable)
      # Missing y_options property
    Equivalent to: (GtkGrid)
      <property name="vexpand">True</property>
      # No valign property

----------------
  - Packing "(x|y)_options" property set to "GTK_FILL" is represented
    as no "(h|v)expand" object property and no "(h|v)align" object
    property

    Example:
      In case of: (GtkTable)
          <property name="x_options">GTK_FILL</property>
    Equivalent to: (GtkGrid)
        # No hexpand property
        # No halign property

----------------
  - Packing "(x|y)_options" property set to "GTK_EXPAND" is
    represented as "(h|v)expand" object property set to "true" and
    "(h|v)align" object property set to "center"

    Example:
      In case of: (GtkTable)
        <property name="x_options">GTK_EXPAND</property>

      Equivalent to: (GtkGrid)
        <property name="hexpand">True</property>
        <property name="halign">center</property>

----------------
  - Packing "(x|y)_options" property set to nothing is represented as
    "(h|v)align" object property set to "center"

    Example:
      In case of: (GtkTable)
        <property name="y_options" />

      Equivalent to: (GtkGrid)
        <property name="valign">center</property>

----------------
  - All "(x|y)_options" rules apply but don't change existing
    "(h|v)align" and "(h|v)expand" object properties

----------------
  - Packing "x_padding" property is converted to "margin_(start|end)"
    object property

    Example:
      In case of: (GtkTable)
        <property name="x_padding">6</property>

      Equivalent to: (GtkGrid)
        <property name="margin_start">6</property>
        <property name="margin_end">6</property>

----------------
  - Packing "y_padding" property is converted to "margin_(top|bottom)"
    object property

    Example:
      In case of: (GtkTable)
        <property name="y_padding">6</property>

      Equivalent to: (GtkGrid)
        <property name="margin_top">6</property>
        <property name="margin_bottom">6</property>
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
84419fe90c Remove deprecated GtkMisc:ypad property
GtkMisc:ypad was deprecated since Gtk version 3.14 and should not be
used in newly-written code. Use margin-top and margin-bottom instead.
Both have default value set to 0.

https://developer.gnome.org/gtk3/stable/GtkMisc.html#GtkMisc--ypad

https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--margin-top

https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--margin-bottom
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
fb46c9dc27 Remove deprecated GtkMisc:xpad property
GtkMisc:xpad was deprecated since Gtk version 3.14 and should not
be used in newly-written code. Use 'margin-start' and 'margin-end'
instead.

https://developer.gnome.org/gtk3/stable/GtkMisc.html#GtkMisc--xpad

https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--margin-start

https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--margin-end
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
dd59bd6267 Use valign property instead of yalign
GtkAlignment:yalign was deprecated since Gtk version 3.14 and
should not be used in newly-written code. Use valign property instead.

The behaviour of yalign='0' is identical to valign='start', similar
for yalign='1' and valign='end'. The default value of the property
valign is GTK_ALIGN_FILL which has simmilar behaviour to yalign='0.5'.

https://developer.gnome.org/gtk3/stable/GtkAlignment.html#GtkAlignment--yalign

https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--valign
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
6f7fb58953 Remove redundant xalign property
GtkAlignment:xalign was deprecated since Gtk version 3.14 and should
not be used in newly-written code. Specifying halign property is not
required when xalign='0.5' because the behaviour is identical to the
default value of halign.

https://developer.gnome.org/gtk3/stable/GtkAlignment.html#GtkAlignment--xalign

https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--halign
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
3243a221b5 Replace xalign='1' with halign='end'
GtkAlignment:xalign was deprecated since Gtk version 3.14 and should
not be used in newly-written code. Use halign property instead.

https://developer.gnome.org/gtk3/stable/GtkAlignment.html#GtkAlignment--xalign

https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--halign
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
b6731ceaa6 Replace xalign='0' with halign='start'
GtkAlignment:xalign was deprecated since Gtk version 3.14 and should
not be used in newly-written code. Use halign property instead.

https://developer.gnome.org/gtk3/stable/GtkAlignment.html#GtkAlignment--xalign

https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--halign
2017-05-31 13:27:43 -04:00