Commit Graph

325 Commits

Author SHA1 Message Date
Radostin Stoyanov
f7bce4cca7 Use GtkButtonBox instead of GtkHButtonBox
GtkHButtonBox was deprecated since Gtk version 3.2 and should not
be used in newly-written code. Use GtkButtonBox instead. The property
orientation is set by default to horizontal.

https://developer.gnome.org/gtk3/stable/GtkHButtonBox.html
2017-05-31 13:27:43 -04:00
Radostin Stoyanov
5a658ef6bd Format UI files with Glade 3.20
Glade performs XML formatting on save. The changes in this commit are
generated by Glade 3.20
2017-05-31 13:27:43 -04:00
Lin Ma
733d541624 network: add support for network forward mode 'open'
libvirt added network forward mode 'open' by commit 25e8112d, No any
iptables rules are added to this virtual network.

This patch adds support to create such a virtual network.

Signed-off-by: Lin Ma <lma@suse.com>
2017-05-03 14:15:02 -04:00
rst0git
04d46d4baa Replace GtkHBox and GtkVBox with GtkBox.
Problem:
    - GtkHBox and GtkVBox have been deprecated since version 3.2 and should not be used in newly-written code.

Solution: Replace GtkHBox and GtkVBox with GtkBox.
    - I have used the find function in text-editor to find all occurances of "GtkVBox" and "GtkHBox" then replaced them with "GtkBox".
    - Then append on a new line immediately after "<property name="orientation">...</property>" with value "horizontal" or "vertical" accordingly.
2017-04-12 09:22:56 -04:00
Cole Robinson
6d1a3db421 createnet: Cleanups around hostdev UI 2017-04-04 15:20:33 -04:00
Lin Ma
97c8412df6 network: add support to create SR-IOV VF pool
Create a network with a device pool containing all the VFs of an SR-IOV device.

Signed-off-by: Lin Ma <lma@suse.com>
2017-04-03 19:15:11 -04:00
Cole Robinson
aefea61fa0 create: Fix some minor UI issues with vz installs 2017-03-22 11:40:04 -04:00
Mikhail Feoktistov
5a70b946c7 Add GUI to create wizard for virtuozzo containers
Add virtuozzo hypervisor to connection list.
Add radio buttons for choosing VM or container virtualization type.
New wizard window for setting template name for containers.
2017-03-22 11:00:50 -04:00
Cole Robinson
b58417071c ui: about: Adjust copyright year 2017-03-08 18:25:32 -05:00
Cole Robinson
8f39de8243 ui: details: Tweak RNG page a bit 2017-03-08 17:48:26 -05:00
Cole Robinson
8eee62712e gfxdetails: Add more errors/warnings around spice GL
Add warning icons with informative tooltips. Desensitive UI rather
than hide it if the hypervisor doesn't support things. A few other
usability tweaks
2017-03-08 16:07:32 -05:00
Cole Robinson
07f1a4e168 ui: Use 'Shut Down' vs 'shutdown' consistently 2017-03-06 22:05:35 -05:00
Marc-André Lureau
b484d15258 virtManager/ui: add 3d acceleration checkbox to virtio video
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2017-03-01 17:58:30 -05:00
Marc-André Lureau
53d09bc28c virtManager/ui: add rendernode selection
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2017-03-01 17:57:57 -05:00
Marc-André Lureau
326dc03c23 virtManager/ui: add listen type option
Similarly to virt-install --listen=none, add a combobox to select
the listen type: "address" or "none" for now, as suggested by Pavel
Hrdina.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2017-03-01 17:56:52 -05:00
Marc-André Lureau
88942028b3 virtManager/ui: add opengl graphics option
Add an OpenGL checkbox to the Spice graphics options (only available if
SUPPORT_CONN_SPICE_GL).

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2017-03-01 17:54:19 -05:00
Cole Robinson
6e988e994c details: inspection: Fix UI alignment
Convert the table to a grid to get modern spacing behavior
2017-03-01 16:32:09 -05:00
Pino Toscano
409ae0bcf4 inspection: add a way to refresh the inspection info
Introduce a 'Refresh' button in the 'Information' page of a VM, and
wire it up so a refresh of the inspection data for it is triggered.
2017-03-01 16:25:47 -05:00
Pino Toscano
ebf4ade208 inspection: show OS type in Inspection page
Show also a pretty label for the OS of the guest, in addition to
hostname and product name.
2017-02-09 16:29:27 -05:00
Pavel Hrdina
67998282a7 ui/snapshots: add a tooltip for refresh button
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1375452

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-01-18 13:33:42 +01:00
Chen Hanxiao
8eb0a9002f gfxdetails: active SpinButton when mnemonic key of 'Port' or 'TLS port' pressed
Currently when press mnemonic key of 'Port' or its CheckButton,
the behaviour is the same:
  check 'Auto' CheckButton.
which is not right.

This patch will change the behaviour:
  when press mnemonic key of 'Port',
  change the focus to graphics-port SpinButton.
So as 'TLS Port'.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2016-11-01 22:04:43 +08:00
Pavel Hrdina
8296c5b74f ui.createnet: change the example ipv6 address
It was pointed out that the original address may be offending.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2016-09-07 16:51:00 +02:00
Chen Hanxiao
911dac0dfa snapshot: start snapshot when double-click the item of snapshot list
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2016-08-02 13:20:15 -04:00
Cole Robinson
720ea801bc about: Update copyright year to 2016 2016-06-19 11:31:11 -04:00
Pavel Hrdina
09cc6f3832 console: add support to forget password
If password for console is saved currently there is no way how to tell
virt-manager to forget that password.  This patch improves the authentication
page in order to provide a way how to forget password simply by unchecking the
"Save this password in your keyring".

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2016-06-07 20:03:27 +02:00
Pavel Hrdina
2d554aca7b ui: remove "Restore Saved Machine..." from File menu of Connection Details
Commit 839ce682 removed deprecated support of save/restore which was replaced by
managedsave feature.  This is a leftover that wasn't removed together with that
commit.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1340356

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2016-05-31 13:09:48 +02:00
Cole Robinson
0f88ebbc0b console: Enforce text wrapping on 'unavailable' page 2016-05-18 16:32:07 -04:00
Cole Robinson
dfcac3fe9c Bump gtk and pygobject deps to 3.14
We need to bump the gtk dep to at least 3.10 for GtkRevealer usage,
and I want to bump the pygobject higher to drop some bug workarounds.

But since the oldest thing I have that meets those requirements is
RHEL/Centos 7.3 which is at 3.14 for both, set those as the minimum
versions since that's what I'll be testing against. They are still
1.5 years old and only a bit over a year newer than the previous
versions, so it's not a huge change.
2016-05-17 17:49:55 -04:00
Cole Robinson
dc05600324 console: Convert from autodrawer to native Gtk widgets
Gtk 3.10 has a GtkOverlay and GtkRevealer widget which we can
use to more sustainably implement the autodrawer functionality.
2016-05-17 17:49:55 -04:00
Cole Robinson
671d9c0218 ui: details: Make the graphics error label selectable
For copying error messages
2016-05-16 15:19:52 -04:00
Cole Robinson
400b668da3 asyncjob: Always hide the X button 2016-01-11 14:48:49 -05:00
Cole Robinson
467fea9df7 asyncjob: Convert to GtkBox 2016-01-11 14:46:53 -05:00
Cole Robinson
2178cc8c93 create: Drop explicit kickstart UI
Few users actually use this, and they can easily do it with the kernel
options field.
2015-11-21 20:21:09 -05:00
Cole Robinson
d32953d8c6 details: Remove UI for vcpu pinning
This UI exposed the old NUMA allocation policy detailed in the last commit.
It's very much sub-optimal, and should be removed.

Manual cpuset configuration is also quite uncommon and not really something
worth exposing in the UI. It can easily be done from the command line
with virt-xml.

If people complain, I'd consider adding a checkbox for vcpu placement=auto,
or an option to do that by default for new VMs.
2015-11-18 15:05:21 -05:00
Cole Robinson
ba8080db3f storagelist: Reset list position after deleting volume (bz 1279861) 2015-11-10 17:27:49 -05:00
Cole Robinson
117cad551d ui: Don't mark UI accessibility names as translatable
Because I haven't been using translatable strings...
2015-09-23 17:01:41 -04:00
Cole Robinson
8e58734699 create: Hide aarch64 warning if we switch architectures
Simplest is to have a separate UI area for the arch warning, since
the standard startup warning may still apply too.

Reported-by: João Pirralha <joaopirralha@gmail.com>
2015-09-23 16:51:49 -04:00
Cole Robinson
b6111b5e85 details: Fix misaligned labels (bz 1264628)
Shows up with different sized translation strings

https://bugzilla.redhat.com/show_bug.cgi?id=1264628

Reported-by: João Pirralha <joaopirralha@gmail.com>
2015-09-20 12:58:23 -04:00
Cole Robinson
0b881591ec console: Add a separate notebook for serial pages
Rather than the 'offset' page hack we previously did that is hard to
keep track of. This allows for a handful of code simplifications
2015-09-18 12:36:06 -04:00
Cole Robinson
d896dd7347 create: Allow switching between KVM and TCG for armv7l (bz 1214592)
Otherwise we tried to always force KVM which reduces the usefulness
here. We still get the defaults right though

https://bugzilla.redhat.com/show_bug.cgi?id=1214592
2015-09-14 19:27:48 -04:00
Cole Robinson
7953f23975 create: Update storage path in summary when VM name changes
If the name is going to influence the default storage path, update it
as people type
2015-09-14 16:22:17 -04:00
Cole Robinson
a4ddac4bb1 create: Always display the storage path in the summary 2015-09-14 15:22:17 -04:00
Cole Robinson
01da21b93a uitests: Add a basic details.py test
Checks all hw of test-many-devices and make sure an error isn't raised
2015-09-14 14:44:39 -04:00
Cole Robinson
9f56641b49 addstorage: Tweak labels to be a bit more descriptive
WRT the fact that we aren't just 'browsing' for storage anymore
2015-09-13 19:27:44 -04:00
Cole Robinson
16a744749f addhardware: Drop 'storage format' field
Originally this made sense, as it was the only way to specify a non-default
storage format when creating new storage.

Nowadays the storage browser is a full featured storage manager... and
this field is a bit confusing WRT whether it's used for creating new
storage, or informing libvirt about an existing image's format.

Drop it from the addhardware wizard, and simplify what we show in the
details wizard as well.
2015-09-13 19:13:53 -04:00
Cole Robinson
a2bd31c2a6 virt-manager: Drop old style config- prefix for widget names
It's redundant and we haven't followed that pattern for a long while
2015-09-13 18:01:39 -04:00
Cole Robinson
4b5e65fe8d details: Remove iotune UI
This is a little low level and rarely used IMO to have it in the UI.
If people want to edit this we should point them at virt-xml which
seems like the appropriate user friendlyness for this feature.
2015-09-13 15:54:47 -04:00
Cole Robinson
15a6a7e210 addstorage: Drop explicit sparse option
This made more sense when raw was the disk image default, but nowadays
we use qcow2 which doesn't even support non-sparse, so the UI is always
disabled.

If the user changed their preference to raw, it still doesn't make much
sense to show the option, since they are likely using raw for performance
in which case they are going to want to preallocate anyways.

So just default to sparse=False. If users want to override it, they can
do it via custom created storage.
2015-09-13 15:43:24 -04:00
Cole Robinson
241c3125e5 create: Drop redundant _have_startup_error
Isn't needed in the modern code
2015-09-13 12:28:16 -04:00
Cole Robinson
ddea18baf9 create: Cleanup of distro detection code
- Use better variable names
- Lots of comments
- Streamline various parts
2015-09-13 12:28:16 -04:00
Cole Robinson
5c66328e10 uitests: Several more 'New VM' tests, and cli --show tests 2015-09-09 19:07:31 -04:00
Cole Robinson
730b739795 create: A bunch of mnemonic fixes 2015-09-09 14:26:36 -04:00
Cole Robinson
531260be36 details: Raise upper limits for lxc ID namespaces (bz 1244490) 2015-08-10 13:14:37 -04:00
Cole Robinson
5f497b4d79 Mark a couple strings as translatable 2015-08-09 14:01:01 -04:00
Cole Robinson
fc93e154dc addhardware: Fix udp/tcp host vs mode UI
We had the UI label names swapped, so were showing the incorrect fields
2015-06-21 15:14:30 -04:00
Cole Robinson
b02cb7ffa0 delete: Improve dialog sizing and scrolling
Drop horizontal scrolling, since with gtk3 hidden scrollbars it might
mean users don't realize there's info that is scrolled off.

Adjust the default sizing to match that pattern
2015-05-20 17:50:11 -04:00
Cole Robinson
2168f33799 details: Unify controller model handling with addhardware 2015-05-19 18:29:45 -04:00
Giuseppe Scrivano
fbdf574c53 add-hardware: fix shortcut key for USB redir dev type
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1172108

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-11 10:17:11 +02:00
Cole Robinson
68ce97d533 create: customize: cancel now cancels the entire installation
Trying to fall back to the create wizard can give weird results, since
it's really hard to ensure the customized changes are preserved if
the user changes things in the 'new' wizard.
2015-05-03 16:53:43 -04:00
Cole Robinson
46ecafd820 migrate: Fix typos pointed out by translator 2015-05-01 09:38:25 -04:00
Cole Robinson
18a6d8b444 migrate: Add 'temporary' option
This doesn't undefine the VM source, and leaves it temporary on the
destination. Basically the default migration action
2015-04-21 17:39:44 -04:00
Cole Robinson
62ad0e91ee migrate: Big reworking of the dialog
It's largely the same, but now

- The code is better organized
- The UI is much more streamlined, only showing relevant fields when
  required.
- We warn about the hostname/URI cases that we know libvirt will error on
- Drop some of the attempts at being smart, and just mimic what libvirt
  will do.
2015-04-21 17:15:58 -04:00
Cole Robinson
bfcfdbf785 host: Remove some redundant connection fields 2015-04-21 16:33:41 -04:00
Cole Robinson
996c8b76b8 clone: Use conn desc if showing destination conn 2015-04-21 16:33:41 -04:00
Cole Robinson
2b877cf337 migrate: Remove 'max downtime' support
This is only needed when people have very specific downtime constraints
on public facing services. I don't think that covers many virt-manager
users. So suggest they just use the command line for this.
2015-04-21 16:33:41 -04:00
Cole Robinson
39dc0c7b94 migrate: Drop 'bandwidth' UI
A bit too enterprisy for my tastes. If people need this they should use
the command line.
2015-04-21 16:33:41 -04:00
Cole Robinson
3d2afbaf6f connection: Allow setting a custom 'pretty name' (bz 784701)
We've had multiple requests over the years for something similar. People
might have to connect to multiple IP addresses, or really large hostnames,
that become difficult to distinguish in the UI.

Add a field in the host details page that allows setting a custom name,
and store it in gsettings.
2015-04-11 13:39:25 -04:00
Cole Robinson
8c107f87f9 host: Remove some redudant conn details
And some minor UI spacing fixes
2015-04-11 11:29:03 -04:00
Cole Robinson
413c290bfe create: Renamed 'advanced options' to 'network selection'
Since that's all it contains now
2015-04-10 18:44:16 -04:00
Cole Robinson
8f563cbae8 storagelist: Simplify Ui a bit
Drop the bold and overly sized text. Drop the name duplication.
Drop the type field since it's shown in the pool list.
2015-04-10 18:40:54 -04:00
Cole Robinson
92c42bc5a0 details: Improve UI labeling of keyboard devices 2015-04-09 13:36:40 -04:00
Cole Robinson
771154d104 addhardware: Make network model a combo entry
So users can add non-advertised models
2015-04-09 12:58:21 -04:00
Cole Robinson
058c06972e Break out shared storage UI to storagelist.py (bz 1060433)
We were already sharing a chunk of this in a haphazard way. Now officially
break it all out, similar to netlist.py. This mostly unifies the views
of host->storage and storagebrowser.py
2015-04-09 12:31:24 -04:00
Cole Robinson
ec162888f5 addhardware: Make bus list dependent on device type
And not the other way around. It's less confusing this way IMO, particularly
if virtio is selected by default and the user is confused, wondering
where the cdrom option is.

Take the opportunity to actually share the bus combo logic between details
and addhardware
2015-04-07 19:31:30 -04:00
Cole Robinson
1d98af2c47 create: Move mac address editing to customize dialog
People should rarely need to edit the mac address, so remove it from
the create wizard. However we only allow editing the mac address in
the 'customize' dialog: regular network details disables editing, since
that should be a rare and potentially dangerous operation.
2015-04-07 18:52:35 -04:00
Cole Robinson
39b5d11628 details: Make CPU config a frame, not an expander
It's very commonly tweaked, so move it front and center.
2015-04-07 11:53:16 -04:00
Chen Hanxiao
101ca3cef8 details: change duplicated short-key 'd' to 'e' on Overview tab
add hardware also use 'd' as its short-key.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-03-16 21:26:47 -04:00
Giuseppe Scrivano
61e06856a3 virt-manager: Allow to change SGIO with LUN disk devices
It is added only in the details window, and intentionally not added to
the addhardware UI to keep it simpler.  Users can edit this after a
new device is added.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-16 20:32:40 +01:00
Cole Robinson
0ddec9199b details: Don't allow changing machine type for existing VM
But still allow it from the customize dialog. It's one of those things
that rarely can be changed for a working VM and things continue to work.
2015-02-22 10:25:51 -05:00
Chen Hanxiao
694f2b1370 connection details: add short-keys for Virtual Networks
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-01-28 09:52:23 +08:00
Chen Hanxiao
751d189110 ui: remove underline property of tpm device type in details
We could not modify tpm device type yet.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-31 14:28:22 +08:00
Giuseppe Scrivano
2dff68c1df virtManager: Add missing shortcut keys
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1172108

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-13 15:42:46 +01:00
Chen Hanxiao
e0b5283ac3 Redirect device: remove underline property of 'Type' in details UI
redir-type is a label.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:10:14 +08:00
Chen Hanxiao
71613d95e8 Smartcard device: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:08:02 +08:00
Chen Hanxiao
34f9be43c2 sound: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:07:33 +08:00
Chen Hanxiao
8f2c9b354a cpu: add mnemonics in details UI
Add mnemonics for 'Configuration' page,
'Topology' page, 'Pinning' page
and their sub-pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:06:47 +08:00
Chen Hanxiao
0368394c7e boot options: add mnemonics in details UI
Add mnemonics for 'Direct kernel' page
and sub-pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:06:13 +08:00
Chen Hanxiao
e758aec861 video: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:05:38 +08:00
Chen Hanxiao
351d0a2834 details: add shortkey for controller model
shortkey 'o' for 'Model'.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:04:28 +08:00
Chen Hanxiao
ce7fd785e4 watchdog: add missing mnemonics in details UI
add missing mnemonics and fix an duplicated shortkey

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:02:02 +08:00
Wei Huang
dea3520ea8 ui: add a warning message for hyper-threading support
Not all CPUs support Hyper-Threading. This patch adds a warning
message next to the threads selection field of processor topology
box. It warns that "Selected CPU model does not support
Hyper-Threading" when # of Threads > 1 and the selected CPU model
does not support Hyper-Threading.

This UI modification was added using glade 3.18.3.

Signed-off-by: Wei Huang <wei@redhat.com>
2014-10-27 18:05:21 -04:00
Chen Hanxiao
8f077a270f panic notifier: remove shortcuts in details.ui
We could not modify them in panic notifier page,
so remove them.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:07:35 +08:00
Chen Hanxiao
6f196ed21d panic-notifier: add missing mnemonics in addhardware UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:06:14 +08:00
Chen Hanxiao
b5fd41135d details: add missing mnemonics in cpu UI tab
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:05:52 +08:00
Chen Hanxiao
7752d60cfe ui: change fs-type label ID from "label18" to "fs-type-title"
It looks not very social as its naming.
And it will be used in the later patch.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 10:23:59 +08:00
Chen Hanxiao
64e7e783e7 ui: change duplicated fsdetail shortkey
shortkey M for fs-mode in fsdetail duplicate shortkey of
"Virtual Machine" in details.
change it to 'o'.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-17 17:18:53 +08:00
Cole Robinson
f4563906ca snapshots: Use consistent button layout with host dialog
Except 'refresh' is in place of 'stop'
2014-09-21 11:44:01 -04:00
Cole Robinson
439e5ad0fe details: Reorg a bunch of the global helpers
Some were redundant, some should be in virtinst
2014-09-20 10:23:19 -04:00
Cole Robinson
4ad50d968a details: Put tabs on left, easier to navigate with glade 2014-09-20 10:21:27 -04:00
Cole Robinson
fa76e92f2c virt-manager: Fix issues with ellipsizing on recent gtk 2014-09-19 22:08:22 -04:00