Commit Graph

3693 Commits

Author SHA1 Message Date
Cole Robinson
e4711061c4 snapshots: Make sure 'current' icon is always visible (bz 1065074) 2014-02-14 10:20:37 -05:00
Cole Robinson
88538f916d connection: Actually fix domain event deregister 2014-02-14 10:00:45 -05:00
Cole Robinson
517fbe0b30 createinterface: Catch error when creating stub (bz 1065042) 2014-02-14 09:27:56 -05:00
Cole Robinson
4b98a471b9 manager: Handle multiple vm-added signals
Our conn.tick idle dispatcher can be racey, handle it in manager.py
2014-02-13 11:17:14 -05:00
Cole Robinson
3f27bc1bd1 connection: Fix race when updating conn.vms
We update the canonical conn.vms list in an idle callback, so any parts
of the main UI thread won't see the conn.vms change while they are
iterating over it.

Problem with this, is that if multiple ticks() are scheduled before
the first idle handler has a chance to run, we can overwrite the VM
list can fail to be correctly updated.

Fix this by only updating 'vms' if it actually changed.
2014-02-13 11:17:14 -05:00
Martin Kletzander
078e1a4d05 Rework disk target assignment
Using previous patches, this one makes the disk target generation a
bit more intelligent, so adding multiple disks with various
controllers is not a problem anymore.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1036716

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
6c4302b0a7 disk: generate target controller-wise
Add an optional parameter to generate_target() that controls what
controller the disk should reside in (using libvirt's rules to create
addresses).

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
a9c791b5b8 Add target_to_num method
Opposite to num_to_target.  It will be used in future patch.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
55e85b1612 Unify prettification of VirtIO serial
Use the same case for occurrences of 'VirtIO' which start with
uppercase V.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
4196f4287b Use proper python version
since we work with python2 only, mentioning it in all shebangs make
the commands from git work even when python3 is set as default.

This also fixes one test where command being ran is 'virt-xml' through
subprocess.Popen().

While at that, add '-tt' where possible in order to make everyone use
same indentation characters.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
ab4fd40e96 pylint: Don't use space after 'print'
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Cole Robinson
a808bd6692 connection: Handle volume XMLDesc errors (bz 1064275)
This commonly happens when a file is deleted from a storage pool
behind libvirt's back.
2014-02-12 13:57:44 -05:00
Cole Robinson
d680539b46 Add missing test file 2014-02-12 13:57:36 -05:00
Chen Hanxiao
b53b3874a4 virt-xml: add "-c" as short option of "--connect"
Add "-c" as short option of "--connect" for virt-xml.

We could use either
virt-xml -c lxc:///
or
virt-xml --connect lxc:///

This will be more convenient if we operate
non-default hypervisor.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-12 22:57:40 +08:00
Giuseppe Scrivano
cbec4b10ab ui: add support for gluster fs
Add a new field "pool-source-name" in the createpool UI that is used
only with gluster fs pools.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-02-12 15:46:26 +01:00
Giuseppe Scrivano
7a1ffff927 storage: add support for gluster fs pools.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-02-12 15:46:25 +01:00
Giuseppe Scrivano
a2706e9258 storage: add new attribute "source_dir"
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-02-12 15:46:25 +01:00
Giuseppe Scrivano
dd0af85d5a storage: make "target_path" optional
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-02-12 15:46:25 +01:00
Cole Robinson
1401cda924 domain: pmsuspended domains can be turned off 2014-02-11 16:40:37 -05:00
Cole Robinson
7aecd1a9b8 connection: Fix deregisterevent tracebacks on app close 2014-02-11 16:26:15 -05:00
Cole Robinson
875e3cdc7b domain: Remove old libvirt curvcpus back compat
It shouldn't matter much nowadays
2014-02-11 16:23:51 -05:00
Cole Robinson
b1697056e4 prefs: Change the tick interval to 3 seconds
Most libvirt usage now shouldn't need a high tick interval, since
we are using async events. So raise it.
2014-02-11 15:45:05 -05:00
Cole Robinson
d220cc5d52 preferences: Allow disabling VM CPU poll
With this, the only libvirt API call we hit on each tick is the
connection nodeinfo.
2014-02-11 15:45:05 -05:00
Cole Robinson
a70b836b2d domain: Move get_title near similar get_description 2014-02-11 15:45:05 -05:00
Cole Robinson
e42835b0ff details: Don't poll XML if using domain events 2014-02-11 15:45:04 -05:00
Cole Robinson
e0381cc970 connection: Deregister event callbacks on close 2014-02-11 15:45:04 -05:00
Cole Robinson
4442f1f9be Use network lifecycle events if available
This just allows us to be more reactive to network lifecycle changes.
2014-02-11 15:45:04 -05:00
Cole Robinson
c7cd6ca2d3 Use libvirt events for domain lifecycle tracking (bz 836703)
When events were successfully registered, we skip the VM listing on
every tick, and instead trigger a manual refresh whenever a VM event
is received. Not as efficient as it should be, but saves us a lot of
API calls.
2014-02-11 15:45:04 -05:00
Chen Hanxiao
020957c756 cli: fix a tiny typo
s/./:

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-11 22:08:55 +08:00
Cole Robinson
21fb072d4a virt-install: Default to qcow2 for new images
Following along with virt-manager's change. It has all the features and
good enough performace, and is easy enough to override for people that
care.
2014-02-10 18:47:58 -05:00
Cole Robinson
cdd9dbe7fc cli: Add simple mode --disk size=X
Works the same as pool=default, we generate a disk image path and
create it in the default pool.
2014-02-10 18:34:44 -05:00
Cole Robinson
7bff99f853 cli: Use correct file extension for --disk pool=FOO 2014-02-10 18:27:06 -05:00
Cole Robinson
ac6706208d cli: Shorten some long --help examples 2014-02-10 18:13:42 -05:00
Cole Robinson
d0f44491ff cli: Warn if disk path isn't searchable by qemu 2014-02-10 18:09:15 -05:00
Cole Robinson
9fe79627c1 support: Clarify docs and some parameter names 2014-02-10 17:12:24 -05:00
Cole Robinson
43bb559a30 support: Break out function checker 2014-02-10 17:02:22 -05:00
Cole Robinson
4788499bbd support: Take version strings in support declarations 2014-02-10 16:53:47 -05:00
Cole Robinson
a98505e691 support: Error if registered version is too old to confirm 2014-02-10 16:37:17 -05:00
Cole Robinson
19a72a4881 support: Remove negative version handling
We can do it in other ways
2014-02-10 16:14:39 -05:00
Cole Robinson
96bbfebe5b support: Use dictionary for driver version checks 2014-02-10 16:05:17 -05:00
Cole Robinson
cd0ab0d217 virt-image: Print warning that it is planned for removal 2014-02-10 15:24:12 -05:00
Cole Robinson
f6de5331ba prefs: Disable memory polling by default
This path hits the qemu monitor, and leads to the virt-manager UI being
locked up when performing asynchronous tasks like creating a snapshot.
So make it opt in for people that want it.
2014-02-10 15:14:10 -05:00
Cole Robinson
94b7c124f6 details: stats: Report if memory polling is disabled 2014-02-10 15:13:31 -05:00
Cole Robinson
a411a98cc7 man: virt-install: Clarify docs after auto-storage work 2014-02-10 14:50:59 -05:00
Cole Robinson
d76aab264e tests: Only use one env variable to notify we are running tests 2014-02-10 14:47:20 -05:00
Cole Robinson
82754ddc84 Expose hostdev rombar in UI and cli (bz 768857) 2014-02-10 14:25:23 -05:00
Cole Robinson
2ea6b7e35d addhw: Make hostdev list a bit wider 2014-02-10 14:04:35 -05:00
Cole Robinson
4a006b5ff8 details: Expose fine grained boot config
Basically put an explicit device list in the boot UI, if the hypervisor
supports it. For unsupported hv, use the same old disk/cd/floppy/net UI.
2014-02-10 13:34:17 -05:00
Cole Robinson
8577bdf386 details: Break out icon and label helpers for each device 2014-02-09 15:20:41 -05:00
Cole Robinson
719f23a273 cli: Support per-device <boot order=> 2014-02-09 14:07:27 -05:00