Commit Graph

4079 Commits

Author SHA1 Message Date
Cole Robinson
eda5eea549 virt-install: Switch --cpu host to use host-model, not copy (bz 1133155)
host-model offers us other protections now, like ensuring we don't try
to use a host cpu feature that qemu doesn't support.

http://bugzilla.redhat.com/show_bug.cgi?id=1133155
2014-09-20 20:44:13 -04:00
Cole Robinson
64106230bd virt-install: Add hidden option --test-media-detection
Can help with debugging and test cases
2014-09-20 20:32:19 -04:00
Cole Robinson
3933ff101b guest: Limit number of default usb redirdevs to 2 (bug 1135488)
If we use 4 devices here, we fill up all the emulated USB2 slots,
and directly assigned devices are forced to fall back to USB1

https://bugzilla.redhat.com/show_bug.cgi?id=1135488
2014-09-20 20:16:31 -04:00
Cole Robinson
99700821c6 virt-install: Reorder --help output a bit 2014-09-20 19:30:16 -04:00
Cole Robinson
d7e1a40352 virt-install: Deprecate --nodisks in favor of --disk none 2014-09-20 19:16:13 -04:00
Cole Robinson
57ae284ad4 virt-install: Deprecate --nonetworks in favor of --network none
Follows the pattern used by the other cli options
2014-09-20 19:02:38 -04:00
Cole Robinson
c26512926d virt-install: Default to --graphics even if DISPLAY is unset
This was a weird bit of logic that tries to be smart, but there isn't
a clear corrolation between DISPLAY being unset and whether the user
wants graphics or not.

Make the default consistent, some people may need to adjust to
--nographics
2014-09-20 18:52:20 -04:00
Cole Robinson
e3de3d8b69 virt-convert: Fix pointing to relative config file 2014-09-20 18:29:20 -04:00
Cole Robinson
1f3f3fa4fc virt-install: If virt-viewer will fail, default to --wait -1
This can happen if user requests explicit --graphics, but they are on
a headless display. We had a few reports of this recently.
2014-09-20 18:28:43 -04:00
Cole Robinson
85161e4c57 host: Clean up invocation of *apply from confirm dialog
Basically, only apply the page we are actually on
2014-09-20 17:32:10 -04:00
Cole Robinson
0717a21f65 host: Fix renaming network/storage pool 2014-09-20 17:32:09 -04:00
Cole Robinson
38738d9fa6 connection: Don't close VM dialog on rename
Rework things a bit to simplify everything we pass around.

The specific bug fix is making sure we update the object list in place,
otherwise the event loop detects it as the VM being deleted and closes
the details window.
2014-09-20 17:32:09 -04:00
Cole Robinson
ea97325a72 connection: Tweak some debugging output 2014-09-20 16:33:26 -04:00
Cole Robinson
f2ff378a9d details: Avoid some misleading logging on rename 2014-09-20 16:18:10 -04:00
Cole Robinson
1bfdf0575f test_inject: Drop old bits, add f21 and rhel7, reorg a bit 2014-09-20 15:58:52 -04:00
Cole Robinson
6a8194ebc7 docs: Document virtio-scsi better, and add explicit test cases for it 2014-09-20 15:03:19 -04:00
Cole Robinson
56c091600a details: Move hostdev prettyifier to virtinst 2014-09-20 14:56:57 -04:00
Cole Robinson
5130d959e5 cli: Advertise the --host-device option as --hostdev
It annoys me that all the other CLI options map to the libvirt XML name,
except this one. Of course, keep the old option around for back compat,
just give precendence to the new option.
2014-09-20 14:29:34 -04:00
Cole Robinson
5bbd46a070 cli: Fix suddenly appearing pylint warning :/ 2014-09-20 14:22:29 -04:00
Cole Robinson
c88d085d03 virt-xml: Make --remove-device --host-device <str> work
Need to add some infrastructure for arbitrary lookup functions
2014-09-20 14:22:29 -04:00
Cole Robinson
35c86a775a nodedev: Simplify parameter comparison 2014-09-20 14:22:03 -04:00
Cole Robinson
cf80b4e013 cli: Show failing option via virt-xml --remove lookup 2014-09-20 13:53:27 -04:00
Cole Robinson
92f298e393 addhardware: Use virtmanager APIs for VM listing 2014-09-20 13:04:47 -04:00
Cole Robinson
a3c6637989 nodedev: Share comparison logic for cli string lookup 2014-09-20 12:58:51 -04:00
Cole Robinson
dd67c48233 connection: Handle nodedev polling too
And cleanup up a bunch of nodedev functions as a result
2014-09-20 12:04:49 -04:00
Cole Robinson
8cd4958a19 cli: Break out function to disable libvirt error printing
We need it early in the test suite
2014-09-20 12:04:37 -04:00
Cole Robinson
439e5ad0fe details: Reorg a bunch of the global helpers
Some were redundant, some should be in virtinst
2014-09-20 10:23:19 -04:00
Cole Robinson
4ad50d968a details: Put tabs on left, easier to navigate with glade 2014-09-20 10:21:27 -04:00
Cole Robinson
fa76e92f2c virt-manager: Fix issues with ellipsizing on recent gtk 2014-09-19 22:08:22 -04:00
Cole Robinson
775ea8dc72 virt-manager: Silence gtk deprecation warnings
They are on by default on F21, and they are very noisy
2014-09-19 21:47:13 -04:00
Cole Robinson
55739055fd ui: Set all files to minimum requirement of gtk 3.8
That way gives us better feedback from glade
2014-09-19 21:19:26 -04:00
Cole Robinson
f42e9bf8d4 man: virt-install: Drop overly specific bits about full virt 2014-09-19 20:54:08 -04:00
Cole Robinson
edf9bf0aad serialcon: Drop use of yet more removed API 2014-09-19 20:35:06 -04:00
Cole Robinson
ca2ee52eb8 virtinst: cli: Move unshared bits to virt-install
Since virt-image is gone, this stuff should all be private to virt-install
2014-09-19 20:31:22 -04:00
Cole Robinson
d119a1bf6a pylint: Disable cyclic-import check
Yeah it has a point... but the code works fine in practice, and the
remaining issues will need some decent reorg to fix.
2014-09-19 20:13:52 -04:00
Cole Robinson
3feedb76e9 domain: Match UNDEFINE_NVRAM conditions with libvirt
Suggested-By: Laszlo Ersek <lersek@redhat.com>
2014-09-19 20:08:59 -04:00
Cole Robinson
ebeea7af9f delete: Remove nvram support
As of now, the only uses of nvram likely in the domain XML are with
libvirt configurations that also support the UNDEFINE_NVRAM flag, so
listing it here is kind of redundant. And in the common config of
non-root user connected to qemu:///system with template based nvram
in /var/lib, we won't be able to remove it anyways.
2014-09-19 20:04:39 -04:00
Cole Robinson
ae26313ed4 details: Add UI for enabling UEFI via 'customize before install'
We expose a simple combobox with two entries: BIOS, and UEFI. The
UEFI option is only selectable if 1) libvirt supports the necessary
domcapabilities bits, 2) it detects that qemu supports the necessary
command line options, and 3) libvirt detects a UEFI binary on the
host that maps to a known template via qemu.conf

If those conditions aren't met, we disable the UEFI option, and show
a small warning icon with an explanatory tooltip.

The option can only be changed via New VM->Customize Before Install.
For existing x86 VMs, it's a readonly label.
2014-09-17 18:43:41 -04:00
Cole Robinson
ead9d3f56d domain: If VM has nvram, ask libvirt to remove it on undefine 2014-09-17 18:35:20 -04:00
Cole Robinson
052220cfc8 virtinst: Add DomainCapabilities parser 2014-09-17 18:29:24 -04:00
Cole Robinson
0ad7611b59 virt-xml: Tweak update prompting messages 2014-09-17 12:21:49 -04:00
Lin Ma
e088486b23 addhardware: Deal with the conflict host device
If a host device is in use by guests, Warn user and
let user make choice while adding hardware.

Signed-off-by: Lin Ma <lma@suse.com>
2014-09-16 11:41:13 -04:00
Lin Ma
2f62ba964c Add comparison function for NodeDevice
PCIDevice and USBDevice include respective comparison logic.

Signed-off-by: Lin Ma <lma@suse.com>
2014-09-16 11:41:13 -04:00
Giuseppe Scrivano
e5d2059853 virt-manager: delete nvram file on VM deletion
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:49:00 +02:00
Giuseppe Scrivano
17a37ea39b virt-install: add tests for OVMF
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:47:02 +02:00
Laszlo Ersek
d2fffa509e virt-install: add support for OVMF
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
2014-09-16 09:47:02 +02:00
Giuseppe Scrivano
21319c4232 osdict, libosinfo: use "minimum" resources when "recommended" is missing
Some OS entries in libosinfo miss the "recommended" resources block.
In this case use the "minimum" resources when available.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:12:04 +02:00
Giuseppe Scrivano
f2ad085918 virtManager: add "ich9" to the list of stable audio models
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1140937

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:04:14 +02:00
Giuseppe Scrivano
0218d29a35 virtinst: add ich9 to the list of audio models
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:04:14 +02:00
Chen Hanxiao
30c3434916 test: update compare_check flags for auto-clone cases
auto-clone cases use SUPPORT_CONN_BARE_BACKINGSTORE,
which check libvirt 1.2.4.
Change it to SUPPORT_CONN_LOADER_ROM(1.2.9)
and drop SUPPORT_CONN_BARE_BACKINGSTORE.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-09-16 10:03:27 +08:00