sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-26 01:49:31 +03:00
Code Activity

python/loadparm: check for AD DC required VFS modules

Browse Source 
same as the previous commit, just for python's testparm code

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10560

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Fri Jan  3 22:19:47 UTC 2020 on sn-devel-184
This commit is contained in:
Björn Jacke
2020-01-03 15:29:34 +01:00
committed by Bjoern Jacke
parent 4d4443d1e5
commit 03b42aeb81
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
python/samba/netcmd/testparm.py
View File

@ -157,12 +157,20 @@ class cmd_testparm(Command):
valid = False
role = lp.get("server role")
charset = lp.get("unix charset").upper()
if role in ["active directory domain controller", "domain controller", "dc"] and charset not in ["UTF-8", "UTF8"]:
logger.warning(
"When acting as Active Directory domain controller, "
"unix charset is expected to be UTF-8.")
if role in ["active directory domain controller", "domain controller", "dc"]:
charset = lp.get("unix charset").upper()
if charset not in ["UTF-8", "UTF8"]:
logger.warning(
"When acting as Active Directory domain controller, "
"unix charset is expected to be UTF-8.")
vfsobjects = lp.get("vfs objects")
if vfsobjects:
for entry in ['dfs_samba4', 'acl_xattr']:
if entry not in vfsobjects:
logger.warning(
"When acting as Active Directory domain controller, " +
entry + " should be in vfs objects.")
return valid