sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-26 01:49:31 +03:00
Code Activity

ldb: Avoid calling talloc_get_type() in ldb_kv_parse_data_unpack()

Browse Source 
We have the ldb_kv in the caller, just fill it into the context and
so avoid the cost of the talloc_get_type().

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
This commit is contained in:
Andrew Bartlett
2019-04-12 11:26:01 +12:00
parent fccd9c8c94
commit 075a078d36
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/ldb/ldb_key_value/ldb_kv_search.c
View File

@ -177,6 +177,7 @@ int ldb_kv_search_base(struct ldb_module *module,
struct ldb_kv_parse_data_unpack_ctx {
struct ldb_message *msg;
struct ldb_module *module;
struct ldb_kv_private *ldb_kv;
unsigned int unpack_flags;
};
@ -190,8 +191,7 @@ static int ldb_kv_parse_data_unpack(struct ldb_val key,
struct ldb_context *ldb = ldb_module_get_ctx(ctx->module);
struct ldb_val data_parse = data;
struct ldb_kv_private *ldb_kv =
talloc_get_type(ldb_module_get_private(ctx->module), struct ldb_kv_private);
struct ldb_kv_private *ldb_kv = ctx->ldb_kv;
if ((ctx->unpack_flags & LDB_UNPACK_DATA_FLAG_NO_DATA_ALLOC)) {
if ((ldb_kv->kv_ops->options & LDB_KV_OPTION_STABLE_READ_LOCK) &&
@ -266,7 +266,8 @@ int ldb_kv_search_key(struct ldb_module *module,
struct ldb_kv_parse_data_unpack_ctx ctx = {
.msg = msg,
.module = module,
.unpack_flags = unpack_flags
.unpack_flags = unpack_flags,
.ldb_kv = ldb_kv
};
memset(msg, 0, sizeof(*msg));