sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-26 01:49:31 +03:00
Code Activity

s4:dlz make b9_has_soa check dc=@ node

Browse Source 
the zone node does not hold the dnsRecord values, so for the zone level
the node dc=@,dc=zonename has to be queried

regression introduced with 28e2a518ff, BUG: https://bugzilla.samba.org/show_bug.cgi?id=13466

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13841

Signed-off-by: Michael Saxl <mike@mwsys.mine.bz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 526c6d0be5)
This commit is contained in:
Michael Saxl
2019-03-21 18:22:38 +01:00
committed by Karolin Seeger
parent 7921aa6365
commit 0e94b0a314
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
selftest/knownfail.d/bind9-dlz
View File

@ -1,2 +0,0 @@
^samba4.dlz_bind9.configure.configure.*
^samba4.dlz_bind9.multipleconfigure.multipleconfigure.*

11
source4/dns_server/dlz_bind9.c
View File

@ -1276,6 +1276,17 @@ static bool b9_has_soa(struct dlz_bind9_data *state, struct ldb_dn *dn, const ch
return false;
}
/*
* The SOA record is alwas stored under DC=@,DC=zonename
* This can probably be removed when dns_common_lookup makes a fallback
* lookup on @ pseudo record
*/
if (!ldb_dn_add_child_fmt(dn,"DC=@")) {
talloc_free(tmp_ctx);
return false;
}
werr = dns_common_lookup(state->samdb, tmp_ctx, dn,
&records, &num_records, NULL);
if (!W_ERROR_IS_OK(werr)) {