sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-03 13:47:25 +03:00
Code

s4/dsdb/util_samr: check some return codes (CID 1444977)

Browse Source 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
This commit is contained in:
Douglas Bagnall 2019-05-08 14:52:31 +12:00 committed by Douglas Bagnall
parent cb9fe0360b
commit 215eef5b6f
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
source4/dsdb/common/util_samr.c
View File

@ -154,11 +154,20 @@ NTSTATUS dsdb_add_user(struct ldb_context *ldb,
return NT_STATUS_FOOBAR;
}
ldb_msg_add_string(msg, "sAMAccountName", account_name);
ldb_msg_add_string(msg, "objectClass", obj_class);
samdb_msg_add_uint(ldb, tmp_ctx, msg,
"userAccountControl",
user_account_control);
ret = ldb_msg_add_string(msg, "sAMAccountName", account_name);
if (ret != LDB_SUCCESS) {
goto failed;
}
ret = ldb_msg_add_string(msg, "objectClass", obj_class);
if (ret != LDB_SUCCESS) {
goto failed;
}
ret = samdb_msg_add_uint(ldb, tmp_ctx, msg,
"userAccountControl",
user_account_control);
if (ret != LDB_SUCCESS) {
goto failed;
}
/* This is only here for migrations using pdb_samba4, the
* caller and the samldb are responsible for ensuring it makes
@ -237,6 +246,11 @@ NTSTATUS dsdb_add_user(struct ldb_context *ldb,
}
talloc_free(tmp_ctx);
return NT_STATUS_OK;
failed:
ldb_transaction_cancel(ldb);
talloc_free(tmp_ctx);
return NT_STATUS_INTERNAL_ERROR;
}
/*