sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-03 04:22:09 +03:00
Code Activity

stream_terminate_connection: Prevent use-after-free

Browse Source 
This sometimes would show up as corrupted bytes during logs. Hammering
the LDAP server enough times managed to trigger an outright segfault.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Garming Sam
2017-06-09 14:13:25 +12:00
committed by Garming Sam
parent b158f68323
commit 2f045e7fc1
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source4/smbd/service_stream.c
View File

@ -55,6 +55,7 @@ void stream_terminate_connection(struct stream_connection *srv_conn, const char
struct tevent_context *event_ctx = srv_conn->event.ctx;
const struct model_ops *model_ops = srv_conn->model_ops;
struct loadparm_context *lp_ctx = srv_conn->lp_ctx;
TALLOC_CTX *frame = NULL;
if (!reason) reason = "unknown reason";
@ -77,11 +78,20 @@ void stream_terminate_connection(struct stream_connection *srv_conn, const char
return;
}
frame = talloc_stackframe();
reason = talloc_strdup(frame, reason);
if (reason == NULL) {
reason = "OOM - unknown reason";
}
talloc_free(srv_conn->event.fde);
srv_conn->event.fde = NULL;
imessaging_cleanup(srv_conn->msg_ctx);
TALLOC_FREE(srv_conn);
model_ops->terminate(event_ctx, lp_ctx, reason);
TALLOC_FREE(frame);
}
/**