sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-10-26 23:33:15 +03:00
Code Activity

r10411: we don't need the 10 times retry on rid allocation now, as

Browse Source 
transactions ensure two account creations can't interfere with each
other
(This used to be commit 91c27bc976)
This commit is contained in:
Andrew Tridgell
2005-09-22 05:31:16 +00:00
committed by Gerald (Jerry) Carter
parent f08cdba2c5
commit 37cefc8b41
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
source4/dsdb/samdb/ldb_modules/samldb.c
View File

@@ -179,7 +179,7 @@ static struct dom_sid *samldb_get_new_sid(struct ldb_module *module,
struct ldb_message **res = NULL;
const struct ldb_dn *dom_dn;
uint32_t rid;
int ret, tries = 10;
int ret;
struct dom_sid *dom_sid, *obj_sid;
/* get the domain component part of the provided dn */
@@ -213,15 +213,7 @@ static struct dom_sid *samldb_get_new_sid(struct ldb_module *module,
}
/* allocate a new Rid for the domain */
/* we need to try multiple times to cope with two account
creations at the same time */
while (tries--) {
ret = samldb_allocate_next_rid(module->ldb, mem_ctx, dom_dn, &rid);
if (ret != 1) {
break;
}
}
ret = samldb_allocate_next_rid(module->ldb, mem_ctx, dom_dn, &rid);
if (ret != 0) {
ldb_debug(module->ldb, LDB_DEBUG_FATAL, "Failed to increment nextRid of %s\n", ldb_dn_linearize(mem_ctx, dom_dn));
talloc_free(res);