sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-28 09:49:30 +03:00
Code Activity

samr4: Use <SID=%s> in GetAliasMembership

Browse Source 
As in commit 841845dea3, this avoids
quoting problems in user DN's.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11751

Signed-off-by: Mantas Mikulėnas <grawity@gmail.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Mantas Mikulėnas
2016-02-24 19:40:47 +02:00
committed by Garming Sam
parent e3fdb0a9b6
commit 37ef959f37
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
source4/rpc_server/samr/dcesrv_samr.c
View File

@ -1530,6 +1530,7 @@ static NTSTATUS dcesrv_samr_GetAliasMembership(struct dcesrv_call_state *dce_cal
struct ldb_message **res;
uint32_t i;
int count = 0;
char membersidstr[DOM_SID_STR_BUFLEN];
DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
@ -1545,19 +1546,11 @@ static NTSTATUS dcesrv_samr_GetAliasMembership(struct dcesrv_call_state *dce_cal
}
for (i=0; i<r->in.sids->num_sids; i++) {
const char *memberdn;
dom_sid_string_buf(r->in.sids->sids[i].sid,
membersidstr, sizeof(membersidstr));
memberdn = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL,
"distinguishedName",
"(objectSid=%s)",
ldap_encode_ndr_dom_sid(mem_ctx,
r->in.sids->sids[i].sid));
if (memberdn == NULL) {
continue;
}
filter = talloc_asprintf(mem_ctx, "%s(member=%s)", filter,
memberdn);
filter = talloc_asprintf(mem_ctx, "%s(member=<SID=%s>)",
filter, membersidstr);
if (filter == NULL) {
return NT_STATUS_NO_MEMORY;
}