sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-26 01:49:31 +03:00
Code Activity

s4 librpc rpc pyrpc: Fix flapping dcerpc.bare tests

Browse Source 
Commit d65b7641c8 had the parameters to
talloc_reparent reversed.  This caused the dcerpc.bare tests to flap.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13932

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed May 22 03:03:43 UTC 2019 on sn-devel-184

(cherry picked from commit 3e6661fd73)
This commit is contained in:
Gary Lockyer
2019-05-22 11:43:54 +12:00
committed by Karolin Seeger
parent 4f70d4d76a
commit 58760fe8b7
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source4/librpc/rpc/pyrpc.c
View File

@ -282,12 +282,9 @@ static void dcerpc_interface_dealloc(PyObject* self)
{
dcerpc_InterfaceObject *interface = (dcerpc_InterfaceObject *)self;
/*
* This can't fail, and if it did talloc_unlink(NULL, NULL) is
* harmless below
*/
struct tevent_context *ev_save = talloc_reparent(
NULL, interface->mem_ctx, interface->ev);
interface->mem_ctx, NULL, interface->ev);
SMB_ASSERT(ev_save != NULL);
interface->binding_handle = NULL;
interface->pipe = NULL;