sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-26 10:04:02 +03:00
Code

s3:registry: wrap reg_deletevalue() in a transaction

Browse Source 
This is at the wrong layer, but if fixes a race potentially causing
data corruption by concurrent access.

Signed-off-by: Andreas Schneider <asn@samba.org>
This commit is contained in:
Michael Adam 2012-04-12 17:52:43 +02:00 committed by Andreas Schneider
parent 97bf05871a
commit 8d19ac7474
1 changed files with 30 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
source3/registry/reg_api.c
View File

@ -802,24 +802,50 @@ WERROR reg_deletevalue(struct registry_key *key, const char *name)
return WERR_ACCESS_DENIED;
}
err = regdb_transaction_start();
if (!W_ERROR_IS_OK(err)) {
DEBUG(0, ("reg_deletevalue: Failed to start transaction: %s\n",
win_errstr(err)));
return err;
}
err = fill_value_cache(key);
if (!W_ERROR_IS_OK(err)) {
return err;
DEBUG(0, ("reg_deletevalue; Error filling value cache: %s\n",
win_errstr(err)));
goto done;
}
err = reg_value_exists(key, name);
if (!W_ERROR_IS_OK(err)) {
return err;
goto done;
}
regval_ctr_delvalue(key->values, name);
if (!store_reg_values(key->key, key->values)) {
TALLOC_FREE(key->values);
return WERR_REG_IO_FAILURE;
err = WERR_REG_IO_FAILURE;
DEBUG(0, ("reg_deletevalue: store_reg_values failed\n"));
goto done;
}
return WERR_OK;
err = WERR_OK;
done:
if (W_ERROR_IS_OK(err)) {
err = regdb_transaction_commit();
if (!W_ERROR_IS_OK(err)) {
DEBUG(0, ("reg_deletevalue: Error committing transaction: %s\n", win_errstr(err)));
}
} else {
WERROR err1 = regdb_transaction_cancel();
if (!W_ERROR_IS_OK(err1)) {
DEBUG(0, ("reg_deletevalue: Error cancelling transaction: %s\n", win_errstr(err1)));
}
}
return err;
}
WERROR reg_getkeysecurity(TALLOC_CTX *mem_ctx, struct registry_key *key,