sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-26 01:49:31 +03:00
Code Activity

s3: smbd: Ensure srvstr_pull_req_talloc() always NULLs out *dest.

Browse Source 
Robert Morris <rtm@lcs.mit.edu> noticed that in the case
where srvstr_pull_req_talloc() is being called with
buffer remaining == 0, we don't NULL out the destination
pointed which is *always* done in the codepaths inside
pull_string_talloc(). This prevents a crash in the caller.

Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15420

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Jeremy Allison
2023-08-11 10:42:41 -07:00
committed by Volker Lendecke
parent 963fd8aa9b
commit 9220c45cc1
2 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
selftest/knownfail.d/smb1_truncated_sessetup
View File

@ -1 +0,0 @@
^samba3.smbtorture_s3.smb1.SMB1-TRUNCATED-SESSSETUP.smbtorture\(fileserver_smb1\)

1
source3/smbd/smb2_reply.c
View File

@ -533,6 +533,7 @@ size_t srvstr_pull_req_talloc(TALLOC_CTX *ctx, struct smb_request *req,
ssize_t bufrem = smbreq_bufrem(req, src);
if (bufrem == 0) {
*dest = NULL;
return 0;
}