sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

s4/ldap: Fix nested searches SEGFAULT bug

Browse Source 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Kamen Mazdrashki 2010-01-25 12:22:39 +02:00 committed by Stefan Metzmacher
parent e3d50e89ab
commit a4d0ed5a10
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source4/lib/ldb/ldb_ildap/ldb_ildap.c
View File

@ -278,6 +278,13 @@ static void ildb_callback(struct ldap_request *req)
break;
case LDAP_TAG_SearchRequest:
/* check if we are already processing this request */
if (req->in_dispatch_replies) {
return;
}
req->in_dispatch_replies = true;
/* loop over all messages */
for (i = 0; i < req->num_replies; i++) {
@ -327,6 +334,7 @@ static void ildb_callback(struct ldap_request *req)
if (ret != LDB_SUCCESS) {
callback_failed = true;
}
break;
case LDAP_TAG_SearchResultReference:
@ -337,6 +345,7 @@ static void ildb_callback(struct ldap_request *req)
if (ret != LDB_SUCCESS) {
callback_failed = true;
}
break;
default:
@ -350,6 +359,8 @@ static void ildb_callback(struct ldap_request *req)
}
}
req->in_dispatch_replies = false;
talloc_free(req->replies);
req->replies = NULL;
req->num_replies = 0;

4
source4/libcli/ldap/ldap_client.h
View File

@ -37,6 +37,10 @@ struct ldap_request {
int num_replies;
struct ldap_message **replies;
/* mark while we are processing replies
* in request of type LDAP_TAG_SearchRequest */
bool in_dispatch_replies;
NTSTATUS status;
DATA_BLOB data;
struct {