sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-09 08:58:35 +03:00
Code

tests/krb5: Make arguments to get_target() keyword arguments

Browse Source 
This avoids mistakes by ensuring that passed-in arguments go to their
intended destinations.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Joseph Sutton 2023-03-03 12:02:35 +13:00 committed by Andrew Bartlett
parent 644c4ae8d0
commit ad19dd100f
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
python/samba/tests/krb5/group_tests.py
View File

@ -1828,7 +1828,8 @@ class GroupTests(KDCBaseTest):
ts_enc_padata = self.get_enc_timestamp_pa_data_from_key(preauth_key)
padata = [ts_enc_padata]
target_creds, sname = self.get_target(as_to_krbtgt, as_compression)
target_creds, sname = self.get_target(as_to_krbtgt,
compression=as_compression)
decryption_key = self.TicketDecryptionKey_from_creds(target_creds)
target_supported_etypes = target_creds.tgs_supported_enctypes
@ -1914,7 +1915,8 @@ class GroupTests(KDCBaseTest):
set_user_flags=tgs_set_user_flags,
reset_user_flags=tgs_reset_user_flags)
target_creds, sname = self.get_target(tgs_to_krbtgt, tgs_compression)
target_creds, sname = self.get_target(tgs_to_krbtgt,
compression=tgs_compression)
decryption_key = self.TicketDecryptionKey_from_creds(target_creds)
subkey = self.RandomKey(ticket.session_key.etype)

2
python/samba/tests/krb5/kdc_base_test.py
View File

@ -1825,7 +1825,7 @@ class KDCBaseTest(RawKerberosTest):
# Get the credentials and server principal name of either the krbtgt, or a
# specially created account, with resource SID compression either supported
# or unsupported.
def get_target(self, to_krbtgt, compression=None, extra_enctypes=0):
def get_target(self, to_krbtgt, *, compression=None, extra_enctypes=0):
if to_krbtgt:
self.assertIsNone(compression,
"it's no good specifying compression support "