sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-03 04:22:09 +03:00
Code Activity

r15875: Fix bug in smbclients 'put' command tridge found a while ago. Add tests

Browse Source 
for 'put' and 'get' commands so we don't break them again.

Fixes #3742
(This used to be commit 141600a624)
This commit is contained in:
Jelmer Vernooij
2006-05-24 22:15:03 +00:00
committed by Gerald (Jerry) Carter
parent e157dccfaf
commit ae67b20623
2 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source4/client/client.c
View File

@ -1194,16 +1194,16 @@ static int cmd_put(struct smbclient_context *ctx, const char **args)
char *rname;
if (!args[1]) {
d_printf("put <filename>\n");
d_printf("put <filename> [<remotename>]\n");
return 1;
}
lname = talloc_asprintf(ctx, "%s\\%s", ctx->remote_cur_dir, args[1]);
lname = talloc_strdup(ctx, args[1]);
if (args[2])
rname = talloc_strdup(ctx, args[2]);
else
rname = talloc_strdup(ctx, lname);
rname = talloc_asprintf(ctx, "%s\\%s", ctx->remote_cur_dir, lname);
dos_clean_name(rname);

24
source4/script/tests/test_smbclient.sh
View File

@ -32,14 +32,14 @@ EOF
# put that file
echo mput tmpfile | runcmd "Putting file" || failed=`expr $failed + 1`
echo mput tmpfile | runcmd "MPutting file" || failed=`expr $failed + 1`
# check file info
echo altname tmpfile | runcmd "Getting alternative name" || failed=`expr $failed + 1`
# run allinfo on that file
echo allinfo tmpfile | runcmd "Checking info on file" || failed=`expr $failed + 1`
# get that file
mv tmpfile tmpfile-old
echo mget tmpfile | runcmd "Getting file" || failed=`expr $failed + 1`
echo mget tmpfile | runcmd "MGetting file" || failed=`expr $failed + 1`
# remove that file
echo rm tmpfile | runcmd "Removing file" || failed=`expr $failed + 1`
# compare locally
@ -61,6 +61,24 @@ echo rmdir bla | runcmd "Removing directory" || failed=`expr $failed + 1`
# run fsinfo
echo fsinfo objectid | runcmd "Getting file system info" || failed=`expr $failed + 1`
rm -f tmpfile tmpfile-old
# put that file
echo put tmpfile | runcmd "Putting file" || failed=`expr $failed + 1`
# get that file
mv tmpfile tmpfile-old
echo get tmpfile | runcmd "Getting file" || failed=`expr $failed + 1`
# remove that file
echo rm tmpfile | runcmd "Removing file" || failed=`expr $failed + 1`
# compare locally
testit "Comparing files" diff tmpfile-old tmpfile || failed=`expr $failed + 1`
# put that file
echo put tmpfile tmpfilex | runcmd "Putting file with different name" || failed=`expr $failed + 1`
# get that file
echo get tmpfilex | runcmd "Getting file again" || failed=`expr $failed + 1`
# compare locally
testit "Comparing files" diff tmpfilex tmpfile || failed=`expr $failed + 1`
# remove that file
echo rm tmpfilex | runcmd "Removing file" || failed=`expr $failed + 1`
rm -f tmpfile tmpfile-old tmpfilex
testok $0 $failed