1
0
mirror of https://github.com/samba-team/samba.git synced 2025-08-03 04:22:09 +03:00

Fix valgrind errors

We need to keep the names around on the search. Probably a tdb_move would do it
here as well, but RPC is not the fastest thing on earth anyway...

Thanks to Günther for pointing that out to me!
This commit is contained in:
Volker Lendecke
2008-02-04 19:33:56 +01:00
parent 22e49ef2c0
commit c9472ae610

View File

@ -1559,8 +1559,24 @@ static bool smbpasswd_search_next_entry(struct pdb_search *search,
return false;
}
*entry = state->entries[state->current++];
entry->idx = state->entries[state->current].idx;
entry->rid = state->entries[state->current].rid;
entry->acct_flags = state->entries[state->current].acct_flags;
entry->account_name = talloc_strdup(
search->mem_ctx, state->entries[state->current].account_name);
entry->fullname = talloc_strdup(
search->mem_ctx, state->entries[state->current].fullname);
entry->description = talloc_strdup(
search->mem_ctx, state->entries[state->current].description);
if ((entry->account_name == NULL) || (entry->fullname == NULL)
|| (entry->description == NULL)) {
DEBUG(0, ("talloc_strdup failed\n"));
return false;
}
state->current += 1;
return true;
}