sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-21 09:49:28 +03:00
Code Activity

s3:libads: Alloc ads->server.realm under ADS_STRUCT talloc context

Browse Source 
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Samuel Cabrero
2022-06-10 15:04:51 +02:00
committed by Jeremy Allison
parent e60d2bc8c8
commit cdef601150
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
source3/libads/ads_struct.c
View File

@ -130,7 +130,6 @@ static void ads_destroy(ADS_STRUCT **ads)
#ifdef HAVE_LDAP
ads_disconnect(*ads);
#endif
SAFE_FREE((*ads)->server.realm);
SAFE_FREE((*ads)->server.workgroup);
SAFE_FREE((*ads)->server.ldap_server);
@ -178,7 +177,13 @@ ADS_STRUCT *ads_init(TALLOC_CTX *mem_ctx,
ads_zero_ldap(ads);
#endif
ads->server.realm = realm? SMB_STRDUP(realm) : NULL;
ads->server.realm = talloc_strdup(ads, realm);
if (realm != NULL && ads->server.realm == NULL) {
DBG_WARNING("Out of memory\n");
TALLOC_FREE(ads);
return NULL;
}
ads->server.workgroup = workgroup ? SMB_STRDUP(workgroup) : NULL;
ads->server.ldap_server = ldap_server? SMB_STRDUP(ldap_server) : NULL;
@ -223,4 +228,4 @@ bool ads_set_sasl_wrap_flags(ADS_STRUCT *ads, unsigned flags)
ads->auth.flags = flags | other_flags;
return true;
}
}