sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-30 19:42:05 +03:00
Code Activity

param: change the talloc context attached to globals structure in s3 loadparm to a pool

Browse Source 
With many allocations being made, with many empty strings in loadparm, it should be more
effective to use a talloc pool instead of a normal talloc context.

The numbers chosen are based around a simple testparm instance.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-on: https://gerrit.samba.org/157
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Garming Sam
2014-02-27 15:20:06 +13:00
committed by Jeremy Allison
parent 2dd7c89079
commit e812b726cd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source3/param/loadparm.c
View File

@ -678,7 +678,7 @@ static void init_globals(bool reinit_globals)
* table once the defaults are set */
ZERO_STRUCT(Globals);
Globals.ctx = talloc_new(NULL);
Globals.ctx = talloc_pooled_object(NULL, char, 272, 2048);
for (i = 0; parm_table[i].label; i++) {
if ((parm_table[i].type == P_STRING ||