sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-24 13:57:43 +03:00
Code

sharesec: don't leak state_path onto talloc tos

Browse Source 
Also check for allocation failures.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
David Disseldorp 2014-11-02 20:21:25 +01:00 committed by Jeremy Allison
parent a852116ab3
commit f62d9080ad
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source3/lib/sharesec.c
View File

@ -142,19 +142,27 @@ bool share_info_db_init(void)
int32 vers_id = 0;
bool upgrade_ok = true;
NTSTATUS status;
char *db_path;
if (share_db != NULL) {
return True;
}
share_db = db_open(NULL, state_path("share_info.tdb"), 0,
db_path = state_path("share_info.tdb");
if (db_path == NULL) {
return false;
}
share_db = db_open(NULL, db_path, 0,
TDB_DEFAULT, O_RDWR|O_CREAT, 0600,
DBWRAP_LOCK_ORDER_1, DBWRAP_FLAG_NONE);
if (share_db == NULL) {
DEBUG(0,("Failed to open share info database %s (%s)\n",
state_path("share_info.tdb"), strerror(errno) ));
db_path, strerror(errno)));
TALLOC_FREE(db_path);
return False;
}
TALLOC_FREE(db_path);
status = dbwrap_fetch_int32_bystring(share_db, vstring, &vers_id);
if (!NT_STATUS_IS_OK(status)) {