1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

20259 Commits

Author SHA1 Message Date
Jeremy Allison
0362fde476 r17899: Fix Stanford checker bug - possible null deref.
Jeremy.
(This used to be commit e779491751)
2007-10-10 11:38:57 -05:00
Jeremy Allison
8e0a4e7e6f r17897: Store the uid in the memory creds. Don't request the
krb5 refresh creds when doing cached NTLM auth, request
the memory creds instead.
Jeremy.
(This used to be commit 310ac0b226)
2007-10-10 11:38:57 -05:00
Volker Lendecke
49a08c7c5a r17896: Reformatting. I did not want to do it anymore, but these ones looked just
silly :-)

Volker
(This used to be commit 8b6f5937db)
2007-10-10 11:38:57 -05:00
Volker Lendecke
c52b3fb89f r17881: Another microstep towards better error reporting: Make get_sorted_dc_list
return NTSTATUS.

If we want to differentiate different name resolution problems we might want
to introduce yet another error class for Samba-internal errors. Things like no
route to host to the WINS server, a DNS server explicitly said host not found
etc might be worth passing up.

Because we can not stash everything into the existing NT_STATUS codes, what
about a Samba-specific error class like NT_STATUS_DOS and NT_STATUS_LDAP?

Volker
(This used to be commit 60a166f034)
2007-10-10 11:38:57 -05:00
Volker Lendecke
e09daab015 r17880: On host "tridge" in the build farm the tests fail because smbd hangs in in
'connecting to cups server on localhost'. There is no cups on that host, but
the TCP connection hangs in SYN_SENT. Probably some firewall rule.

Work around that.

Volker
(This used to be commit ab4e7b34da)
2007-10-10 11:38:57 -05:00
Jeremy Allison
00ffc8ec93 r17879: Make it explicit that we can never pass NULL for buflen or stringlen.
Stanford Checker fix.
Jeremy.
(This used to be commit 2d8bdd2dce)
2007-10-10 11:38:57 -05:00
Jeremy Allison
2eff779b17 r17878: Fix possible null deref found by Stanford checker.
Jeremy.
(This used to be commit ae20201494)
2007-10-10 11:38:56 -05:00
Jeremy Allison
4d6b8ac087 r17877: Make it explicit to the checker that we can never pass
in NULL as ctr to a void returning fn.
Jeremy.
(This used to be commit 397ab2b1ab)
2007-10-10 11:38:56 -05:00
Jeremy Allison
9ab430ac4b r17875: Fix (rather theoretical, but still...) null deref found by
Stanford checker.
Jeremy.
(This used to be commit 45d77ae122)
2007-10-10 11:38:56 -05:00
Jeremy Allison
41d1f322f8 r17874: Fix possible null deref found by Stanford checker.
Jeremy.
(This used to be commit 2894310cc8)
2007-10-10 11:38:56 -05:00
Jeremy Allison
981588d579 r17873: Fix possible null deref found by Stanford checker.
Jeremy.
(This used to be commit 1adb3b2432)
2007-10-10 11:38:56 -05:00
Jeremy Allison
b65eb11a2e r17872: Fix possible null deref found by the Stanford checker.
Jeremy.
(This used to be commit ac06fc42cb)
2007-10-10 11:38:56 -05:00
Jeremy Allison
28369f04b4 r17869: More sensible fix for Stanford Checker null deref.
Jeremy.
(This used to be commit 2a73e82f96)
2007-10-10 11:38:55 -05:00
Jeremy Allison
5f925a0190 r17867: Fix null deref in error code path. Found by the
Stanford checker.
Jeremy.
(This used to be commit 09652dc71c)
2007-10-10 11:38:55 -05:00
Jeremy Allison
767820e462 r17866: Fix possible null deref - found by Stanford checker.
Jeremy.
(This used to be commit 84e8cc0593)
2007-10-10 11:38:55 -05:00
Jeremy Allison
8be6458368 r17865: Fix what the Stanford checker reported as a possible
deref. I think this is a false positive, but it's
an easy extra check to add here.
Jeremy.
(This used to be commit 7d3b11ab18)
2007-10-10 11:38:55 -05:00
Jeremy Allison
6f9ce7def7 r17864: Fix possible null deref if client doesn't give us
an answer record. Found by the Stanford checker.
Jeremy.
(This used to be commit 1ec77c5011)
2007-10-10 11:38:55 -05:00
Jeremy Allison
6ee700bd65 r17863: Fix unneeded NULL check on pointer parameters causing the
Stanford checker to flag null deref.
Jeremy.
(This used to be commit b7fc023e90)
2007-10-10 11:38:54 -05:00
Jeremy Allison
fb0ed72caa r17862: Fix possible NULL deref (like rev 17861) found by the
Stanford group.
Jeremy.
(This used to be commit cfd39c2804)
2007-10-10 11:38:54 -05:00
Jeremy Allison
16c8f09a1f r17861: Fix inconsistency found in checking for NULL in DLIST_REMOVE
macro. Don't check for NULL if we would have already derefed.
Jeremy.
(This used to be commit 1cb379315a)
2007-10-10 11:38:54 -05:00
Volker Lendecke
cb3e14d5a2 r17855: Fix the build on systems without LDAP
(This used to be commit 2e9f5c520a)
2007-10-10 11:38:54 -05:00
Volker Lendecke
4bbb995e8d r17854: Steal the LDAP in NTSTATUS trick from Samba4
Thanks to Michael Adam <ma@sernet.de>

Volker
(This used to be commit 91878f9b6f)
2007-10-10 11:38:54 -05:00
Volker Lendecke
5d4a189d4e r17853: Fix an uninitialized variable (m_time2). Jeremy, please check.
Thanks,

Volker
(This used to be commit 389910b2d3)
2007-10-10 11:38:54 -05:00
Volker Lendecke
c3bbcc608e r17852: Remove a pointless NULL assignment
(This used to be commit 9f27824257)
2007-10-10 11:38:53 -05:00
Volker Lendecke
2868e7f99b r17851: Fix a warning & attempt to fix the Tru64 build
(This used to be commit b05cac3cb5)
2007-10-10 11:38:53 -05:00
Volker Lendecke
5196825b4c r17850: Another dummy checkin for the build farm to retry
(This used to be commit ac7087a651)
2007-10-10 11:38:53 -05:00
Volker Lendecke
8f9a26cb40 r17847: Dummy commit
(This used to be commit cdcea36095)
2007-10-10 11:38:53 -05:00
Volker Lendecke
f60a0a9fd3 r17845: Remove a Solaris warning
(This used to be commit ec42ec31c0)
2007-10-10 11:38:53 -05:00
Jeremy Allison
e627362622 r17837: Split out the storing of memory cached credentials
from the krb5 ticket renewal code. This allows cached
credentials to be stored for single sign-on via ntlm_auth
for machines in a domain still using NTLM. Also (hopefully)
fixes the reference counting problem with pam_logon/logoff
so multiple logons/logoffs won't lose cached credentials.
This compiles, but I'm intending to test it over the weekend
so don't complain too much :-). I also want it in the tree
so Coverity can scan it for errors. Guenther, check this over
please - I ran through the architecture with Jerry and he's
ok with it, but this is modifying your code a lot.
Jeremy.
(This used to be commit 679eeeb911)
2007-10-10 11:38:53 -05:00
Volker Lendecke
47e29ebe09 r17836: Don't create zombies in the children, thanks to Jeremy!
Volker
(This used to be commit c0767c08d0)
2007-10-10 11:38:53 -05:00
Volker Lendecke
9230c659f6 r17835: Fix Coverity bugs 306, 309, 310.
Jeremy, you might want to look at the trans2 one.

Volker
(This used to be commit d727fc681c)
2007-10-10 11:38:52 -05:00
Jeremy Allison
6365dcef4d r17834: Another bug found by Volker's tests in the build farm !
Correctly map large nt timevals to TIME_T_MAX.
Jeremy.
(This used to be commit 63b13d2879)
2007-10-10 11:38:52 -05:00
Volker Lendecke
d59fe2834e r17833: Next step to fix the build farm.
Jerry, why don't you include "includes.h"?

Thanks,

Volker
(This used to be commit c02970c272)
2007-10-10 11:38:52 -05:00
Volker Lendecke
ea4ff9bf23 r17832: Fix bug 4050
(This used to be commit 0504cf6d13)
2007-10-10 11:38:52 -05:00
Volker Lendecke
b9142f20df r17831: Attempt to fix the build farm: 0x7fffffffffffffff needs special casing too I
think. This broke 'make test' because the newly created user was set to be
kicked off Mi, 22 Jan 1975 23:55:33 CET (unix time 159663333) with the
setuserinfo21 call.

I'm not 100% sure that 0x7ff... means max time as I do it here, I vaguely
remember it to mean "don't touch".

Does anybody know that for sure?

Jeremy, please check this.

Thanks,

Volker
(This used to be commit 872d1299eb)
2007-10-10 11:38:52 -05:00
Jelmer Vernooij
c3178f6a1e r17819: Add some more ignores.
(This used to be commit 8ffe178930)
2007-10-10 11:38:52 -05:00
Jeremy Allison
94af1ad542 r17818: Fixup uint64 time calc. NT time is a 64 bit number,
not high value seconds, low value 100ns units.
Jeremy.
(This used to be commit ead75870d5)
2007-10-10 11:38:52 -05:00
Jelmer Vernooij
fcf90b6dce r17817: Disable compilation of LIBNDR (it uses uint64_t).
(This used to be commit 4928d560b0)
2007-10-10 11:38:51 -05:00
Jelmer Vernooij
17ed5d07f4 r17816: Merge my cupsprot branch. It is now possible to (optionally) specify :port in
the "cups server" smb.conf parameter.
(This used to be commit 3f665f4ec4)
2007-10-10 11:38:51 -05:00
Gerald Carter
f8f1ed21db r17815: Revert Volker's change in 16014. I really do not believe
the this should be necessary.  If there is still a bug,
I believe that setting thr group RID from the passdb is
masking it.  Not fixing it.  It is very likely that
the change was necessary before but is no longer
with the recent changes.  But I'm not taking the chance
of merging it to 3.0.23c. :-)
(This used to be commit 1a5b90f3c1)
2007-10-10 11:38:51 -05:00
Jelmer Vernooij
6287ce43f6 r17814: Add .bzrignore file
(This used to be commit 5018bb91e7)
2007-10-10 11:38:51 -05:00
Gerald Carter
40b1bd3091 r17813: Remove another instance of manually setting the group SID.
The would have been primaryly used when adding a user to
an smbpasswd file, but could have been introduce to other
backends by using pdbedit -i -e.

The symptom was

[2006/08/09 13:07:43, 0] rpc_parse/parse_samr.c:init_sam_user_info21A(6276)
  init_sam_user_info_21A: User nobody has Primary Group SID S-1-22-2-99,
  which conflicts with the domain sid S-1-5-21-1825997848-4107600307-1754506280.
  Failing operation.
(This used to be commit 0a3aa8b43a)
2007-10-10 11:38:51 -05:00
Jeremy Allison
b377324050 r17812: Fix bad unsigned comparisons with TIME_T_MIN/TIME_T_MAX.
Jeremy.
(This used to be commit bd1fbdfb82)
2007-10-10 11:38:50 -05:00
Jelmer Vernooij
08b63552be r17810: Use datarootdir variable generated by newer autoconf versions. (fixes warning)
(This used to be commit 836f04134f)
2007-10-10 11:38:50 -05:00
Jeremy Allison
01bb24624d r17809: Add in 64-bit integer time calculations (taken from
Samba4) for machines that have 64-bit integers. Leave
the (double) code for machines that don't. Needs
testing.... :-).
Jeremy.
(This used to be commit 9e65c175b0)
2007-10-10 11:38:49 -05:00
Volker Lendecke
22c7238825 r17807: Fix a file descriptor leak pointed out by John Malmberg. Thanks!
Volker
(This used to be commit fac007ccbe)
2007-10-10 11:38:49 -05:00
Jelmer Vernooij
8d5e7367b1 r17806: Make NTTIME a UINT64_S rather than a separate structure consisting of
two uint32s.
(This used to be commit 3556a9c26c)
2007-10-10 11:38:49 -05:00
Volker Lendecke
49a3f72ebb r17805: Sorry Jerry, I could not stand the warnings... :-)
(This used to be commit f5fcafd77e)
2007-10-10 11:38:49 -05:00
Volker Lendecke
25a685b71a r17804: Fix a enum/int mixup found by the IRIX compiler.
Volker
(This used to be commit 3a1cf62376)
2007-10-10 11:38:49 -05:00
Gerald Carter
0d1e4dc5b0 r17803: finally get the new libaddns code to build on Solaris 9
(This used to be commit 6a4f4ce016)
2007-10-10 11:38:49 -05:00