Volker Lendecke
0af02db6f2
packet_struct is used in several places as raw memory
...
-> Fix more uninitialized variable warnings
2007-12-19 17:15:45 +01:00
Volker Lendecke
ff644cfa1b
Some paranoia checks
2007-12-19 16:57:48 +01:00
Volker Lendecke
9ec4f91f35
Zero the tdb key, there might be padding
...
This leads to uninitialized variable warnings if nmbd is run under valgrind.
2007-12-19 16:57:40 +01:00
Volker Lendecke
93f3a1172a
Today is not my day...
...
dmapi.c certainly did compile now...
2007-12-19 16:30:36 +01:00
Volker Lendecke
b8db804e07
Rename cache.[ch] to memcache.[ch]
...
cache.h conflicts with an XFS DMAPI include on "opi" :-(
2007-12-19 16:07:19 +01:00
Günther Deschner
7b52864787
Merge WERR_NO_SUCH_LOGON_SESSION from Samba4.
...
Guenther
2007-12-19 11:15:29 +01:00
Günther Deschner
6ccbf67a0c
Add and use some keystr functions using talloc_tos() in secrets api.
...
Guenther
2007-12-19 11:15:17 +01:00
Günther Deschner
289151393a
Add cmd_wkssvc_enumeratecomputernames to rpcclient.
...
Guenther
2007-12-19 11:15:05 +01:00
Jeremy Allison
4056bb8645
Two more static fstrings gone.
...
Jeremy.
2007-12-18 18:16:40 -08:00
Jeremy Allison
c378c3edc1
Remove last_message completely as it's no longer used.
...
Jeremy.
2007-12-18 18:10:09 -08:00
Jeremy Allison
f9182bbe62
Remove another static fstring.
...
Jeremy.
2007-12-18 18:01:34 -08:00
Jeremy Allison
39f3efbcc5
We've finished with the old node once we've copied the
...
keyval.
Jeremy.
2007-12-18 17:30:02 -08:00
Jeremy Allison
12cce3be2a
Fix valgrind error in dbwrap_rbt where rec_priv->node was
...
being accessed after free. VALOKER PLEASE CHECK THIS VERY
CAREFULLY !!!! This is a correct fix in that it fixes the
valgrind error, but it looks inelegant to me. I think if
I understood this code better I could craft a more subtle
fix. Still looking at it....
Jeremy.
2007-12-18 16:03:57 -08:00
Michael Adam
2a0585d309
Fix an error when accessing unallocated sid in error path.
...
Michael
2007-12-18 16:33:35 +01:00
Volker Lendecke
0dc4d6a8de
Add forgotten cache.h
2007-12-18 10:10:46 +01:00
Volker Lendecke
7a911b3571
Add a in-memory cache
...
This is a more general API that caches data with a LRU scheme. See
include/cache.h. No comments yet, I'm still working on it. But Jeremy has given
me a hint in one of his checkins that he would like to make use of this now.
The idea is that we get rid of all our silly little caches and merge them all
into one cache that we can then very easily trim, for example even with a
smbcontrol message if someone decides memory is tight. The main user is the
stat cache, this patch also converts the getwd cache. More caches to come.
2007-12-18 09:56:04 +01:00
Michael Adam
6a7f2a59fc
Fix a debug message: add missing space.
...
Michael
2007-12-18 07:58:37 +01:00
Rishi Srivatsavai
db74b99d0e
Add smbclient support for basic mDNS browsing.
...
Patch from Rishi Srivatsavai (bugzilla #4150 ), with tallocification
and minor syle changes by me.
2007-12-17 22:09:09 -08:00
Jeremy Allison
92acc0115d
More static pstring elimination.
...
Jeremy.
2007-12-17 18:32:27 -08:00
Jeremy Allison
b4dfec09e8
More static fstring elimination.
...
Jeremy.
2007-12-17 18:00:43 -08:00
Jeremy Allison
97cfdae405
Remove more static fstrings (yes this little cache should be
...
in the rbtree....).
Jeremy.
2007-12-17 17:27:29 -08:00
Jeremy Allison
299ea5d122
Correctly define prototypes for accessor functions.
...
Jeremy.
2007-12-17 17:13:31 -08:00
Jeremy Allison
8223624fea
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
2007-12-17 17:03:07 -08:00
Jeremy Allison
dcf624aa02
More static fstring removal.
...
Jeremy.
2007-12-17 17:02:48 -08:00
Michael Adam
7c9fa597d6
Fix logic error in cm_connect_sam().
...
Don't fall back to schannel when trust creds could be obtained.
This is still not complete, but I am getting closer.
Michael
2007-12-18 01:55:48 +01:00
Michael Adam
0a9874c1c7
Prevent another segfault.
...
Michael
2007-12-18 01:30:52 +01:00
Jeremy Allison
4ae4b23586
Use the %*s feature of snprintf to remove anothe static fstring.
...
Jeremy.
2007-12-17 16:20:44 -08:00
Gerald (Jerry) Carter
194c4640b1
Fix a segv in winbindd caused by trying to free an fstring.
...
Make a copy of the machine_password and machine_account strings
in all conditional paths so that SAFE_FREE() will always be valid.
2007-12-17 17:33:48 -06:00
Michael Adam
7f6593cdde
Do not close netlogon pipe in get_schannel_session_key_common().
...
This removes one forgotten call of cli_rpc_pipe_close(netlogon_pipe).
Correction of e77c4022cf
.
Michael
2007-12-17 23:27:53 +01:00
Simo Sorce
e940537d5b
Merge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-simo
2007-12-17 15:26:16 -05:00
Simo Sorce
814c1b0e00
While 'data' is usually 0 terminated, nothing in the spec requires that. The correct way is to copy only 'length' bytes.
...
Simo.
2007-12-17 15:26:08 -05:00
Jeremy Allison
545cd2139c
Fix bug #5121 (unix passwd sync not working on a streams based
...
system).
Jeremy.
2007-12-17 10:44:09 -08:00
Simo Sorce
6b1a118eaa
Merge in J.Layton patch and resolve conflict.
2007-12-17 09:43:18 -05:00
Michael Adam
91be824d2b
Remove direct caller of secrets_fetch_trusted_domain_password().
...
This is a regession introduced by f7efc0eca9
.
This calls pdb_get_trusteddom_pw() instead, again.
Michael
2007-12-17 14:51:37 +01:00
Michael Adam
5249b3d204
Reformat: Remove trailing spaces.
...
Michael
2007-12-17 13:25:49 +01:00
Michael Adam
d466a5136d
Make usage message for net sam rights list a little more precise.
...
Michael
2007-12-17 13:23:05 +01:00
Michael Adam
f7efc0eca9
Fix for bug #4801 : Correctly implement lsa lookup levels for lookupnames.
...
This patch is still incomplete in that winbindd does not walk
the the trusted domains to lookup unqualified names here.
Apart from that this fix should be pretty much complete.
Michael
2007-12-17 13:06:13 +01:00
Michael Adam
46bfbf5c8a
Fix flags in caller of lookup_name() in create_builtin_administrators().
...
Michael
2007-12-17 13:06:09 +01:00
Michael Adam
6d0db17a9e
Fix flags in all callers of lookup_name() in net_sam.c.
...
Michael
2007-12-17 13:06:01 +01:00
Michael Adam
1d4e0ad114
Fix flags in call of lookup_name() in srv_samr_nt.c: can_create().
...
Use LOOKUP_NAME_LOCAL instead of LOOKUP_NAME_ISOLATED.
Michael
2007-12-17 13:05:54 +01:00
Michael Adam
280d6cb6c8
Fix flags in call of lookup_name() in pdb_default_create_alias().
...
Use new flag LOOKUP_NAME_LOCAL.
Michael
2007-12-17 13:05:45 +01:00
Michael Adam
cd8c005744
Add combined flag LOOKUP_NAME_LOCAL.
...
Presence of LOOKUP_NAME_ISOLATED as the only flag is not the sign
for doing local lookups only but the sign for allowing lookups
of unqualified names. The correct sign is absence of the flag
LOOKUP_NAME_REMOTE.
Michael
2007-12-17 13:05:29 +01:00
Volker Lendecke
b89f87242b
Remove t_doschar.c
2007-12-17 07:18:30 +01:00
Jeremy Allison
2a700c5a57
Remove another static string and static passwd.
...
Jeremy.
2007-12-16 18:32:03 -08:00
Jeremy Allison
898c56c0ea
Remove a static fstring.
...
Jeremy.
2007-12-16 18:02:32 -08:00
Volker Lendecke
0bfea7259e
get rid of doschar_table[]
...
If I'm not completely blind, then check_dos_char is *only* used in the case
when we can't mmap() valid.dat. To me this looks as if we initialize the 65536
bits in doschar_table[] with check_dos_char_slowly, use it once to initialize
valid_table[] and *never* use them again. I think there's no point in keeping
these 8k of modified memory around for an unlikely case (no "valid.dat") and
even that only to use it exactly once.
2007-12-16 10:57:01 -08:00
Volker Lendecke
a8948e0727
Tiny fixes to init_valid_table()
2007-12-16 10:57:00 -08:00
Volker Lendecke
b6d1d24288
Make init_doschar_table() static
...
It's only called directly before init_valid_table() anyway, so move it there.
2007-12-16 10:56:58 -08:00
Volker Lendecke
99c59e809e
Make check_dos_char static
...
It's only called in t_doschar, a pretty bogus test program that is not compiled
by default
2007-12-16 10:56:55 -08:00
Volker Lendecke
ced0c42f05
make use of unmarshall_sec_desc
2007-12-16 14:15:16 +01:00