1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

39 Commits

Author SHA1 Message Date
Volker Lendecke
1295e2b754 README.Coding: Approve DBG statements using dom_sid_str_buf
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2018-11-22 08:22:18 +01:00
Gary Lockyer
47e5724971 README.Coding disable include sorting in clang format
Update the clang format configuration to disable include sorting. This
is enabled by default and breaks samba code.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Tue Jul 10 04:40:51 CEST 2018 on sn-devel-144
2018-07-10 04:40:51 +02:00
Björn Baumbach
396f123121 README.Coding: Fix link to Python coding style guide (PEP 8)
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: David Mulder <dmulder@suse.com>

Autobuild-User(master): Björn Baumbach <bbaumbach@samba.org>
Autobuild-Date(master): Thu Jun 28 15:04:44 CEST 2018 on sn-devel-144
2018-06-28 15:04:44 +02:00
Douglas Bagnall
8ca43ec8e2 README.Coding: remove reference to non-existent prog_guide4.txt
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2018-03-23 07:28:25 +01:00
Douglas Bagnall
cd1136f39b README.Coding: mention compatible Python versions
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2018-03-23 07:28:24 +01:00
Uri Simchoni
614f5a041e README.Coding: codify line splitting on function calls
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Mar 13 01:48:21 CET 2018 on sn-devel-144
2018-03-13 01:48:21 +01:00
Ralph Boehme
62925cfa6e README.Coding: add "Error and out logic"
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Simo <simo@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Aug 10 14:36:01 CEST 2017 on sn-devel-144
2017-08-10 14:36:01 +02:00
Uri Simchoni
a7821482ec README.Coding: Add clang-format style file
Add how the coding style is represented in clang-format directives.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct  4 05:43:18 CEST 2016 on sn-devel-144
2016-10-04 05:43:18 +02:00
Uri Simchoni
533b1210ea README.Coding: Add rule about function declaration indentation
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-10-04 02:00:24 +02:00
Uri Simchoni
1b5dd78c7b README.Coding: Remove an extra space
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-10-04 02:00:23 +02:00
Andreas Schneider
279d249976 README.Coding: Improve pointer example
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Feb 15 20:52:24 CET 2016 on sn-devel-144
2016-02-15 20:52:24 +01:00
Andreas Schneider
dae1a9fdb5 README.Coding: Add a boolean example we use very often
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2016-02-15 17:42:13 +01:00
Christof Schmitt
41fe3cfcb5 README.Coding: Update section about debug macros
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-10-21 23:13:17 +02:00
Ralph Boehme
6c81ecc795 README.Coding: initialize pointers
Pointers must be initialized to NULL.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-10-20 20:22:22 +02:00
Andreas Schneider
852fda9cb5 CodingStyle: Update example to use our coding practice.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Jan 20 18:51:55 CET 2015 on sn-devel-104
2015-01-20 18:51:55 +01:00
Volker Lendecke
8536022a51 README.Coding: Add hint for if-statments
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Jan 19 13:25:12 CET 2015 on sn-devel-104
2015-01-19 13:25:12 +01:00
Jelmer Vernooij
3f04ec3f1c Remove mention of compatibility with Python 2.4.
Change-Id: I1f900e550f4fbed9d7b3ffdbf30aa5b54e799331
Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
2014-08-31 21:21:13 +02:00
Volker Lendecke
0eaae1a87f README.Coding: Add __func__
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Nov 11 16:08:09 CET 2013 on sn-devel-104
2013-11-11 16:08:09 +01:00
Volker Lendecke
be300b0588 Coding: Add comment disproving control-flow changing macros 2012-09-26 16:29:28 +02:00
Jelmer Vernooij
27afc3e578 CodingStyle: Add some notes about Python 2.4 compatibility. 2011-10-14 00:22:57 +02:00
Jelmer Vernooij
25054a3071 README.Coding: Mention that PEP8 is the standard for Python code.
Almost all of our existing code is PEP8, and virtually every other free software
project in Python uses PEP8.
2011-07-23 22:08:09 +02:00
Stefan Metzmacher
c6a6d884f9 README.Coding: fix typos
Thanks to Michael Wood <esiotrot@gmail.com> for the review.

metze
2010-07-10 14:15:08 +02:00
Stefan Metzmacher
1c2ff4563d README.Coding: add examples for good and bad comments
metze
2010-07-10 11:18:19 +02:00
Matthias Dieter Wallnöfer
82bedb5cb4 README.Coding - cosmetic changes
- Fix typos
- Wrap lines
- Remove trailing whitespaces
- use ":" instead of "::" - one colon should in all cases be enough
2010-05-11 15:00:40 +02:00
Stefan Metzmacher
b8c414b35f README.Coding: fix good example
metze
2010-05-11 08:03:56 +02:00
Kai Blin
054833a892 README.coding: Update rules about code blocks and braces. 2009-11-18 11:44:50 +01:00
Stefan Metzmacher
adff5ef28f README.Coding: add section about usage of helper variables
metze
2009-11-16 10:52:27 +01:00
Stefan Metzmacher
6c6c8e91ef README.Coding: fix error in "good example"
metze
2009-11-16 10:51:31 +01:00
Volker Lendecke
8e2bbb8a33 Mention typedef struct in README.Coding 2009-11-14 12:56:30 +01:00
Matt Kraai
e8d2fe327d README.Coding: Fix typos. 2009-11-10 09:57:17 +01:00
Jelmer Vernooij
4bf988105b README: Fix indentation of bullet point.
README.Coding: Use consistent header.
2009-06-03 16:26:29 +02:00
Jelmer Vernooij
d56a81f60a Update to refer to 3 and 4, not just Samba 3. 2008-10-01 17:27:42 +02:00
Jelmer Vernooij
cb16488cb1 Fix path, typo. 2008-09-18 19:18:13 +02:00
Karolin Seeger
54d8b50904 README.Coding: A few minor fixes.
Karolin
(This used to be commit e61c6963cc)
2008-08-05 12:55:20 +02:00
Michael Adam
a4137c3555 r25378: Add a vim configuration example to highlight overly long lines.
(This used to be commit 95b7404836)
2007-10-10 12:31:01 -05:00
Gerald Carter
2e30a02575 r25156: Update coding guiding wrt to primitive data types
(This used to be commit 01d4274490)
2007-10-10 12:30:46 -05:00
Lars Müller
26502733a5 r23705: Add suggestion for vim from Andreas 'GlaDiaC' Schneider to show tabs,
trailing whitespace, and continued lines visually.
(This used to be commit 6209ae79de)
2007-10-10 12:23:46 -05:00
Gerald Carter
1eb031c8d6 r23645: add examples and try to answer some common questions in the coding style guide
(This used to be commit c955151bb3)
2007-10-10 12:23:40 -05:00
Gerald Carter
44b33a0411 r23636: Adding coding style guide for Samba 3.0 branches (no differences from Tridge's prog_guide.txt so we should have a similar style throughout the project)
(This used to be commit ff1c2fdc08)
2007-10-10 12:23:39 -05:00