1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

23293 Commits

Author SHA1 Message Date
Stefan Metzmacher
10cb1b87ed r25230: sync lib/talloc with SAMBA_4_0
metze
(This used to be commit 84ebb6cac224cabf3856a632de80a8a9c687329b)
2007-10-10 12:30:52 -05:00
Stefan Metzmacher
42349190b7 r25227: Patch from "Steven Danneman" <steven.danneman@isilon.com>:
-
We ran across a bug joining our Samba server to a Win2K domain with LDAP
signing turned on.  Upon investigation I discovered that there is a bug
in Win2K server which returns a duplicated responseToken in the LDAP
bindResponse packet.  This blob is placed in the optional mechListMIC
field which is unsupported in both Win2K and Win2K3.  You can see RFC
2478 for the proper packet construction.  I've worked with metze on this
to confirm all these finding.

This patch properly parses then discards the mechListMIC field if it
exists in the packet, so we don't produce a malformed packet error,
causing LDAP signed joins to fail.  Also attached is a sniff of the
domain join, exposing Win2Ks bad behavior (packet 21).
-

(I've just changed the scope of the DATA_BLOB mechList)

metze
(This used to be commit 200b5bfb8180af09446762e915eac63d14c6c7b0)
2007-10-10 12:30:52 -05:00
Michael Adam
0d1e7e97d3 r25226: Get rid of more red bars...
(This used to be commit aa603bcc6c848de67ea07d6028ab841a8401d9ad)
2007-10-10 12:30:52 -05:00
Michael Adam
0ed9c5569a r25225: Add a debug message.
Michael
(This used to be commit 7238884c2cb25dd9279703004ffab6618715a275)
2007-10-10 12:30:52 -05:00
Michael Adam
c57da5d796 r25224: Fix a potential segfault in lsa_lookupsids client code due to
uninitialized data.

Michael
(This used to be commit b4fff6d09d17a18eae61e8ca789f128cd094ba09)
2007-10-10 12:30:51 -05:00
Michael Adam
5bf7692997 r25223: Fix behaviour of rpccli_lsa_lookupsids_all() when
rpccli_lsa_lookupsids_noalloc() returns an error for one hunk
of SIDs: free all allocated arrays and return the error code
returned by the hunk lookup.

Michael
(This used to be commit 2c68ebd6934206186dc6e635401f66c2fd1e1234)
2007-10-10 12:30:51 -05:00
Jeremy Allison
3d5f029ead r25222: Fix last assumptions that (size_t)-1 can be used
as a special dest_len of sizeof(pstring).
Jeremy.
(This used to be commit 9fc14c83cc5e3a360464c33e26b1073db63763d7)
2007-10-10 12:30:51 -05:00
Michael Adam
34af42e87e r25201: Fight those red bars...
(This used to be commit cc4599fdc1fb9aa51f6a4487cb1aa78a5556757a)
2007-10-10 12:30:51 -05:00
Michael Adam
75f82d454f r25200: Fix a debug message.
(This used to be commit f1f4758e2c40a470c19b4b738f79ec5807522909)
2007-10-10 12:30:51 -05:00
Jeremy Allison
38ffbd2893 r25199: Remove pstring from strdup_upper - make it the
same as talloc_strdup_upper.
Jeremy.
(This used to be commit db1b6293771755f20660b071aac0284638dbed46)
2007-10-10 12:30:51 -05:00
Michael Adam
4dc265d6a0 r25198: Change net_rpc_join_ok() to return NTSTATUS for better
error propagation.

Michael
(This used to be commit 5a16da2185f07d1f48fabd93a7a6b8f2d6b91089)
2007-10-10 12:30:50 -05:00
Michael Adam
1130482add r25197: Change net_make_ipc_connection() and net_make_ipc_connection_ex() to
return NTSTATUS to allow for better error propagation.

Michael
(This used to be commit 46093004a788dae83a4ddb888ca5d72f555c236c)
2007-10-10 12:30:50 -05:00
Jeremy Allison
4f051e735b r25195: Fix issue with calling pull_uc2_*alloc with
str_len == 0. We should just return 0 in this
case.
Jeremy.
(This used to be commit 8bb85f3f141f0f45b06d28f004cb2cf18252d4e1)
2007-10-10 12:30:50 -05:00
Volker Lendecke
ad97bcf813 r25184: Fix some C++ warnings and an uninitialized variable
(This used to be commit b64df8a3c504ab7749c21ffb26e4771a9a0a328f)
2007-10-10 12:30:49 -05:00
Stefan Metzmacher
f82eb0fef6 r25179: fix libunwind detection on x86 based hosts
we need -lunwind-x86 not -lunwind-i686

metze
(This used to be commit 2e5f4781652961d6369a64c48b92697c11262c51)
2007-10-10 12:30:49 -05:00
Stefan Metzmacher
6e4bf4c188 r25177: if configured using --enable-socket-wrapper
allow overwritting the location of the WINBINDD_SOCKET_DIR
via an environment variable

metze
(This used to be commit 93bdd2724cc711005a5f2f223b499199394e78e7)
2007-10-10 12:30:48 -05:00
Jeremy Allison
bb4773e30f r25173: Use the append_buffer version in a loop.
Jeremy.
(This used to be commit 37cf2c272751065245dd46708af0a78f1f0c47df)
2007-10-10 12:30:48 -05:00
Jeremy Allison
2548e43164 r25172: Remove commented out code we will never enable.
Jeremy.
(This used to be commit 6032fbc358c5015b2b6a23e13d978bf41ef9e5f3)
2007-10-10 12:30:48 -05:00
Jeremy Allison
db31df8186 r25171: More pstring removal.
Jeremy.
(This used to be commit 4748d2639796e8caa67fae44d1cf660d49d82663)
2007-10-10 12:30:48 -05:00
Jeremy Allison
3aaca8028e r25170: Remove pstring limits from ms_fnmatch and module load.
Jeremy.
(This used to be commit 764574ee05ea4f13cdd30c0a0668ffeb81756989)
2007-10-10 12:30:48 -05:00
Volker Lendecke
5eb34f5d57 r25169: Fix bug 4028
(This used to be commit 1a022267003480b4487a780ebaa6016f491828a3)
2007-10-10 12:30:48 -05:00
Jeremy Allison
b91b785306 r25167: Fix breakage from mangling rewrite. Use the
new name if unmangling succeeded, not if it
failed. Jerry - please re-test, this should
fix your bug.
Jeremy.
(This used to be commit c215d6e84929b70e4472e19f32ec4f1db7449d90)
2007-10-10 12:30:47 -05:00
Jeremy Allison
ab9d7bf4f9 r25165: Use talloc_asprintf_append_buffer with an unmodified
string.
Jeremy.
(This used to be commit fe30a523dfc77cc373145624246fd3ad5c62b9ac)
2007-10-10 12:30:47 -05:00
Jeremy Allison
47107b2cde r25164: Add talloc_asprintf_append_buffer() and the docs for it.
Jeremy.
(This used to be commit 2243a73d650319208aebbbaf65dfba2a508a7c10)
2007-10-10 12:30:47 -05:00
Jeremy Allison
539635cd94 r25163: Fix wrong ctx passed to talloc_asprintf_append().
Found by Metze's code review (thanks Metze !).
Jeremy.
(This used to be commit a7370eea6be29c0e2adf5ae62aa6182b9165e744)
2007-10-10 12:30:47 -05:00
Michael Adam
5b00e7c389 r25162: Refactor further: add mapping functions between
REGISTRY_VALUE and struct registry_value formats for
registry values. Lacking better naming, I called them
regval_hilvl_to_lolvl and regval_lolvl_to_hilvl for a
start. The might be useful elsewhere, so might be put
into another place later on.

Michael
(This used to be commit 883fd7906165ca10413e4745b3beed59516adf34)
2007-10-10 12:30:47 -05:00
James Peach
8b6366b301 r25161: Don't panic if setgroups fails in non-root mode.
(This used to be commit ea226c5ed97d47649833546d5499213093d1925e)
2007-10-10 12:30:46 -05:00
Michael Adam
f157c9abb7 r25160: Refactor out and slightly clean up canonicalization of the registry value
from smbconf_store_values().

Michael
(This used to be commit 7761f9b3ccf0d9ae9ffe830b04c3be8451ce2112)
2007-10-10 12:30:46 -05:00
Gerald Carter
2e30a02575 r25156: Update coding guiding wrt to primitive data types
(This used to be commit 01d42744903d7ef9044fa4d2ad1cc64594717573)
2007-10-10 12:30:46 -05:00
Stefan Metzmacher
28aa4bff8d r25154: move winbindd code into winbindd/
metze
(This used to be commit 3ac7566ae14c48ff9b0f6b232e0ec4b2f73df558)
2007-10-10 12:30:46 -05:00
Stefan Metzmacher
38b140fe70 r25152: fix headers used in wbinfo.c
metze
(This used to be commit 2a794db3c548330d477497aa66245845486d9888)
2007-10-10 12:30:46 -05:00
Stefan Metzmacher
b6514d02ec r25150: don't recursivly call call dump_core()
as currently seen in 'make test' localy and in the farm

metze
(This used to be commit f41efe01b5a22889f5b18916df9a2f924263e7f9)
2007-10-10 12:30:45 -05:00
Günther Deschner
6005c4e657 r25148: Adapt to coding conventions.
Guenther
(This used to be commit c3b423c52a2bf3f50870158d8c7ffd314c8ac935)
2007-10-10 12:30:45 -05:00
Stefan Metzmacher
b8c5d16258 r25146: rename winbindd_nss.h => winbind_struct_protocol.h
as this header has nothing todo with winbindd nor nss
and it contains the definitions for the struct based
protocol

metze
(This used to be commit e9e03aac2221c44eec89cc957b8bb3be721103bd)
2007-10-10 12:30:45 -05:00
Stefan Metzmacher
28d076d20f r25143: rename public functions from winbind_client.h
init_request	=> winbindd_init_request
free_response	=> winbindd_free_response
read_reply	=> winbindd_read_reply

write_sock	=> winbind_write_sock
read_sock	=> winbind_read_sock
close_sock	=> winbind_close_sock(void)

metze
(This used to be commit 8a95d7a7edcfa5e45bccc6eda5c45d9c308cb95d)
2007-10-10 12:30:45 -05:00
James Peach
45a2713b47 r25142: Panic if setting the group list fails while switching security
contexts. Patch from Tim Prouty <tim.prouty@isilon.com>.
(This used to be commit a136de663f122603e8d34e06027896ff39b35e11)
2007-10-10 12:30:45 -05:00
Jeremy Allison
dd16ae2506 r25141: More pstring removal.
Jeremy.
(This used to be commit cfcf7cf03e1be34e6839c1a659c4e8c1b5358c37)
2007-10-10 12:30:45 -05:00
Michael Adam
34991bbd0c r25140: Less red bars to hurt my eyes...
(This used to be commit f935d21200294c8d29ce527300f605e721cb3620)
2007-10-10 12:30:44 -05:00
Michael Adam
aaa0afaa26 r25139: Avoid code duplication: let regval_ctr_copyvalue() call regval_ctr_addvalue().
This also corrects regval_ctr_copyvalue() in that it cannot create (invalid)
regval containers with dupliacte entries...

Michael
(This used to be commit 2daaaaa835078c543fa12cd1819e8a3d86cf6e5e)
2007-10-10 12:30:44 -05:00
Jeremy Allison
eacd314057 r25138: More pstring elimination. Add a TALLOC_CTX parameter
to unix_convert().
Jeremy.
(This used to be commit 39c211a702e91c34c1a5a689e1b0c4530ea8a1ac)
2007-10-10 12:30:44 -05:00
Jeremy Allison
d0de93ca76 r25136: When tallocing a string to uppercase remember the terminating
'\0' in size calculations.
Jeremy.
(This used to be commit 54c658867db3b6c602080d60936abab3af26e112)
2007-10-10 12:30:43 -05:00
Günther Deschner
1a292def31 r25135: Remove one END_PROFILE(SMBntcreateX) from call_nt_transact_create() which
appears to be a leftover. Should fix the build with profiling enabled.

Jeremy, please check.

Guenther
(This used to be commit 98f2e10e3f7a86b1b30619a25ee15a489ad10d43)
2007-10-10 12:30:43 -05:00
Günther Deschner
fa78132ab5 r25134: Fix Bug #4968 and make dns updates work with heimdal as well (again,
gss_import_name() needs to follow the same logic as in the LDAP sasl wrapping
(see -r25133).

Tested with MIT 1.2.7, 1.3.6, 1.4.3, 1.5.1, 1.6.1 and Heimdal 0.7.2, 1.0,
1.0.1.

Guenther
(This used to be commit 913fb138aa90a6627ee49b2e92d1bbc73e11f9ea)
2007-10-10 12:30:43 -05:00
Günther Deschner
1874c564db r25133: Fix sasl wrapping (for ldap sign&seal).
The gss_import_name() broke as we switched from the internal MIT OID
"gss_nt_krb5_principal" to "GSS_KRB5_NT_PRINCIPAL_NAME" and didn't switch from
passing the krb5_principal (or better: a pointer to that, see MIT's "*HORRIBLE*
bug") to pass the string principal directly.

Jerry, Jeremy, neither I could figure out the need of passing in a
krb5_principal at all nor could I reproduce the crash you were seeing.

I sucessfully tested the code (now importing a string) with MIT 1.2.7, 1.3.6,
1.4.3, 1.5.1, 1.6.1 and Heimdal 0.7.2, 1.0, 1.0.1.

Guenther
(This used to be commit cb2dc715e33467c8b588161e816e72a948f6860c)
2007-10-10 12:30:43 -05:00
Stefan Metzmacher
52936b1c86 r25130: make use only of base types which are provided by libreplace
in winbind client and nss/pam stuff

metze
(This used to be commit 2e13e05fa91788bd128e6940bccc0d2cc7140986)
2007-10-10 12:30:43 -05:00
Stefan Metzmacher
85d1b13fbe r25128: _XOPEN_SOURCE_EXTENDED and socklen_t are always provided by libreplace
metze
(This used to be commit b3ee9adf28ee8136528d0236a3a2c894c2223053)
2007-10-10 12:30:42 -05:00
Simo Sorce
d80fcfce90 r25127: Add ol-schema-migrate.pl to the repo.
This script is useful for migrating OpenLDAP schema files to FDS/RHDS
lidf schema files.

License kindly updated to GPLv3+ at our request.

Simo.
(This used to be commit ab7770b34b3202a5836cfa098187eeed1bd16be3)
2007-10-10 12:30:42 -05:00
Stefan Metzmacher
c44929cbea r25125: create prototypes for 'bool ' functions
metze
(This used to be commit 5afa66970ee831a8be887c9e7eeeaceead6049db)
2007-10-10 12:30:42 -05:00
Jeremy Allison
af3de3fa71 r25121: Remove pstring limits from much of our string handling function.
Still a few left (mainly the substitute ones).
Jeremy.
(This used to be commit 6552e52979a7c6954faa8b2c9c0f08b3779835c4)
2007-10-10 12:30:42 -05:00
Jeremy Allison
6716382ec9 r25120: One more warning.
Jeremy.
(This used to be commit 9cc70e3ccff9c3b20076572235d9dcbfd23e97e5)
2007-10-10 12:30:42 -05:00