1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

73716 Commits

Author SHA1 Message Date
Stefan Metzmacher
11683ccf3e s3:rpc_server/svcctl: fix valgrind bugs in _svcctl_QueryServiceConfig2W()
r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it.

If we always marshall the return buffer, we already have the needed
buffer size and don't need to call ndr_size_* functions.

metze
2011-06-16 12:40:14 +02:00
Stefan Metzmacher
48de3e51ea s3:rpc_server/svcctl: don't allocate return values on a temporary stackframe
And always initialize the whole return structure.

This caused samba3.posix_s3.rpc.svcctl to be flakey.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 11:34:34 CEST 2011 on sn-devel-104
2011-06-16 11:34:34 +02:00
Matthias Dieter Wallnöfer
03ea6b5b9e s4:winbind/wb_samba3_protocol.c - rework it using concrete enum values
This changes commit 49352cafb4 to comply
with kblin's plans.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Jun 16 10:14:52 CEST 2011 on sn-devel-104
2011-06-16 10:14:52 +02:00
Matthias Dieter Wallnöfer
75e77f9fa0 s4:ntvfs subsystems - rework it using concrete enum values
This changes commit 260bc987b0 to comply
with metze's plans.
2011-06-16 09:05:31 +02:00
Stefan Metzmacher
9ba10877aa auth/kerberos/gssapi_pac: fix compiler warnings
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jun 15 19:06:24 CEST 2011 on sn-devel-104
2011-06-15 19:06:24 +02:00
Stefan Metzmacher
8d12649b31 s4:libcli/smb_composite: convert smb2_composite_setpathinfo_send/rev to tevent_req
metze
2011-06-15 17:54:44 +02:00
Günther Deschner
1dbe9706bc librpc: fix buildwarning in NDR_WMI.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jun 15 17:23:49 CEST 2011 on sn-devel-104
2011-06-15 17:23:48 +02:00
Volker Lendecke
68a8c58d12 s3: Add debug level 0 warnings to make_new_server_info_guest
I've got a backtrace where this must have failed, but it is not clear why. If
this fails, we should really complain because we can't start up.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jun 15 15:20:49 CEST 2011 on sn-devel-104
2011-06-15 15:20:49 +02:00
Volker Lendecke
51567de6d7 s3: Fix the return of make_new_server_info_guest 2011-06-15 14:11:05 +02:00
Andreas Schneider
207a84d725 s3-winbind: Fix paranoia checks in winbindd_samr.c.
This fixes looking up the correct unix user instead of allocation a new
uid and creating it.

Fix bug #8215 (winbind unix username lookup doesn't work correctly).
(cherry picked from commit 531edfdd19)

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Jun 15 09:56:01 CEST 2011 on sn-devel-104
2011-06-15 09:56:01 +02:00
Andrew Tridgell
8c14decdb8 build: fixed development symlinks for libraries in subdirectories
this fixes the symlink for libsmbclient.so

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Jun 15 07:23:10 CEST 2011 on sn-devel-104
2011-06-15 07:23:10 +02:00
Andrew Tridgell
720da3cb91 build: fixed dependencies on install prefix for pc files and python scripts
waf can't automatically determine these dependencies as the
construction of the files is via a python function

thanks to Andrew for noticing this bug
2011-06-15 14:13:07 +10:00
Stefan Metzmacher
5d736d8777 s3:utils/net_*registry: use c99 initializers which are supported by old gcc 2.95 compilers (bug #8226)
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jun 15 03:48:41 CEST 2011 on sn-devel-104
2011-06-15 03:48:41 +02:00
Volker Lendecke
df6b877cc2 s3: Fix connecting to ctdb as non-root
This is at least one instance which I could identify

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jun 14 19:06:39 CEST 2011 on sn-devel-104
2011-06-14 19:06:39 +02:00
Volker Lendecke
2817eed741 s3: Fix count_current_connections
"False" is not really a valid return value for "int"..
2011-06-14 17:55:30 +02:00
Volker Lendecke
15149002b6 s3-docs: Fix a typo found by Samba-JP oota <ribbon@samba.gr.jp>
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jun 14 14:06:22 CEST 2011 on sn-devel-104
2011-06-14 14:06:21 +02:00
Volker Lendecke
48fc58596d s3-docs: Fix a duplicate list entry
Thanks to Samba-JP oota <ribbon@samba.gr.jp>
2011-06-14 12:55:03 +02:00
Christian Ambach
7639684f27 s3-utils: fix crash in net cache get
free the blob correctly

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue Jun 14 12:01:59 CEST 2011 on sn-devel-104
2011-06-14 12:01:59 +02:00
Andrew Tridgell
d575b2b0ab samba-tool: disable validation on removing an empty attribute in dbcheck
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Jun 14 10:49:34 CEST 2011 on sn-devel-104
2011-06-14 10:49:34 +02:00
Andrew Tridgell
2320221105 pyldb: make ldb operations more consistent
This changes the controls option on ldb operations to be a keyword
argument, which is more consistent with general python
conventions. This also fixes the pydoc output to include the controls
option.
2011-06-14 09:39:24 +02:00
Andrew Tridgell
8741f03995 pyldb: added validate option to ldb.modify()
This allows validation of ldb messages in a ldb modify operation to be
bypassed, by setting validate=False. This is useful in the dbcheck
tool to allow for removing invalid empty attributes from the database
2011-06-14 09:39:24 +02:00
Stefan Metzmacher
8096b1a9a4 s3:smbd/quotas: add #include "system/filesys.h" (bug #8224)
This should fix the build on FreeBSD

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jun 14 09:38:49 CEST 2011 on sn-devel-104
2011-06-14 09:38:49 +02:00
Michael Adam
9923a8cf43 s3:proto.h: remove prototypes of error functions moved to common code.
ntstatus_to_dos, werror_to_ntstatus, ntstatus_to_werror

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Jun 13 03:31:58 CEST 2011 on sn-devel-104
2011-06-13 03:31:57 +02:00
Volker Lendecke
c118bcf755 s3: Use resolve_wins_send/recv in resolve_wins
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 12 18:19:41 CEST 2011 on sn-devel-104
2011-06-12 18:19:41 +02:00
Volker Lendecke
0dfcf3ef78 s3: Add resolve_wins_send/recv 2011-06-12 17:07:48 +02:00
Volker Lendecke
396b646123 s3: Add wins_server_tag_ips()
For a given tag, return the list of all wins servers
2011-06-12 17:07:48 +02:00
Volker Lendecke
12c3c35596 s3: Add query_wins_list_send/recv 2011-06-12 17:07:48 +02:00
Volker Lendecke
f0994c7495 s3: Fix IO_TIMEOUT handling for wins queries 2011-06-12 17:07:47 +02:00
Volker Lendecke
ebf04d79ab s3: Remove "struct ip_service" from resolve_wins 2011-06-12 17:07:47 +02:00
Volker Lendecke
eb16915e28 nsswitch: Remove some refs to the global winbindd_fd 2011-06-12 17:07:47 +02:00
Sumit Bose
d5661467e1 s3-passdb: Implement new pdb trust calls for the default backend
Signed-off-by: Simo Sorce <idra@samba.org>

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Sun Jun 12 06:45:25 CEST 2011 on sn-devel-104
2011-06-12 06:45:25 +02:00
Matthias Dieter Wallnöfer
97af358656 s4:libcli/raw/raw*.c - add unhandled enum values
Reviewed-by: Jelmer

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Jun 11 18:46:13 CEST 2011 on sn-devel-104
2011-06-11 18:46:13 +02:00
Matthias Dieter Wallnöfer
bf5e625393 s4:torture/ndr/string.c - fix type-punned warning and remove unused variables
Reviewed-by: Jelmer
2011-06-11 16:26:18 +02:00
Matthias Dieter Wallnöfer
62a1e13b29 s4:ntvfs/smb2/vfs_smb2.c - remove unused variable
Reviewed-by: Jelmer
2011-06-11 16:26:13 +02:00
Matthias Dieter Wallnöfer
cda2fa21eb s4:auth/ntlm/auth_unix.c - remove unused variables
Relicts from commit 323c744571

Reviewed-by: Jelmer
2011-06-11 16:25:57 +02:00
Michael Adam
8963e807e3 Revert "s3:idmap_autorid: add a talloc_stackframe() to idmap_autorid_initialize()"
This reverts commit 65490ea4e6.

This sequence of patches needs to be done differently.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sat Jun 11 12:55:11 CEST 2011 on sn-devel-104
2011-06-11 12:55:11 +02:00
Michael Adam
56e94c203f Revert "s3:idmap_autorid: use "idmap config <DOMAIN> : rangesize" instead of "autorid:rangesize""
This reverts commit b0b0b625b5.

This sequence of patches needs to be done differently.
2011-06-11 11:44:31 +02:00
Michael Adam
c4427f0646 Revert "s3:idmap_autorid: fail initialization if the domain is not "*""
This reverts commit cd8dc47bf1.

This sequence of patches needs to be done differently.
2011-06-11 11:44:31 +02:00
Michael Adam
241ed0a042 s3:registry/reg_parse_internal.c: add copyright information 2011-06-11 11:44:31 +02:00
Michael Adam
d901905210 s3:registry/reg_parse_internal.h: add copyright information 2011-06-11 11:44:31 +02:00
Andrew Bartlett
530e4cac2e s3-param Remove 'time offset' from smb.conf
This strange parameter is apparently very rarely used, and it seems to
me that on modern networks, if clients don't have correct clocks and
DST offsets, that many other things (Kerberos) start to fail pretty
quickly, and time and DST tables tend to be internet delivered anyway.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jun 11 03:54:45 CEST 2011 on sn-devel-104
2011-06-11 03:54:44 +02:00
Andreas Schneider
35aeeab29d s3: Update .clang_complete
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Sat Jun 11 00:40:01 CEST 2011 on sn-devel-104
2011-06-11 00:40:01 +02:00
Stefan Metzmacher
fdfb5e95fe s3:libsmb: remove unused cli_state_seqnum infrastructure
metze

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jun 10 20:37:54 CEST 2011 on sn-devel-104
2011-06-10 20:37:54 +02:00
Stefan Metzmacher
f0ba1afe5f s3:libsmb/clireadwrite: calculate cli_write_max_bufsize() correct based on max_xmit
This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.

metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
73128b7cc7 s3:libsmb/clireadwrite: calculate cli_read_max_bufsize() correct based on max_xmit
This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.

metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
5d06b2197b s3:libsmb/clitrans: correctly transfer the seqnum between secondary and primary requests
This is needed to implement SMB signing correct.

metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
1dd24ac06a s3:libsmb/clitrans: fix handling of multi pdu [nt]trans[s][2] calls
We now keep the primary request open for the whole logical request.
The primary request is the one that gets all incoming replies.
While secondary requests are handled as separate one-way requests.

metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
10bb088cf1 s3:libsmb/clitrans: use subreq2 as variable for the secondary requests
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
5146c9ba9d s3:libsmb/clitrans: move MID handling to the end of cli_trans_send() and add a comment
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
0a8fd50bd8 s3:libsmb/clitrans: correctly marshall [nt]trans[s][2] requests
We need to align params and data to 4 byte offsets.

This also correctly recalculates the useable space after each step.

metze
2011-06-10 19:27:05 +02:00